* [PATCH v1 1/1] StandaloneMmPkg: Fix build failure - Bug 2253
@ 2019-11-21 15:06 Sami Mujawar
2019-11-21 15:15 ` [edk2-devel] " Yao, Jiewen
2019-11-21 16:03 ` Laszlo Ersek
0 siblings, 2 replies; 5+ messages in thread
From: Sami Mujawar @ 2019-11-21 15:06 UTC (permalink / raw)
To: devel
Cc: Sami Mujawar, achin.gupta, jiewen.yao, supreeth.venkatesh, lersek,
Matteo.Carlini, Laura.Moretta, nd
The StandaloneMmPkg currently has code for supporting
Arm architecture only. Support for X64 and IA32 is
currently under development on a separate branch.
However, StandaloneMmPkg/StandaloneMmPkg.dsc is
indicating that support for X64 and IA32 is
available which is causing build failures.
This has been reported in
https://bugzilla.tianocore.org/show_bug.cgi?id=2253
This issue has been discussed earlier on the list:
(1) https://edk2.groups.io/g/devel/message/47276
(2) https://edk2.groups.io/g/devel/message/47283
In light of the above, this patch removes IA32 and X64
from SUPPORTED_ARCHITECTURES, until support for the
respective architectures is merged into StandaloneMmPkg.
CC: Achin Gupta <achin.gupta@arm.com>
CC: Jiewen Yao <jiewen.yao@intel.com>
CC: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
CC: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/697_stmm_disable_unsupported_arch_v1
Notes:
v1:
- Fix for Bug 2253 [SAMI]
(https://bugzilla.tianocore.org/show_bug.cgi?id=2253)
StandaloneMmPkg/StandaloneMmPkg.dsc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc b/StandaloneMmPkg/StandaloneMmPkg.dsc
index 8a68d397469bdb83586bfeaebedcd52fd528b20f..f9546e182e25fbcd253de0986a1bb554dae1e975 100644
--- a/StandaloneMmPkg/StandaloneMmPkg.dsc
+++ b/StandaloneMmPkg/StandaloneMmPkg.dsc
@@ -2,7 +2,7 @@
# Standalone MM Platform.
#
# Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
-# Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.<BR>
+# Copyright (c) 2016 - 2019, ARM Limited. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -19,7 +19,7 @@ [Defines]
PLATFORM_VERSION = 1.0
DSC_SPECIFICATION = 0x00010011
OUTPUT_DIRECTORY = Build/StandaloneMm
- SUPPORTED_ARCHITECTURES = IA32|X64|AARCH64
+ SUPPORTED_ARCHITECTURES = AARCH64
BUILD_TARGETS = DEBUG|RELEASE
SKUID_IDENTIFIER = DEFAULT
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Fix build failure - Bug 2253
2019-11-21 15:06 [PATCH v1 1/1] StandaloneMmPkg: Fix build failure - Bug 2253 Sami Mujawar
@ 2019-11-21 15:15 ` Yao, Jiewen
2019-11-21 16:03 ` Laszlo Ersek
1 sibling, 0 replies; 5+ messages in thread
From: Yao, Jiewen @ 2019-11-21 15:15 UTC (permalink / raw)
To: devel@edk2.groups.io, sami.mujawar@arm.com
Cc: achin.gupta@arm.com, supreeth.venkatesh@arm.com,
lersek@redhat.com, Matteo.Carlini@arm.com, Laura.Moretta@arm.com,
nd@arm.com
Reviewed-by: jiewen.yao@intel.com
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sami
> Mujawar
> Sent: Thursday, November 21, 2019 11:07 PM
> To: devel@edk2.groups.io
> Cc: Sami Mujawar <sami.mujawar@arm.com>; achin.gupta@arm.com; Yao,
> Jiewen <jiewen.yao@intel.com>; supreeth.venkatesh@arm.com;
> lersek@redhat.com; Matteo.Carlini@arm.com; Laura.Moretta@arm.com;
> nd@arm.com
> Subject: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Fix build failure - Bug
> 2253
>
> The StandaloneMmPkg currently has code for supporting
> Arm architecture only. Support for X64 and IA32 is
> currently under development on a separate branch.
>
> However, StandaloneMmPkg/StandaloneMmPkg.dsc is
> indicating that support for X64 and IA32 is
> available which is causing build failures.
> This has been reported in
> https://bugzilla.tianocore.org/show_bug.cgi?id=2253
>
> This issue has been discussed earlier on the list:
> (1) https://edk2.groups.io/g/devel/message/47276
>
> (2) https://edk2.groups.io/g/devel/message/47283
>
> In light of the above, this patch removes IA32 and X64
> from SUPPORTED_ARCHITECTURES, until support for the
> respective architectures is merged into StandaloneMmPkg.
>
> CC: Achin Gupta <achin.gupta@arm.com>
> CC: Jiewen Yao <jiewen.yao@intel.com>
> CC: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> CC: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
>
> ---
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/697_stmm_disable_unsupported_a
> rch_v1
>
> Notes:
> v1:
> - Fix for Bug 2253 [SAMI]
> (https://bugzilla.tianocore.org/show_bug.cgi?id=2253)
>
> StandaloneMmPkg/StandaloneMmPkg.dsc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc
> b/StandaloneMmPkg/StandaloneMmPkg.dsc
> index
> 8a68d397469bdb83586bfeaebedcd52fd528b20f..f9546e182e25fbcd253de0986a
> 1bb554dae1e975 100644
> --- a/StandaloneMmPkg/StandaloneMmPkg.dsc
> +++ b/StandaloneMmPkg/StandaloneMmPkg.dsc
> @@ -2,7 +2,7 @@
> # Standalone MM Platform.
> #
> # Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
> -# Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.<BR>
> +# Copyright (c) 2016 - 2019, ARM Limited. All rights reserved.<BR>
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> @@ -19,7 +19,7 @@ [Defines]
> PLATFORM_VERSION = 1.0
> DSC_SPECIFICATION = 0x00010011
> OUTPUT_DIRECTORY = Build/StandaloneMm
> - SUPPORTED_ARCHITECTURES = IA32|X64|AARCH64
> + SUPPORTED_ARCHITECTURES = AARCH64
> BUILD_TARGETS = DEBUG|RELEASE
> SKUID_IDENTIFIER = DEFAULT
>
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] StandaloneMmPkg: Fix build failure - Bug 2253
2019-11-21 15:06 [PATCH v1 1/1] StandaloneMmPkg: Fix build failure - Bug 2253 Sami Mujawar
2019-11-21 15:15 ` [edk2-devel] " Yao, Jiewen
@ 2019-11-21 16:03 ` Laszlo Ersek
2019-11-22 2:20 ` Liming Gao
1 sibling, 1 reply; 5+ messages in thread
From: Laszlo Ersek @ 2019-11-21 16:03 UTC (permalink / raw)
To: Sami Mujawar, devel
Cc: achin.gupta, jiewen.yao, supreeth.venkatesh, Matteo.Carlini,
Laura.Moretta, nd, Liming Gao, Leif Lindholm
On 11/21/19 16:06, Sami Mujawar wrote:
> The StandaloneMmPkg currently has code for supporting
> Arm architecture only. Support for X64 and IA32 is
> currently under development on a separate branch.
>
> However, StandaloneMmPkg/StandaloneMmPkg.dsc is
> indicating that support for X64 and IA32 is
> available which is causing build failures.
> This has been reported in
> https://bugzilla.tianocore.org/show_bug.cgi?id=2253
>
> This issue has been discussed earlier on the list:
> (1) https://edk2.groups.io/g/devel/message/47276
>
> (2) https://edk2.groups.io/g/devel/message/47283
>
> In light of the above, this patch removes IA32 and X64
> from SUPPORTED_ARCHITECTURES, until support for the
> respective architectures is merged into StandaloneMmPkg.
>
> CC: Achin Gupta <achin.gupta@arm.com>
> CC: Jiewen Yao <jiewen.yao@intel.com>
> CC: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> CC: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
>
> ---
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/697_stmm_disable_unsupported_arch_v1
>
> Notes:
> v1:
> - Fix for Bug 2253 [SAMI]
> (https://bugzilla.tianocore.org/show_bug.cgi?id=2253)
>
> StandaloneMmPkg/StandaloneMmPkg.dsc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc b/StandaloneMmPkg/StandaloneMmPkg.dsc
> index 8a68d397469bdb83586bfeaebedcd52fd528b20f..f9546e182e25fbcd253de0986a1bb554dae1e975 100644
> --- a/StandaloneMmPkg/StandaloneMmPkg.dsc
> +++ b/StandaloneMmPkg/StandaloneMmPkg.dsc
> @@ -2,7 +2,7 @@
> # Standalone MM Platform.
> #
> # Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
> -# Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.<BR>
> +# Copyright (c) 2016 - 2019, ARM Limited. All rights reserved.<BR>
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> @@ -19,7 +19,7 @@ [Defines]
> PLATFORM_VERSION = 1.0
> DSC_SPECIFICATION = 0x00010011
> OUTPUT_DIRECTORY = Build/StandaloneMm
> - SUPPORTED_ARCHITECTURES = IA32|X64|AARCH64
> + SUPPORTED_ARCHITECTURES = AARCH64
> BUILD_TARGETS = DEBUG|RELEASE
> SKUID_IDENTIFIER = DEFAULT
>
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
This should be included in edk2-stable201911 -- it fixes obscure build
failures.
Thanks
Laszlo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] StandaloneMmPkg: Fix build failure - Bug 2253
2019-11-21 16:03 ` Laszlo Ersek
@ 2019-11-22 2:20 ` Liming Gao
2019-11-22 9:57 ` Leif Lindholm
0 siblings, 1 reply; 5+ messages in thread
From: Liming Gao @ 2019-11-22 2:20 UTC (permalink / raw)
To: Laszlo Ersek, Sami Mujawar, devel@edk2.groups.io
Cc: achin.gupta@arm.com, Yao, Jiewen, supreeth.venkatesh@arm.com,
Matteo.Carlini@arm.com, Laura.Moretta@arm.com, nd@arm.com,
Leif Lindholm
Laszlo:
>-----Original Message-----
>From: Laszlo Ersek [mailto:lersek@redhat.com]
>Sent: Friday, November 22, 2019 12:04 AM
>To: Sami Mujawar <sami.mujawar@arm.com>; devel@edk2.groups.io
>Cc: achin.gupta@arm.com; Yao, Jiewen <jiewen.yao@intel.com>;
>supreeth.venkatesh@arm.com; Matteo.Carlini@arm.com;
>Laura.Moretta@arm.com; nd@arm.com; Gao, Liming <liming.gao@intel.com>;
>Leif Lindholm <leif.lindholm@linaro.org>
>Subject: Re: [PATCH v1 1/1] StandaloneMmPkg: Fix build failure - Bug 2253
>
>On 11/21/19 16:06, Sami Mujawar wrote:
>> The StandaloneMmPkg currently has code for supporting
>> Arm architecture only. Support for X64 and IA32 is
>> currently under development on a separate branch.
>>
>> However, StandaloneMmPkg/StandaloneMmPkg.dsc is
>> indicating that support for X64 and IA32 is
>> available which is causing build failures.
>> This has been reported in
>> https://bugzilla.tianocore.org/show_bug.cgi?id=2253
>>
>> This issue has been discussed earlier on the list:
>> (1) https://edk2.groups.io/g/devel/message/47276
>>
>> (2) https://edk2.groups.io/g/devel/message/47283
>>
>> In light of the above, this patch removes IA32 and X64
>> from SUPPORTED_ARCHITECTURES, until support for the
>> respective architectures is merged into StandaloneMmPkg.
>>
>> CC: Achin Gupta <achin.gupta@arm.com>
>> CC: Jiewen Yao <jiewen.yao@intel.com>
>> CC: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
>> CC: Laszlo Ersek <lersek@redhat.com>
>> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
>>
>> ---
>> The changes can be seen at:
>>
>https://github.com/samimujawar/edk2/tree/697_stmm_disable_unsupporte
>d_arch_v1
>>
>> Notes:
>> v1:
>> - Fix for Bug 2253 [SAMI]
>> (https://bugzilla.tianocore.org/show_bug.cgi?id=2253)
>>
>> StandaloneMmPkg/StandaloneMmPkg.dsc | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc
>b/StandaloneMmPkg/StandaloneMmPkg.dsc
>> index
>8a68d397469bdb83586bfeaebedcd52fd528b20f..f9546e182e25fbcd253de0986
>a1bb554dae1e975 100644
>> --- a/StandaloneMmPkg/StandaloneMmPkg.dsc
>> +++ b/StandaloneMmPkg/StandaloneMmPkg.dsc
>> @@ -2,7 +2,7 @@
>> # Standalone MM Platform.
>> #
>> # Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
>> -# Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.<BR>
>> +# Copyright (c) 2016 - 2019, ARM Limited. All rights reserved.<BR>
>> #
>> # SPDX-License-Identifier: BSD-2-Clause-Patent
>> #
>> @@ -19,7 +19,7 @@ [Defines]
>> PLATFORM_VERSION = 1.0
>> DSC_SPECIFICATION = 0x00010011
>> OUTPUT_DIRECTORY = Build/StandaloneMm
>> - SUPPORTED_ARCHITECTURES = IA32|X64|AARCH64
>> + SUPPORTED_ARCHITECTURES = AARCH64
>> BUILD_TARGETS = DEBUG|RELEASE
>> SKUID_IDENTIFIER = DEFAULT
>>
>>
>
>Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
>This should be included in edk2-stable201911 -- it fixes obscure build
>failures.
>
Agree. If no objection, I will create pull request for this patch to push it.
Thanks
Liming
>Thanks
>Laszlo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] StandaloneMmPkg: Fix build failure - Bug 2253
2019-11-22 2:20 ` Liming Gao
@ 2019-11-22 9:57 ` Leif Lindholm
0 siblings, 0 replies; 5+ messages in thread
From: Leif Lindholm @ 2019-11-22 9:57 UTC (permalink / raw)
To: Gao, Liming
Cc: Laszlo Ersek, Sami Mujawar, devel@edk2.groups.io,
achin.gupta@arm.com, Yao, Jiewen, supreeth.venkatesh@arm.com,
Matteo.Carlini@arm.com, Laura.Moretta@arm.com, nd@arm.com
On Fri, Nov 22, 2019 at 02:20:52 +0000, Gao, Liming wrote:
> >Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> >
> >This should be included in edk2-stable201911 -- it fixes obscure build
> >failures.
> >
>
> Agree. If no objection, I will create pull request for this patch to push it.
No objection.
/
Leif
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-11-22 9:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-21 15:06 [PATCH v1 1/1] StandaloneMmPkg: Fix build failure - Bug 2253 Sami Mujawar
2019-11-21 15:15 ` [edk2-devel] " Yao, Jiewen
2019-11-21 16:03 ` Laszlo Ersek
2019-11-22 2:20 ` Liming Gao
2019-11-22 9:57 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox