From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web11.70041.1674725740213318505
 for <devel@edk2.groups.io>;
 Thu, 26 Jan 2023 01:35:40 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: thomas.abraham@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9E9E44B3;
	Thu, 26 Jan 2023 01:36:21 -0800 (PST)
Received: from [10.57.75.31] (unknown [10.57.75.31])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F248B3F71E;
	Thu, 26 Jan 2023 01:35:37 -0800 (PST)
Message-ID: <696defbc-0cc9-f16b-aee8-f92b79bdff85@arm.com>
Date: Thu, 26 Jan 2023 09:35:36 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH edk2-platforms 2/5] Platform/StandaloneMm: Remove '-march=armv8-a+nofp' flag
To: Pierre.Gondois@arm.com, devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
 Sami Mujawar <sami.mujawar@arm.com>,
 Leif Lindholm <quic_llindhol@quicinc.com>, Wenyi Xie <xiewenyi2@huawei.com>,
 Ilias Apalodimas <ilias.apalodimas@linaro.org>,
 Omkar Anand Kulkarni <omkar.kulkarni@arm.com>,
 Pranav Madhu <pranav.madhu@arm.com>,
 Sayanta Pattanayak <Sayanta.Pattanayak@arm.com>
References: <20230125102802.663790-1-Pierre.Gondois@arm.com>
 <20230125102802.663790-3-Pierre.Gondois@arm.com>
From: "Thomas Abraham" <thomas.abraham@arm.com>
In-Reply-To: <20230125102802.663790-3-Pierre.Gondois@arm.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 25/01/2023 10:27, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <pierre.gondois@arm.com>
> 
> The '-march=armv8-a+nofp' flag used for PlatformStandaloneMm.dsc
> was removed in the previous patch. The same flag was probably copied
> from this first configuration in:
> commit bd5071cfbde01 ("StMMRpmb: Add support for building StandaloneMm
> image for OP-TEE")
> 
> As the flag is removed for PlatformStandaloneMm.dsc in the previous
> patch, also remove the flag for PlatformStandaloneMmRpmb.dsc.
> 
> CC: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> CC: Omkar Anand Kulkarni <omkar.kulkarni@arm.com>
> CC: Pranav Madhu <pranav.madhu@arm.com>
> CC: Sayanta Pattanayak <Sayanta.Pattanayak@arm.com>
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> ---
>   .../PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc        | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> index 653029c52fdb..611d76e62117 100644
> --- a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> +++ b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> @@ -165,7 +165,7 @@ [Components.common]
>   #
>   ###################################################################################################
>   [BuildOptions.AARCH64]
> -GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 -march=armv8-a+nofp
> +GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
>   GCC:*_*_*_CC_FLAGS = -mstrict-align
>   
>   [BuildOptions.ARM]


Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>