From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 00749AC1215 for ; Thu, 4 Jan 2024 14:43:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=QcXLT5QQiwmI7sjMNOBBnA7FXE+34AxEe6WGEvx+nsY=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704379427; v=1; b=nXkeXnEtg6sQzcT6SLj93Xi+Fi8S/p0UYAtc7EXobTUsMPcAqasvd9qkNtNQCtv2E+IMvkv5 HQkOwzLtEAzRoIV6/flcQdchCOcNld9son0Nc7nx51Yr5uBULFqBBhZ6Vsud8AH6Bf+wM7AwWdS 5EodjrchylOx9KkBcAfxj1cc= X-Received: by 127.0.0.2 with SMTP id I50tYY7687511xPNbMdwbirK; Thu, 04 Jan 2024 06:43:47 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.55405.1704379426874454638 for ; Thu, 04 Jan 2024 06:43:47 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-588-b-lUcgT7PPaxQOJkZnniEQ-1; Thu, 04 Jan 2024 09:43:41 -0500 X-MC-Unique: b-lUcgT7PPaxQOJkZnniEQ-1 X-Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6F54985A589; Thu, 4 Jan 2024 14:43:41 +0000 (UTC) X-Received: from [10.39.194.24] (unknown [10.39.194.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 81E2D492BC6; Thu, 4 Jan 2024 14:43:40 +0000 (UTC) Message-ID: <6973746b-9361-4a0c-396a-96997064603a@redhat.com> Date: Thu, 4 Jan 2024 15:43:39 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg: Check lower 24 bits of ProcessorNumber To: devel@edk2.groups.io, dun.tan@intel.com Cc: Ray Ni , Rahul Kumar , Gerd Hoffmann , Min Xu References: <20240104073216.1327-1-dun.tan@intel.com> <20240104073216.1327-3-dun.tan@intel.com> From: "Laszlo Ersek" In-Reply-To: <20240104073216.1327-3-dun.tan@intel.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ikwdeHW0t4bzHJmZUk5vbhFzx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=nXkeXnEt; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/4/24 08:32, duntan wrote: > Check lower 24 bits of ProcessorNumber instead of > the value of ProcessorNumber in the API > MpInitLibGetProcessorInfo() of MpInitLibUp instance. > Lower 24 bits of ProcessorNumber contains the actual > processor number. > The BIT24 of input ProcessorNumber might be set to > indicate if the EXTENDED_PROCESSOR_INFORMATION will > be retrived. >=20 > Signed-off-by: Dun Tan > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Cc: Min Xu > --- > UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c b/UefiCpuPkg/Li= brary/MpInitLibUp/MpInitLibUp.c > index 3af4911d4b..b804e400e6 100644 > --- a/UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c > +++ b/UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c > @@ -106,7 +106,10 @@ MpInitLibGetProcessorInfo ( > return EFI_INVALID_PARAMETER; > } > =20 > - if (ProcessorNumber !=3D 0) { > + // > + // Lower 24 bits contains the actual processor number. > + // > + if ((ProcessorNumber & (CPU_V2_EXTENDED_TOPOLOGY - 1)) !=3D 0) { > return EFI_NOT_FOUND; > } > =20 Reviewed-by: Laszlo Ersek -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113178): https://edk2.groups.io/g/devel/message/113178 Mute This Topic: https://groups.io/mt/103518743/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-