From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, kraxel@redhat.com
Subject: Re: [edk2-devel] [PATCH v2 1/1] Add missing EFIAPI to VirtioMmioSetQueueAddress
Date: Wed, 2 Jun 2021 19:45:08 +0200 [thread overview]
Message-ID: <6980710e-4ce3-9604-e775-3a1794b1b8f9@redhat.com> (raw)
In-Reply-To: <20210602045935.762211-1-kraxel@redhat.com>
On 06/02/21 06:59, Gerd Hoffmann wrote:
> This error was found while compiling VirtioMmioDeviceLib for X64
> with the GCC5 toolchain, where EFIAPI makes a difference.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h | 1 +
> OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h
> index 785876c75f82..ab53b90d51c9 100644
> --- a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h
> +++ b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h
> @@ -107,6 +107,7 @@ VirtioMmioSetQueueSel (
> );
>
> EFI_STATUS
> +EFIAPI
> VirtioMmioSetQueueAddress (
> IN VIRTIO_DEVICE_PROTOCOL *This,
> IN VRING *Ring,
> diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c
> index 454f008827be..b0d75fb1dd24 100644
> --- a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c
> +++ b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c
> @@ -173,6 +173,7 @@ VirtioMmioSetQueueSel (
> }
>
> EFI_STATUS
> +EFIAPI
> VirtioMmioSetQueueAddress (
> IN VIRTIO_DEVICE_PROTOCOL *This,
> IN VRING *Ring,
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Merged as commit 75e9154f818a, via <https://github.com/tianocore/edk2/pull/1685>, with the following tweak (as shown with git-range-diff):
1: 2abeb914c87e ! 1: f9e70d9c0f8a Add missing EFIAPI to VirtioMmioSetQueueAddress
@@ -1,12 +1,15 @@
Author: Gerd Hoffmann <kraxel@redhat.com>
- Add missing EFIAPI to VirtioMmioSetQueueAddress
+ OvmfPkg/VirtioMmioDeviceLib: Add EFIAPI to VirtioMmioSetQueueAddress
This error was found while compiling VirtioMmioDeviceLib for X64
with the GCC5 toolchain, where EFIAPI makes a difference.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-Id: <20210602045935.762211-1-kraxel@redhat.com>
+ [lersek@redhat.com: prepend module name to subject, trim subject back to
+ allowed length]
+ Reviewed-by: Laszlo Ersek <lersek@redhat.com>
diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h
--- a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h
Thanks!
Laszlo
prev parent reply other threads:[~2021-06-02 17:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 4:59 [PATCH v2 1/1] Add missing EFIAPI to VirtioMmioSetQueueAddress Gerd Hoffmann
2021-06-02 17:45 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6980710e-4ce3-9604-e775-3a1794b1b8f9@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox