Re: [edk2-devel] [PATCH edk2-platforms v2 3/4] Platform/SbsaQemu: use PcdCoreCount directly

["Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>]

W dniu 19.01.2024 o 20:20, Leif Lindholm pisze:
> On Tue, Jan 16, 2024 at 08:48:34 +0100, Marcin Juszkiewicz wrote:
>> During platform initialization we read amount of cpu cores and set
>> PcdCoreCount so there is no need to call FdtHandler.
>>
>> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
>> ---
>>   Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf             |  6 ++----
>>   Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c               | 10 ++++------
>>   .../Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c  | 12 +++---------
>>   3 files changed, 9 insertions(+), 19 deletions(-)

>> diff --git a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c
>> index 9fb17151d7b8..7ef314ae9f67 100644
>> --- a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c
>> +++ b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c
>> @@ -255,7 +255,7 @@ AddMadtTable (
>>    // Initialize GIC Redistributor Structure
>>     EFI_ACPI_6_0_GICR_STRUCTURE Gicr = SBSAQEMU_MADT_GICR_INIT();
>>   
>> -  // Get CoreCount which was determined eariler after parsing device tree
>> +  // Get CoreCount which was determined earlier from TF-A
> 
> Where we got the information from no longer matters, since we've
> abstracted that away.

dropped comment



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114288): https://edk2.groups.io/g/devel/message/114288
Mute This Topic: https://groups.io/mt/103758016/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-