From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 500077803CE for ; Wed, 24 Jan 2024 12:57:23 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=aF8rZr9KVbZmQJhotzLOS1HmH0/gFNlnPqFcrDZS6mA=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:Organization:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706101041; v=1; b=vz7IhFYL0SBQ7yAi3pP/Cq0ZPEBKbfoapcErXvK9I1KeN7+iqS3b1LqjW8tj0wHv1Zi5GbAU qhvkcJDpGISAF9pzz0mZU1XNVg9M/8qhIp4ApKRjoBiChYDaBaw48t66M/ZPPraFheCrqn6m4xw MxOdS53qmiXvueZuR/zaEa1k= X-Received: by 127.0.0.2 with SMTP id T3glYY7687511xtf3n1JKBRE; Wed, 24 Jan 2024 04:57:21 -0800 X-Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by mx.groups.io with SMTP id smtpd.web11.21816.1706101041047498243 for ; Wed, 24 Jan 2024 04:57:21 -0800 X-Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-50e9e5c97e1so6828584e87.0 for ; Wed, 24 Jan 2024 04:57:20 -0800 (PST) X-Gm-Message-State: 9nPlGObTj43iyJqxZ8zGlKrNx7686176AA= X-Google-Smtp-Source: AGHT+IHvcNYlmfNyxOaERnaqP7//hVBy2Nrz6BCY/AmAQ4yTO3NLmWbvhoEy1MsbKq8qnCzqovjKaQ== X-Received: by 2002:ac2:5dd1:0:b0:510:ff7:c008 with SMTP id x17-20020ac25dd1000000b005100ff7c008mr507834lfq.59.1706101039161; Wed, 24 Jan 2024 04:57:19 -0800 (PST) X-Received: from [192.168.200.206] (83.11.3.72.ipv4.supernova.orange.pl. [83.11.3.72]) by smtp.gmail.com with ESMTPSA id vh3-20020a170907d38300b00a2e7d1b6042sm9476336ejc.196.2024.01.24.04.57.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jan 2024 04:57:18 -0800 (PST) Message-ID: <69878092-0dc1-4355-8c45-88d00ab8ba8a@linaro.org> Date: Wed, 24 Jan 2024 13:57:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH edk2-platforms v2 3/4] Platform/SbsaQemu: use PcdCoreCount directly To: Leif Lindholm Cc: devel@edk2.groups.io, Ard Biesheuvel , Graeme Gregory References: <20240116-no-dt-for-cpu-v2-0-6cf078d9ab76@linaro.org> <20240116-no-dt-for-cpu-v2-3-6cf078d9ab76@linaro.org> From: "Marcin Juszkiewicz" Organization: Linaro In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: pl-PL, en-GB, en-HK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=vz7IhFYL; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io W dniu 19.01.2024 o 20:20, Leif Lindholm pisze: > On Tue, Jan 16, 2024 at 08:48:34 +0100, Marcin Juszkiewicz wrote: >> During platform initialization we read amount of cpu cores and set >> PcdCoreCount so there is no need to call FdtHandler. >> >> Signed-off-by: Marcin Juszkiewicz >> --- >> Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf | 6 ++---- >> Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c | 10 ++++------ >> .../Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 12 +++--------- >> 3 files changed, 9 insertions(+), 19 deletions(-) >> diff --git a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c >> index 9fb17151d7b8..7ef314ae9f67 100644 >> --- a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c >> +++ b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c >> @@ -255,7 +255,7 @@ AddMadtTable ( >> // Initialize GIC Redistributor Structure >> EFI_ACPI_6_0_GICR_STRUCTURE Gicr = SBSAQEMU_MADT_GICR_INIT(); >> >> - // Get CoreCount which was determined eariler after parsing device tree >> + // Get CoreCount which was determined earlier from TF-A > > Where we got the information from no longer matters, since we've > abstracted that away. dropped comment -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114288): https://edk2.groups.io/g/devel/message/114288 Mute This Topic: https://groups.io/mt/103758016/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-