Re: [edk2-devel] [PATCH v2 4/6] MdeModulePkg/SecurityManagementLib: Mark the File parameter as OPTIONAL

["Laszlo Ersek" <lersek@redhat.com>]

On 04/16/20 09:33, Guomin Jiang wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2652
> 
> According to the File description, the File is optional and can be NULL.
> 
> Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
>  MdeModulePkg/Include/Library/SecurityManagementLib.h            | 2 +-
>  .../Library/DxeSecurityManagementLib/DxeSecurityManagementLib.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MdeModulePkg/Include/Library/SecurityManagementLib.h b/MdeModulePkg/Include/Library/SecurityManagementLib.h
> index c6ef8c38b9..9bb29121af 100644
> --- a/MdeModulePkg/Include/Library/SecurityManagementLib.h
> +++ b/MdeModulePkg/Include/Library/SecurityManagementLib.h
> @@ -261,7 +261,7 @@ EFIAPI
>  ExecuteSecurity2Handlers (
>    IN  UINT32                           AuthenticationOperation,
>    IN  UINT32                           AuthenticationStatus,
> -  IN  CONST EFI_DEVICE_PATH_PROTOCOL   *File,
> +  IN  CONST EFI_DEVICE_PATH_PROTOCOL   *File, OPTIONAL
>    IN  VOID                             *FileBuffer,
>    IN  UINTN                            FileSize,
>    IN  BOOLEAN                          BootPolicy
> diff --git a/MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.c b/MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.c
> index b541dbab3c..de1eb53183 100644
> --- a/MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.c
> +++ b/MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.c
> @@ -473,7 +473,7 @@ EFIAPI
>  ExecuteSecurity2Handlers (
>    IN  UINT32                           AuthenticationOperation,
>    IN  UINT32                           AuthenticationStatus,
> -  IN  CONST EFI_DEVICE_PATH_PROTOCOL   *File,
> +  IN  CONST EFI_DEVICE_PATH_PROTOCOL   *File, OPTIONAL
>    IN  VOID                             *FileBuffer,
>    IN  UINTN                            FileSize,
>    IN  BOOLEAN                          BootPolicy
> 

The documentation of the ExecuteSecurity2Handlers() function again mixes
"File" and "DevicePath". All of those should be in sync.

Laszlo