Re: [PATCH v3 00/32] .mailmap: Add mailmap file to have a cleaner git history

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

Hi Laszlo,

On 1/3/20 2:48 PM, Laszlo Ersek wrote:
> On 01/02/20 20:23, Philippe Mathieu-Daude wrote:
>> The .mailmap git feature helps fixing commit mistakes (in name/email).
>>
>> The easiest way to use it is with the --use-mailmap flag:
>>
>>    $ git log --use-mailmap
>>
>> See documentation [1] and [2], and interesting blog [3].
>>
>> Laszlo replied [4] to v1 explaining stewards want to avoid avoid
>> cross-domain mapping, and suggested to split in per email-address
>> patches, so contributors can individually Ack/Nack.
>>
>> This v3 collects the patches of the 30 developers who replied to
>> the v2 [5] with their R-b tag.
> 
> OK. So am I correct to think that this sub-series is ready for merging?
> 
>>   There is an exception with patch
> 
> Hmmm... unfinished thought. :) Apparently, there is a patch that
> prevents the series from being merged? Which one?

This comment was about patch 13/32, but Jiewen Yao already reviewed it, 
so this series is fully reviewed by each developer.

>> I dropped the unreviewed patches and am cc'ing this series to the
>> Tianocore stewards, as suggested by Laszlo in [6]. Each developer
>> will still be Cc'ed in case a modification was requested, he/her
>> can verify.
> 
> Ah, OK, so this is *not* the final version (for round 1, per [6]), just yet.
> 
> Can you please monitor the remaining feedback for this series? If
> everyone is happy with the v3 updates, and you determine that the patch
> set is fully reviewed, I can help pick up the new tags, and merge the
> series.

Since the change is a one-line, I'd prefer avoid respining the whole series.

IMHO the series is ready for step #4 "stewards go through the backlog, 
and decide one by one whether, for person X, the proposed mappings are 
cross-domain or not, and ACK or NACK" which I don't really get.
I suppose this will be resolved in the open on the mailing list, so 
individuals will get notified their patch got refused.

Thank for offering to pick and merge this series!

Phil.

>>
>> This series is available at:
>> https://gitlab.com/philmd/edk2/commits/mailmap-v3
>>
>> Regards,
>>
>> Phil.
>>
>> [1] https://git-scm.com/docs/git-shortlog#_mapping_authors
>> [2] https://git-scm.com/docs/git-check-mailmap#_mapping_authors
>> [3] https://github.com/sympy/sympy/wiki/Using-.mailmap#making-mailmap-entries
>> [4] https://edk2.groups.io/g/devel/message/51657
>> [5] https://edk2.groups.io/g/devel/message/51834
>> [6] https://edk2.groups.io/g/devel/message/51906
[...]