From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.6934.1668759155687419145 for ; Fri, 18 Nov 2022 00:12:35 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E3A0B23A; Fri, 18 Nov 2022 00:12:40 -0800 (PST) Received: from [10.34.100.128] (unknown [10.34.100.128]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9DB853F73B; Fri, 18 Nov 2022 00:12:33 -0800 (PST) Message-ID: <69d2694f-d5ab-01d9-894a-2bce5d31f46a@arm.com> Date: Fri, 18 Nov 2022 09:12:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] DynamicTablesPkg: SSDT _LPI revision is incorrect To: Jeff Brasen , devel@edk2.groups.io Cc: quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, Sami.Mujawar@arm.com, Alexei.Fedorov@arm.com References: From: "PierreGondois" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello Jeff, The Lpi version should effectively be 0: Reviewed-by: Pierre Gondois Regards, Pierre On 11/15/22 19:01, Jeff Brasen wrote: > _LPI Revision should be 0 per the ACPI 6.5 specification. > "The revision number of the _LPI object. Current revision is 0." > > Signed-off-by: Jeff Brasen > --- > .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c > index d06c7615fb..91199c4af2 100644 > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c > @@ -482,7 +482,7 @@ GenerateLpiStates ( > } > > // We do not support the LevelId field for now, let it to 0. > - Status = AmlCreateLpiNode (AslName, 1, 0, ScopeNode, &LpiNode); > + Status = AmlCreateLpiNode (AslName, 0, 0, ScopeNode, &LpiNode); > if (EFI_ERROR (Status)) { > ASSERT (0); > return Status;