From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D6E3F2282E591 for ; Wed, 25 Apr 2018 14:14:57 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 32609406C745; Wed, 25 Apr 2018 21:14:56 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-20.rdu2.redhat.com [10.10.121.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id 213272023430; Wed, 25 Apr 2018 21:14:54 +0000 (UTC) To: Evan Lloyd , "ruiyu.ni@intel.com" References: From: Laszlo Ersek Cc: "edk2-devel (edk2-devel@lists.01.org)" Message-ID: <69dccdf5-9397-3bdc-0b89-66361a685719@redhat.com> Date: Wed, 25 Apr 2018 23:14:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 25 Apr 2018 21:14:56 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 25 Apr 2018 21:14:56 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: Incorrect Author on patch X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 21:14:58 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 04/25/18 17:02, Evan Lloyd wrote: > Hi Ruiyu. > When we look at the edk2 git log, or GitHub https://github.com/tianocore/edk2/commit/ee4dc24f57c32a445e7c747396c9bfbd8b221568 > we see that Sami's AcpiView patch shows you as the Author. > I'm not sure what might have caused that (and it is obviously accidental), but it is a little unfortunate in that the commit doesn't show up on Sami's GitHub stats. > Fortunately, this is not currently significant for our organisation, although I'm sure Sami would prefer to have the credit. > This is a trivial matter, but you may wish to understand what caused it so that you don't accidentally upset someone for whom the stats are significant. Right, this occurred at least one other time as well: see commit 8b5c80e0296c ("MdeModulePkg/UefiBootManagerLib: fix AddLoadOptionVariable docs/prototype", 2018-04-23). Ray pushed the patch (so the Committer field is certainly right), but Ray's name+email replaced mine in the Author field. I had noticed that earlier, but now I'm seeing it as a pattern. I believe this is a tooling issue. I notice the following bit on the commit message: Change-Id: I8a609d6502b6f8929b2f568acaa147065003b6f4 I certainly didn't post the patch with that, and I doubt Ray added it manually. So, whatever tool Ray used to handle the patch lost the authorship information. And, I see the exact same kind of tag, namely Change-Id: Ifa23dc80ab8ab042c56e88424847e796a8122a7c on commit ee4dc24f57c3 ("ShellPkg: Add acpiview tool to dump ACPI tables", 2018-04-23), which you mention. ... In fact, my patch happens to be the direct ancestor of Sami's, in the git history, and their commit times are just ~3 minutes apart. I'm quite certain Ray has started using a new tool. For example, commit bc2288f59ba2 ("UefiCpuPkg/MpInitLib: put mReservedApLoopFunc in executable memory", 2018-03-08) was also committed by Ray, *but* Jian's authorship was preserved fine. (No "Change-Id" either.) ... Oh... it looks like those Change-Id's were added by Gerrit: https://git.eclipse.org/r/Documentation/user-changeid.html And then, please look at this: https://gerrit-review.googlesource.com/Documentation/error-invalid-author.html For every pushed commit Gerrit verifies that the e-mail address of the author matches one of the registered e-mail addresses of the pushing user. If this is not the case pushing the commit fails with the error message "invalid author". This policy can be bypassed by having the access right 'Forge Author'. Uh, what?... Gerrit says "invalid author" if Ray pushes a patch that wasn't authored by himself? And the option to override that is called "forge" author? O_o Anyway, the page continues, If pushing to Gerrit fails with the error message "invalid author" and somebody else is author of the commit for which the push fails, then you have no permissions to forge the author identity. In this case you may contact the project owner to request the access right '+1 Forge Author Identity' in the 'Forge Identity' category or ask the maintainer to commit this change on the author’s behalf. Ray, if you absolutely must use Gerrit, please make sure that you have the '+1 Forge Author Identity' access right. IMO, we maintainers are responsible for preserving git metadata the best we can. (For example, if a patch is applied from the mailing list with "git am", it preserves the authorship information -- the documentation says, 'The commit author name is taken from the "From: " line of the message, and commit author date is taken from the "Date: " line of the message.') Thank you! Laszlo