From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.1371.1602173878640839256 for ; Thu, 08 Oct 2020 09:17:58 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: linux.intel.com, ip: 134.134.136.24, mailfrom: maciej.rabeda@linux.intel.com) IronPort-SDR: taycZK0i6bMNoPwJbRo068bgMWakbO/mr/6OzBK7WKUUD/J1e3Jz7C+/fVVtc4yb/IhIi7HmEr iXWqNqBa0knQ== X-IronPort-AV: E=McAfee;i="6000,8403,9768"; a="165476453" X-IronPort-AV: E=Sophos;i="5.77,351,1596524400"; d="scan'208";a="165476453" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2020 09:17:57 -0700 IronPort-SDR: LWvElTc2xuWw4hVyKybp1NSmlSPwwj3rnyMgVc3kTfrSFnkComH4Ch0SufD96IGrGWuaxIxWL9 9ARjkaAUPAuA== X-IronPort-AV: E=Sophos;i="5.77,351,1596524400"; d="scan'208";a="519398598" Received: from mrabeda-mobl.ger.corp.intel.com (HELO [10.213.18.150]) ([10.213.18.150]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2020 09:17:55 -0700 Subject: Re: [edk2-devel] [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared when reset To: devel@edk2.groups.io, abner.chang@hpe.com Cc: Wu Jiaxin , Fu Siyuan , "Wang, Nickle (HPS SW)" References: <20200928062934.505108-1-abner.chang@hpe.com> From: "Maciej Rabeda" Message-ID: <69ff5257-c9dd-a891-d6d2-0ea78bba307f@linux.intel.com> Date: Thu, 8 Oct 2020 18:17:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: pl Hi Abner, Waiting for review on a different patch on NetworkPkg, else CI likely fires in my face when I try to integrate yours. https://edk2.groups.io/g/devel/message/65833 Thanks, Maciej On 08-Oct-20 15:50, Abner Chang wrote: > Hi Maciej, > Could you please help to merge this patch? Thanks! > Abner > >> -----Original Message----- >> From: Rabeda, Maciej [mailto:maciej.rabeda@linux.intel.com] >> Sent: Tuesday, September 29, 2020 9:47 PM >> To: Chang, Abner (HPS SW/FW Technologist) ; >> devel@edk2.groups.io >> Cc: Wu Jiaxin ; Fu Siyuan ; >> Wang, Nickle (HPS SW) >> Subject: Re: [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared >> when reset >> >> Reviewed-by: Maciej Rabeda >> >> On 28-Sep-20 08:29, Abner Chang wrote: >>> BZ #2909, >>> INVALID URI REMOVED >>> e.org_show-5Fbug.cgi-3Fid- >> 3D2909&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_ >> SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=gVilLut38Vw51w0YX >> bkL2XI7A >>> ieZI7M- >> u7_bYls4zQo&s=eavHqEkeSVmQnn5EYDmq9TnEyjp8MS3_hdpPDgG9hSY&e= >>> When Http->Configure() is invoked with HttpConfigData set to NULL to >>> reset the EFI HTTP instance, TLS child instance is destroyed but >>> HttpInstance->TlsChildHandle is not set to NULL. After reconfiguring >>> HTTP through Http->Configure() and sending the HTTP request to HTTPS >>> URL, TLS child instance is not recreated because >>> HttpInstance->TlsChildHandle is not NULL. >>> >>> Signed-off-by: Abner Chang >>> >>> Cc: Maciej Rabeda >>> Cc: Wu Jiaxin >>> Cc: Fu Siyuan >>> Cc: Nickle Wang >>> --- >>> NetworkPkg/HttpDxe/HttpProto.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/NetworkPkg/HttpDxe/HttpProto.c >>> b/NetworkPkg/HttpDxe/HttpProto.c index 3c7c6ff9f0c..afc7db5a726 >> 100644 >>> --- a/NetworkPkg/HttpDxe/HttpProto.c >>> +++ b/NetworkPkg/HttpDxe/HttpProto.c >>> @@ -873,6 +873,7 @@ HttpCleanProtocol ( >>> // Destroy the TLS instance. >>> // >>> HttpInstance->TlsSb->DestroyChild (HttpInstance->TlsSb, >>> HttpInstance->TlsChildHandle); >>> + HttpInstance->TlsChildHandle = NULL; >>> } >>> >>> if (HttpInstance->Tcp4ChildHandle != NULL) { > > > > >