From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65])
 by mx.groups.io with SMTP id smtpd.web10.36475.1675067892027593751
 for <devel@edk2.groups.io>;
 Mon, 30 Jan 2023 00:38:12 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@posteo.de header.s=2017 header.b=Dqfu1L/b;
 spf=pass (domain: posteo.de, ip: 185.67.36.65, mailfrom: mhaeuser@posteo.de)
Received: from submission (posteo.de [185.67.36.169]) 
	by mout01.posteo.de (Postfix) with ESMTPS id 6DA5E240159
	for <devel@edk2.groups.io>; Mon, 30 Jan 2023 09:38:10 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017;
	t=1675067890; bh=B4bLypVPxl2i4y4TXpmTClbw0eSDi22O30RTN+hu3fU=;
	h=From:Subject:Date:Cc:To:From;
	b=Dqfu1L/bWyck+OT+353Edede23azPrcNd2bUs7JgWlc+TfHCO5Kg7oYq1t5Aoc/B5
	 pUlPzCfp1WglZuy8pYuUObBMCCztjJmiTEIHTqrX2yvxA97Nko0UZKOw8dqSLJISmH
	 SqfpWu+rBvmYdOx45ttbtDrVtYyMKWY54HvkS0el/RKdSUTUGpSp/bj70u3jDPnDgh
	 O+4pZwqzfCQxqO/IMmHmg8R4P4CfP4Y29bytj5+DZxXvCQ6TLebF4TaRX84cmz64PK
	 yYRwaSI5oNSOFFYuFO1ODSYOBSahz5LvAIQiskiuCYt/PZZu6rrtW4T5ccKGwNbZIt
	 zoH+st+RsLa9A==
Received: from customer (localhost [127.0.0.1])
	by submission (posteo.de) with ESMTPSA id 4P51m14jsbz9rxK;
	Mon, 30 Jan 2023 09:38:09 +0100 (CET)
From: =?UTF-8?B?TWFydmluIEjDpHVzZXI=?= <mhaeuser@posteo.de>
Mime-Version: 1.0 (1.0)
Subject: Re: [edk2-platforms][PATCH v3 02/11] Ext4Pkg: Fix incorrect checksum metadata feature check
Date: Mon, 30 Jan 2023 08:38:09 +0000
Message-Id: <6BC46602-945D-4BB6-80AC-7E2D6ADA420A@posteo.de>
References: <CAKbZUD2FbxOLzHX1drCO9sJMzypruzDBZm1JZbtVMFgrisXGVg@mail.gmail.com>
Cc: Savva Mitrofanov <savvamtr@gmail.com>,
 edk2-devel-groups-io <devel@edk2.groups.io>,
 Vitaly Cheptsov <vit9696@protonmail.com>
In-Reply-To: <CAKbZUD2FbxOLzHX1drCO9sJMzypruzDBZm1JZbtVMFgrisXGVg@mail.gmail.com>
To: Pedro Falcato <pedro.falcato@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

With the commit message changed,

Reviewed-by: Marvin H=C3=A4user <mhaeuser@posteo.de>

> On 27. Jan 2023, at 15:29, Pedro Falcato <pedro.falcato@gmail.com> wrote:
>=20
> =EF=BB=BFOn Fri, Jan 27, 2023 at 10:02 AM Marvin H=C3=A4user <mhaeuser@pos=
teo.de> wrote:
>>=20
>>> On 27. Jan 2023, at 10:29, Savva Mitrofanov <savvamtr@gmail.com> wrote:
>>>=20
>>> Missing comparison !=3D 0 leads to broken logic condition.
>>=20
>> The actual issue appears to be FeaturesCompat vs FeaturesRoCompat (latter=
 is hidden by your usage of the macro). Checking for !=3D 0 is redundant (al=
beit required by the code style guideline for non-functional reasons). Pleas=
e confirm and update the commit message if you agree.
>=20
> +1, the actual issue comes from using the wrong feature mask and not the !=
=3D 0.
> If we get a v4, please update, else I can rewrite it myself.
>=20
> Reviewed-by: Pedro Falcato <pedro.falcato@gmail.com>
>=20
> --=20
> Pedro