From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atlmailgw1.ami.com (atlmailgw1.ami.com [63.147.10.40]) by mx.groups.io with SMTP id smtpd.web12.389.1586297906339963958 for ; Tue, 07 Apr 2020 15:18:26 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: ami.com, ip: 63.147.10.40, mailfrom: oleksiyy@ami.com) X-AuditID: ac1060b2-0f7ff700000018d4-cb-5e8cfc312606 Received: from atlms2.us.megatrends.com (atlms2.us.megatrends.com [172.16.96.152]) (using TLS with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client did not present a certificate) by atlmailgw1.ami.com (Symantec Messaging Gateway) with SMTP id 33.26.06356.13CFC8E5; Tue, 7 Apr 2020 18:18:25 -0400 (EDT) Received: from ATLMS1.us.megatrends.com ([fe80::8c55:daf0:ef05:5605]) by atlms2.us.megatrends.com ([fe80::29dc:a91e:ea0c:cdeb%12]) with mapi id 14.03.0468.000; Tue, 7 Apr 2020 18:17:36 -0400 From: "Oleksiy Yakovlev" To: Bret Barkelew , "devel@edk2.groups.io" CC: "bob.c.feng@intel.com" , "liming.gao@intel.com" , "Kinney, Michael D" , Felix Polyudov Subject: Re: [EXTERNAL] [edk2-devel] [PATCH 3/7] MdePkg: REST style formset Thread-Topic: [EXTERNAL] [edk2-devel] [PATCH 3/7] MdePkg: REST style formset Thread-Index: AQHWDSZp5nhvCJmORU2hzVi+Avb35KhuN8ZQgABESwD//74f4A== Date: Tue, 7 Apr 2020 22:17:36 +0000 Message-ID: <6BD875C24FFE2A4E8D6EFC142C67836F03FF6566C3@atlms1.us.megatrends.com> References: <20200403202238.34484-1-oleksiyy@ami.com>,<20200403202238.34484-4-oleksiyy@ami.com> ,<6BD875C24FFE2A4E8D6EFC142C67836F03FF6566A8@atlms1.us.megatrends.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.97.158] MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFKsWRmVeSWpSXmKPExsWyRiBhhq7hn544gxU/hC1+HZ3HZvFuy0I2 i/YJs9ksVtzbwG7R0fGPyYHVY/v3C4wei/e8ZPJo3fGXPYA5qoHRJjEvL78ksSRVISW1ONlW KaAosywxuVJJITPFVslQSaEgJzE5NTc1r8RWKbGgIDUvRcmOSwED2ACVZeYppOYl56dk5qXb KnkG++taWJha6hoq2YVkpCpk5qXlF+UmlmTm5ykk5+eVAFWnpgBFFRK6OTOeNv9iLGg5ylix 4lorYwPjlE2MXYycHBICJhIPZ21k72Lk4hAS2MUkcfLCWmYI5xCjxK4bC5hBqtgENCXenHvB AmKLCCRI/J58lQWkiFlgO6PEhJ0rmEASwgLeEucur2KCKPKR+Pv9HVSDk8TUb0vAbBYBFYne Y1fYQGxegUCJGQ2TGSG2nWaS2LzyJFARBwenQKzEri0JIDWMAmIS30+tAZvJLCAucevJfCaI swUkluw5zwxhi0q8fPyPFcJWlHj64QU7RH2+xK/lW9khdglKnJz5hGUCo8gsJKNmISmbhaQM Iq4jsWD3JzYIW1ti2cLXzDD2mQOPmZDFFzCyr2IUSizJyU3MzEkvN9RLzM3US87P3cQISTib djC2XDQ/xMjEwQgMVQ5mJRFeqd7OOCHelMTKqtSi/Pii0pzU4kOMTsAAmsgsxQ2KPGBqiDc2 MJAShXEMTcxMzI3MDS1NzI2NlcR5a/R94oQE0oGpKjs1tSC1CGYIEwenVANjX2Cj4arTvhUn 9ncGmDgdOrFooaob+33J54dXGCU05t8pvDbv1OeHzs8vnMx+0fC7/37G0vzXX99olka7PXnb JjTHfaLKmpkfHR2PTt59Lkg9/GP5hcD27a1tt3x/S/xwkE71Y10926LSLvT866mV8raTNJ04 Gup8vF7nb9e4wr3khmvYkvk7lViKMxINtZiLihMB2mxgcE0DAAA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_6BD875C24FFE2A4E8D6EFC142C67836F03FF6566C3atlms1usmegat_" --_000_6BD875C24FFE2A4E8D6EFC142C67836F03FF6566C3atlms1usmegat_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for pointing out. Will update. Regards, Oleksiy. From: Bret Barkelew [mailto:Bret.Barkelew@microsoft.com] Sent: Tuesday, April 07, 2020 6:13 PM To: Oleksiy Yakovlev; devel@edk2.groups.io Cc: bob.c.feng@intel.com; liming.gao@intel.com; Kinney, Michael D; Felix P= olyudov Subject: RE: [EXTERNAL] [edk2-devel] [PATCH 3/7] MdePkg: REST style formse= t The other patch had a typo in the subject. This one has: extern EFI_GUID gEfiHiiUserCredentialFormsetGuid; +extern EFI_GUID gEfiHiiResetStyleFormsetGuid; Based on the name of the #DEFINE, I'm guessing this should be "gEfiHiiRest= StyleFormsetGuid", not "...Reset...". - Bret From: Oleksiy Yakovlev Sent: Tuesday, April 7, 2020 3:10 PM To: Bret Barkelew; devel@edk2.groups.i= o Cc: bob.c.feng@intel.com; liming.gao@intel.co= m; Kinney, Michael D; Felix Polyudov Subject: RE: [EXTERNAL] [edk2-devel] [PATCH 3/7] MdePkg: REST style formse= t Hi Bret. Can you be more specific? I do not see any typos in Subject field. Regards, Oleksiy. From: Bret Barkelew [mailto:Bret.Barkelew@microsoft.com] Sent: Tuesday, April 07, 2020 5:50 PM To: devel@edk2.groups.io; Oleksiy Yakovlev Cc: bob.c.feng@intel.com; liming.gao@intel.com; Kinney, Michael D; Felix P= olyudov; Oleksiy Yakovlev Subject: RE: [EXTERNAL] [edk2-devel] [PATCH 3/7] MdePkg: REST style formse= t Typo here. - Bret From: Oleksiy Yakovlev via groups.io Sent: Friday, April 3, 2020 1:35 PM To: devel@edk2.groups.io Cc: bob.c.feng@intel.com; liming.gao@intel.co= m; Kinney, Michael D; Felixp@ami.com; oleksiyy@ami.com Subject: [EXTERNAL] [edk2-devel] [PATCH 3/7] MdePkg: REST style formset New ClassGuid EFI_HII_REST_STYLE_FORMSET_GUID is defined. A formset with this class GUID indicates all the questions in the formset support REST style operation and can be exposed to a REST service point. In question level, a new flag EFI_IFR_FLAG_REST_STYLE is defined. An Opcode with this flag indicates this question support REST style operat= ion and can be exposed to a REST service point. (UEFI 2.8 mantis 1853) Signed-off-by: Oleksiy Yakovlev --- MdePkg/Include/Guid/HiiPlatformSetupFormset.h | 4 ++++ MdePkg/Include/Uefi/UefiInternalFormRepresentation.h | 1 + 2 files changed, 5 insertions(+) diff --git a/MdePkg/Include/Guid/HiiPlatformSetupFormset.h b/MdePkg/Includ= e/Guid/HiiPlatformSetupFormset.h index 540483d..a6ba55b 100644 --- a/MdePkg/Include/Guid/HiiPlatformSetupFormset.h +++ b/MdePkg/Include/Guid/HiiPlatformSetupFormset.h @@ -22,8 +22,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #define EFI_HII_USER_CREDENTIAL_FORMSET_GUID \ { 0x337f4407, 0x5aee, 0x4b83, { 0xb2, 0xa7, 0x4e, 0xad, 0xca, 0x30, 0x8= 8, 0xcd } } +#define EFI_HII_REST_STYLE_FORMSET_GUID \ + { 0x790217bd, 0xbecf, 0x485b, { 0x91, 0x70, 0x5f, 0xf7, 0x11, 0x31, 0x8= b, 0x27 } } + extern EFI_GUID gEfiHiiPlatformSetupFormsetGuid; extern EFI_GUID gEfiHiiDriverHealthFormsetGuid; extern EFI_GUID gEfiHiiUserCredentialFormsetGuid; +extern EFI_GUID gEfiHiiResetStyleFormsetGuid; #endif diff --git a/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h b/MdePkg= /Include/Uefi/UefiInternalFormRepresentation.h index 4a1346a..40fcdb7 100644 --- a/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h +++ b/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h @@ -825,6 +825,7 @@ typedef struct _EFI_IFR_QUESTION_HEADER { #define EFI_IFR_FLAG_READ_ONLY 0x01 #define EFI_IFR_FLAG_CALLBACK 0x04 #define EFI_IFR_FLAG_RESET_REQUIRED 0x10 +#define EFI_IFR_FLAG_REST_STYLE 0x20 #define EFI_IFR_FLAG_RECONNECT_REQUIRED 0x40 #define EFI_IFR_FLAG_OPTIONS_ONLY 0x80 -- 2.9.0.windows.1 Please consider the environment before printing this email. The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be rea= d only by the individual or entity to whom it is addressed or by their desi= gnee. If the reader of this message is not the intended recipient, you are = on notice that any distribution of this message, in any form, is strictly p= rohibited. Please promptly notify the sender by reply e-mail or by telepho= ne at 770-246-8600, and then delete or destroy all copies of the transmissi= on. P Please consider the environment before printing this email The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . Please consider the environment before printing this email. The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be rea= d only by the individual or entity to whom it is addressed or by their desi= gnee. If the reader of this message is not the intended recipient, you are = on notice that any distribution of this message, in any form, is strictly p= rohibited. Please promptly notify the sender by reply e-mail or by telepho= ne at 770-246-8600, and then delete or destroy all copies of the transmissi= on. --_000_6BD875C24FFE2A4E8D6EFC142C67836F03FF6566C3atlms1usmegat_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Thanks for pointing o= ut.

Will update.

 

Regards, Oleksiy.

 

From: Bret Ba= rkelew [mailto:Bret.Barkelew@microsoft.com]
Sent: Tuesday, April 07, 2020 6:13 PM
To: Oleksiy Yakovlev; devel@edk2.groups.io
Cc: bob.c.feng@intel.com; liming.gao@intel.com; Kinney, Michael D; = Felix Polyudov
Subject: RE: [EXTERNAL] [edk2-devel] [PATCH 3/7] MdePkg: REST style= formset

 

The other patch had a typo in the subject.

 

This one has:

 extern EFI_GUID gEfiHiiUserCredentialFormsetGuid;
+extern EFI_GUID gEfiHiiResetStyleFor= msetGuid;
 
Based on the name of the #DEFINE, I’m guessing this should be “= ;gEfiHiiRestStyleFormsetGuid”, not &= #8220;…Reset…”.

 

- Bret

 

From: Ol= eksiy Yakovlev
Sent: Tuesday, April 7, 2020 3:10 PM
To: Bret Barkelew; devel@edk2.groups.io
Cc: bob.c.feng@intel.com; liming.gao@intel.com; Ki= nney, Michael D; Felix Polyudov
Subject: RE: [EXTERNAL] [edk2-devel] [PATCH 3/7] MdePkg: REST style= formset

 

Hi Bret.

 

Can you be more speci= fic?

I do not see any typo= s in Subject field.

 

Regards, Oleksiy.

 

From: Bret Ba= rkelew [mailto:Bret.Barkelew@microsoft.com]
Sent: Tuesday, April 07, 2020 5:50 PM
To: devel@edk2.groups.io; Oleksiy Yakovlev
Cc: bob.c.feng@intel.com; liming.gao@intel.com; Kinney, Michael D; = Felix Polyudov; Oleksiy Yakovlev
Subject: RE: [EXTERNAL] [edk2-devel] [PATCH 3/7] MdePkg: REST style= formset

 

Typo here.

 

- Bret

 

From: Oleksiy Yakovlev via groups.io
Sent: Friday, April 3, 2020 1:35 PM
To: devel@edk2.groups.io
Cc: bob.c.feng@intel.com; liming.gao@intel.com; Ki= nney, Michael D; Felixp@ami.com; oleksiyy@ami.com
Subject: [EXTERNAL] [edk2-devel] [PATCH 3/7] MdePkg: REST style for= mset

 

New ClassGuid EFI_HI= I_REST_STYLE_FORMSET_GUID is defined. A formset with
this class GUID indicates all the questions in the formset support REST style operation and can be exposed to a REST service point. 
In question level, a new flag EFI_IFR_FLAG_REST_STYLE is defined.
An Opcode with this flag indicates this question support REST style operat= ion
and can be exposed to a REST service point.
(UEFI 2.8 mantis 1853)

Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
---
 MdePkg/Include/Guid/HiiPlatformSetupFormset.h    = ;    | 4 ++++
 MdePkg/Include/Uefi/UefiInternalFormRepresentation.h | 1 +
 2 files changed, 5 insertions(+)

diff --git a/MdePkg/Include/Guid/HiiPlatformSetupFormset.h b/MdePkg/Includ= e/Guid/HiiPlatformSetupFormset.h
index 540483d..a6ba55b 100644
--- a/MdePkg/Include/Guid/HiiPlatformSetupFormset.h
+++ b/MdePkg/Include/Guid/HiiPlatformSetupFormset.h
@@ -22,8 +22,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #define EFI_HII_USER_CREDENTIAL_FORMSET_GUID \
   { 0x337f4407, 0x5aee, 0x4b83, { 0xb2, 0xa7, 0x4e, 0xad, 0xca,= 0x30, 0x88, 0xcd } }
 
+#define EFI_HII_REST_STYLE_FORMSET_GUID \
+  { 0x790217bd, 0xbecf, 0x485b, { 0x91, 0x70, 0x5f, 0xf7, 0x11, = 0x31, 0x8b, 0x27 } }
+ 
 extern EFI_GUID gEfiHiiPlatformSetupFormsetGuid;
 extern EFI_GUID gEfiHiiDriverHealthFormsetGuid;
 extern EFI_GUID gEfiHiiUserCredentialFormsetGuid;
+extern EFI_GUID gEfiHiiResetStyleFor= msetGuid;
 
 #endif
diff --git a/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h b/MdePkg= /Include/Uefi/UefiInternalFormRepresentation.h
index 4a1346a..40fcdb7 100644
--- a/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h
+++ b/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h
@@ -825,6 +825,7 @@ typedef struct _EFI_IFR_QUESTION_HEADER {
 #define EFI_IFR_FLAG_READ_ONLY      &n= bsp;   0x01
 #define EFI_IFR_FLAG_CALLBACK      &nb= sp;    0x04
 #define EFI_IFR_FLAG_RESET_REQUIRED     0x10
+#define EFI_IFR_FLAG_REST_STYLE      &n= bsp;  0x20
 #define EFI_IFR_FLAG_RECONNECT_REQUIRED 0x40
 #define EFI_IFR_FLAG_OPTIONS_ONLY      = ; 0x80
 
--
2.9.0.windows.1


Please consider the environment before printing this email.

The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI).  This communication is intended to b= e read only by the individual or entity to whom it is addressed or by their= designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of= this message, in any form, is strictly prohibited.  Please promptly n= otify the sender by reply e-mail or by telephone at 770-246-8600, and then = delete or destroy all copies of the transmission.

 

P Please consider the environment before printing this email

The information contained in this message may be confidential and propr= ietary to American Megatrends (AMI). This communication is intended to be r= ead only by the individual or entity to whom it is addressed or by their de= signee. If the reader of this message is not the intended recipient, you are on notice that any distribution of= this message, in any form, is strictly prohibited. Please promptly notify = the sender by reply e-mail or by telephone at 770-246-8600, and then delete= or destroy all copies of the transmission.

 

P P= lease consider the environment before printing this email

The information contained in this message may be confidential and propr= ietary to American Megatrends (AMI). This communication is intended to be = read only by the individual or entity to whom it is addressed or by their d= esignee. If the reader of this message is not the intended recipient, you a= re on notice that any distribution of this message, in any form, is strictl= y prohibited. Please promptly notify the sender by reply e-mail or by tele= phone at 770-246-8600, and then delete or destroy all copies of the transmi= ssion.

--_000_6BD875C24FFE2A4E8D6EFC142C67836F03FF6566C3atlms1usmegat_--