From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atlmailgw2.ami.com (atlmailgw2.ami.com [63.147.10.42]) by mx.groups.io with SMTP id smtpd.web12.3427.1588796073098710136 for ; Wed, 06 May 2020 13:14:33 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: ami.com, ip: 63.147.10.42, mailfrom: oleksiyy@ami.com) X-AuditID: ac10606f-049ff70000001b62-71-5eb31aa68893 Received: from atlms2.us.megatrends.com (atlms2.us.megatrends.com [172.16.96.152]) (using TLS with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client did not present a certificate) by atlmailgw2.ami.com (Symantec Messaging Gateway) with SMTP id 9A.39.07010.6AA13BE5; Wed, 6 May 2020 16:14:31 -0400 (EDT) Received: from ATLMS1.us.megatrends.com ([fe80::8c55:daf0:ef05:5605]) by atlms2.us.megatrends.com ([fe80::29dc:a91e:ea0c:cdeb%12]) with mapi id 14.03.0468.000; Wed, 6 May 2020 16:13:10 -0400 From: "Oleksiy Yakovlev" To: Bret Barkelew , "devel@edk2.groups.io" CC: "liming.gao@intel.com" , "Kinney, Michael D" , Felix Polyudov Subject: Re: [EXTERNAL] [edk2-devel] [PATCH 1/4] MdePkg: Add new CPER Notification types Thread-Topic: [EXTERNAL] [edk2-devel] [PATCH 1/4] MdePkg: Add new CPER Notification types Thread-Index: AQHWD3JaoEbDtEjYakS83e2mKaRVc6hzSqOAgChZx2A= Date: Wed, 6 May 2020 20:13:09 +0000 Message-ID: <6BD875C24FFE2A4E8D6EFC142C67836F03FFFF98F5@atlms1.us.megatrends.com> References: <20200410195803.19972-1-oleksiyy@ami.com>,<20200410195803.19972-2-oleksiyy@ami.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.97.158] MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCKsWRmVeSWpSXmKPExsWyRiBhhu5yqc1xBvuOsFi827KQzaJ9wmw2 ixX3NrBbdHT8Y3Jg8dj+/QKjx+I9L5k8Wnf8ZQ9gjmpgtEnMy8svSSxJVUhJLU62VQooyixL TK5UUshMsVUyVFIoyElMTs1NzSuxVUosKEjNS1Gy41LAADZAZZl5Cql5yfkpmXnptkqewf66 FhamlrqGSnYhGakKmXlp+UW5iSWZ+XkKyfl5JUDVqSlAUYWEbs6MtR/vshZc62es+Dz/BUsD 4976LkZODgkBE4lt3f1sXYxcHEICu5gkZp+aygThHGKU6Ft/kh2kik1AU+LNuRcsILaIQILE 78lXWUCKmAXaGCXebN7KBpIQFoiS6PjdyAxRFC3xpHM5VIOVxNqG92A2i4CKxIazXUD1HBy8 AoESe3YLQSzbxCjRsGEiWC+nQKzE1unNYPWMAmIS30+tYQKxmQXEJW49mc8EcbaAxJI955kh bFGJl4//sULYihJPP7xgh6jPl/j/8yKYzSsgKHFy5hOWCYwis5CMmoWkbBaSMoi4jsSC3Z/Y IGxtiWULXzPD2GcOPGZCFl/AyL6KUSixJCc3MTMnvdxILzE3Uy85P3cTIyTJ5O9g/PjR/BAj EwcjMFQ5mJVEeHl+bIwT4k1JrKxKLcqPLyrNSS0+xOgEDKCJzFLcoLgDJoZ4YwMDKVEYx9DE zMTcyNzQ0sTc2FhJnHfS2jVxQgLpwESVnZpakFoEM4SJg1OqgbEtQs01du4EHaOAqbk2JkaV RV4ejVWzCw4u+tepFSasfebU0p+1N851vp4pIZjt3dp7PH3+865X/G3RW2OOcj+sqRN8GLN0 P0fG85aX/xw0Oa4cNrjFVpQhxnlFWmzbsj+VpSKmXAlpt9pqdS5wBhw//qasXqzlt/zJX/u4 /8dfyDL/0be2XImlOCPRUIu5qDgRAIHDlLlHAwAA Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_6BD875C24FFE2A4E8D6EFC142C67836F03FFFF98F5atlms1usmegat_" --_000_6BD875C24FFE2A4E8D6EFC142C67836F03FFFF98F5atlms1usmegat_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Bret. Sorry for late reply. I was waiting for more comments from others. Yes all previous notification types are defined in Include/Guid/Cper.h You are right about the typos. But this were just copy/paste from previous= notification types definitions from Cper.h - I am not a native English spe= aker and did not mentioned this. Actually all of notification types defined with TYEP instead of TYPE. I can fix TYEP in 3 definitions added by me, but what should I do with all= the rest? Regards, Oleksiy. From: Bret Barkelew [mailto:Bret.Barkelew@microsoft.com] Sent: Friday, April 10, 2020 7:54 PM To: devel@edk2.groups.io; Oleksiy Yakovlev Cc: liming.gao@intel.com; Kinney, Michael D; Felix Polyudov; Oleksiy Yakov= lev Subject: RE: [EXTERNAL] [edk2-devel] [PATCH 1/4] MdePkg: Add new CPER Noti= fication types > +#define EFI_EVENT_NOTIFICATION_TYEP_DMAR_SEA \ Multiple typos in these lines. > + ## Include/Guid/Cper.h Are all of these actually in the Cper.h file? - Bret From: Oleksiy Yakovlev via groups.io Sent: Friday, April 10, 2020 12:59 PM To: devel@edk2.groups.io Cc: liming.gao@intel.com; Kinney, Michael D; Felixp@ami.com; o= leksiyy@ami.com Subject: [EXTERNAL] [edk2-devel] [PATCH 1/4] MdePkg: Add new CPER Notifica= tion types Add SEA, SEI, and PEI CPER Notification types defined in UEFI 2.8 errata a= . (UEFI 2.8 errata a, mantis 2026) Signed-off-by: Oleksiy Yakovlev --- MdePkg/Include/Guid/Cper.h | 15 +++++++++++++++ MdePkg/MdePkg.dec | 9 +++++++++ 2 files changed, 24 insertions(+) diff --git a/MdePkg/Include/Guid/Cper.h b/MdePkg/Include/Guid/Cper.h index 0cacd30..b401c14 100644 --- a/MdePkg/Include/Guid/Cper.h +++ b/MdePkg/Include/Guid/Cper.h @@ -95,6 +95,18 @@ typedef struct { { \ 0x667DD791, 0xC6B3, 0x4c27, { 0x8A, 0x6B, 0x0F, 0x8E, 0x72, 0x2D, 0xE= B, 0x41 } \ } +#define EFI_EVENT_NOTIFICATION_TYEP_DMAR_SEA \ + { \ + 0x9A78788A, 0xBBE8, 0x11E4, { 0x80, 0x9E, 0x67, 0x61, 0x1E, 0x5D, 0x4= 6, 0xB0 } \ + } +#define EFI_EVENT_NOTIFICATION_TYEP_DMAR_SEI \ + { \ + 0x5C284C81, 0xB0AE, 0x4E87, { 0xA3, 0x22, 0xB0, 0x4C, 0x85, 0x62, 0x4= 3, 0x23 } \ + } +#define EFI_EVENT_NOTIFICATION_TYEP_DMAR_PEI \ + { \ + 0x09A9D5AC, 0x5204, 0x4214, { 0x96, 0xE5, 0x94, 0x99, 0x2E, 0x75, 0x2= B, 0xCD } \ + } ///@} /// @@ -1207,6 +1219,9 @@ extern EFI_GUID gEfiEventNotificationTypeInitGuid; extern EFI_GUID gEfiEventNotificationTypeNmiGuid; extern EFI_GUID gEfiEventNotificationTypeBootGuid; extern EFI_GUID gEfiEventNotificationTypeDmarGuid; +extern EFI_GUID gEfiEventNotificationTypeSeaGuid; +extern EFI_GUID gEfiEventNotificationTypeSeiGuid; +extern EFI_GUID gEfiEventNotificationTypePeiGuid; extern EFI_GUID gEfiProcessorGenericErrorSectionGuid; extern EFI_GUID gEfiProcessorSpecificErrorSectionGuid; diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index ac1f533..99e75f7 100644 --- a/MdePkg/MdePkg.dec +++ b/MdePkg/MdePkg.dec @@ -434,6 +434,15 @@ gEfiEventNotificationTypeDmarGuid =3D { 0x667DD791, 0xC6B3, 0x4c27, { = 0x8A, 0x6B, 0x0F, 0x8E, 0x72, 0x2D, 0xEB, 0x41 }} ## Include/Guid/Cper.h + gEfiEventNotificationTypeSeaGuid =3D { 0x9A78788A, 0xBBE8, 0x11E4, { = 0x80, 0x9E, 0x67, 0x61, 0x1E, 0x5D, 0x46, 0xB0 }} + + ## Include/Guid/Cper.h + gEfiEventNotificationTypeSeiGuid =3D { 0x5C284C81, 0xB0AE, 0x4E87, { = 0xA3, 0x22, 0xB0, 0x4C, 0x85, 0x62, 0x43, 0x23 }} + + ## Include/Guid/Cper.h + gEfiEventNotificationTypePeiGuid =3D { 0x09A9D5AC, 0x5204, 0x4214, { = 0x96, 0xE5, 0x94, 0x99, 0x2E, 0x75, 0x2B, 0xCD }} + + ## Include/Guid/Cper.h gEfiProcessorGenericErrorSectionGuid =3D { 0x9876ccad, 0x47b4, 0x4bdb,= { 0xb6, 0x5e, 0x16, 0xf1, 0x93, 0xc4, 0xf3, 0xdb }} ## Include/Guid/Cper.h -- 2.9.0.windows.1 Please consider the environment before printing this email. The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be rea= d only by the individual or entity to whom it is addressed or by their desi= gnee. If the reader of this message is not the intended recipient, you are = on notice that any distribution of this message, in any form, is strictly p= rohibited. Please promptly notify the sender by reply e-mail or by telepho= ne at 770-246-8600, and then delete or destroy all copies of the transmissi= on. Please consider the environment before printing this email. The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be rea= d only by the individual or entity to whom it is addressed or by their desi= gnee. If the reader of this message is not the intended recipient, you are = on notice that any distribution of this message, in any form, is strictly p= rohibited. Please promptly notify the sender by reply e-mail or by telepho= ne at 770-246-8600, and then delete or destroy all copies of the transmissi= on. --_000_6BD875C24FFE2A4E8D6EFC142C67836F03FFFF98F5atlms1usmegat_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Bret.

 

Sorry for late reply.= I was waiting for more comments from others.

 

Yes all previous noti= fication types are defined in Include/Guid/Cper.h

 

You are right about t= he typos. But this were just copy/paste from previous notification types de= finitions from Cper.h – I am not a native English speaker and did not= mentioned this.

Actually all of notif= ication types defined with TYEP instead of TYPE.

I can fix TYEP in 3 d= efinitions added by me, but what should I do with all the rest?<= /span>

 

Regards, Oleksiy.

 

 

From: Bret Ba= rkelew [mailto:Bret.Barkelew@microsoft.com]
Sent: Friday, April 10, 2020 7:54 PM
To: devel@edk2.groups.io; Oleksiy Yakovlev
Cc: liming.gao@intel.com; Kinney, Michael D; Felix Polyudov; Oleksi= y Yakovlev
Subject: RE: [EXTERNAL] [edk2-devel] [PATCH 1/4] MdePkg: Add new CP= ER Notification types

 

> +#define EFI_EVENT_NOTIFICATION_TYEP_DMAR_= SEA \

Multiple typos in these lines.

 

> +  ## Include/Guid/Cper.h
Are all of these actually in the Cper.h file?

 

- Bret

 

From: Oleksiy Yakovlev via groups.io
Sent: Friday, April 10, 2020 12:59 PM
To: devel@edk2.groups.io
Cc: liming.gao@intel.com; Kinney, Michael D; Felixp@ami.com; oleksiyy@ami.com
Subject: [EXTERNAL] [edk2-devel] [PATCH 1/4] MdePkg: Add new CPER N= otification types

 

Add SEA, SEI, and PE= I CPER Notification types defined in UEFI 2.8 errata a.
(UEFI 2.8 errata a, mantis 2026)

Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
---
 MdePkg/Include/Guid/Cper.h | 15 +++++++&= #43;+++++++
 MdePkg/MdePkg.dec        &nb= sp; |  9 +++++++++
 2 files changed, 24 insertions(+)

diff --git a/MdePkg/Include/Guid/Cper.h b/MdePkg/Include/Guid/Cper.h
index 0cacd30..b401c14 100644
--- a/MdePkg/Include/Guid/Cper.h
+++ b/MdePkg/Include/Guid/Cper.h
@@ -95,6 +95,18 @@ typedef struct {
   { \
     0x667DD791, 0xC6B3, 0x4c27, { 0x8A, 0x6B, 0x0F, 0= x8E, 0x72, 0x2D, 0xEB, 0x41 } \
   }
+#define EFI_EVENT_NOTIFICATION_TYEP_DMAR_SEA \
+  { \
+    0x9A78788A, 0xBBE8, 0x11E4, { 0x80, 0x9E, 0x67, 0x= 61, 0x1E, 0x5D, 0x46, 0xB0 } \
+  }
+#define EFI_EVENT_NOTIFICATION_TYEP_DMAR_SEI \
+  { \
+    0x5C284C81, 0xB0AE, 0x4E87, { 0xA3, 0x22, 0xB0, 0x= 4C, 0x85, 0x62, 0x43, 0x23 } \
+  }
+#define EFI_EVENT_NOTIFICATION_TYEP_DMAR_PEI \
+  { \
+    0x09A9D5AC, 0x5204, 0x4214, { 0x96, 0xE5, 0x94, 0x= 99, 0x2E, 0x75, 0x2B, 0xCD } \
+  }
 ///@}
 
 ///
@@ -1207,6 +1219,9 @@ extern EFI_GUID gEfiEventNotificationTypeInitGui= d;
 extern EFI_GUID gEfiEventNotificationTypeNmiGuid;
 extern EFI_GUID gEfiEventNotificationTypeBootGuid;
 extern EFI_GUID gEfiEventNotificationTypeDmarGuid;
+extern EFI_GUID gEfiEventNotificationTypeSeaGuid;
+extern EFI_GUID gEfiEventNotificationTypeSeiGuid;
+extern EFI_GUID gEfiEventNotificationTypePeiGuid;
 
 extern EFI_GUID gEfiProcessorGenericErrorSectionGuid;
 extern EFI_GUID gEfiProcessorSpecificErrorSectionGuid;
diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
index ac1f533..99e75f7 100644
--- a/MdePkg/MdePkg.dec
+++ b/MdePkg/MdePkg.dec
@@ -434,6 +434,15 @@
   gEfiEventNotificationTypeDmarGuid  =3D { 0x667DD791, 0xC= 6B3, 0x4c27, { 0x8A, 0x6B, 0x0F, 0x8E, 0x72, 0x2D, 0xEB, 0x41 }}
 
   ## Include/Guid/Cper.h
+  gEfiEventNotificationTypeSeaGuid   =3D { 0x9A78788A,= 0xBBE8, 0x11E4, { 0x80, 0x9E, 0x67, 0x61, 0x1E, 0x5D, 0x46, 0xB0 }}
+ 
+  ## Include/Guid/Cper.h
+  gEfiEventNotificationTypeSeiGuid   =3D { 0x5C284C81,= 0xB0AE, 0x4E87, { 0xA3, 0x22, 0xB0, 0x4C, 0x85, 0x62, 0x43, 0x23 }}
+ 
+  ## Include/Guid/Cper.h
+  gEfiEventNotificationTypePeiGuid   =3D { 0x09A9D5AC,= 0x5204, 0x4214, { 0x96, 0xE5, 0x94, 0x99, 0x2E, 0x75, 0x2B, 0xCD }}
+
+  ## Include/Guid/Cper.h
   gEfiProcessorGenericErrorSectionGuid  =3D { 0x9876ccad, = 0x47b4, 0x4bdb, { 0xb6, 0x5e, 0x16, 0xf1, 0x93, 0xc4, 0xf3, 0xdb }}
 
   ## Include/Guid/Cper.h
--
2.9.0.windows.1


Please consider the environment before printing this email.

The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI).  This communication is intended to b= e read only by the individual or entity to whom it is addressed or by their= designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of= this message, in any form, is strictly prohibited.  Please promptly n= otify the sender by reply e-mail or by telephone at 770-246-8600, and then = delete or destroy all copies of the transmission.

 

P P= lease consider the environment before printing this email

The information contained in this message may be confidential and propr= ietary to American Megatrends (AMI). This communication is intended to be = read only by the individual or entity to whom it is addressed or by their d= esignee. If the reader of this message is not the intended recipient, you a= re on notice that any distribution of this message, in any form, is strictl= y prohibited. Please promptly notify the sender by reply e-mail or by tele= phone at 770-246-8600, and then delete or destroy all copies of the transmi= ssion.

--_000_6BD875C24FFE2A4E8D6EFC142C67836F03FFFF98F5atlms1usmegat_--