From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atlmailgw2.ami.com (atlmailgw2.ami.com [63.147.10.42]) by mx.groups.io with SMTP id smtpd.web11.11010.1588947238737651344 for ; Fri, 08 May 2020 07:13:59 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: ami.com, ip: 63.147.10.42, mailfrom: oleksiyy@ami.com) X-AuditID: ac10606f-05fff70000001b62-51-5eb56924140c Received: from atlms2.us.megatrends.com (atlms2.us.megatrends.com [172.16.96.152]) (using TLS with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client did not present a certificate) by atlmailgw2.ami.com (Symantec Messaging Gateway) with SMTP id D3.5C.07010.42965BE5; Fri, 8 May 2020 10:13:56 -0400 (EDT) Received: from ATLMS1.us.megatrends.com ([fe80::8c55:daf0:ef05:5605]) by atlms2.us.megatrends.com ([fe80::29dc:a91e:ea0c:cdeb%12]) with mapi id 14.03.0468.000; Fri, 8 May 2020 10:12:30 -0400 From: "Oleksiy Yakovlev" To: "Liu, Zhiguang" , "devel@edk2.groups.io" CC: "Feng, Bob C" , "Gao, Liming" , "Kinney, Michael D" , Felix Polyudov Subject: Re: [edk2-devel] [PATCH v3 3/7] MdePkg: REST style formset Thread-Topic: [edk2-devel] [PATCH v3 3/7] MdePkg: REST style formset Thread-Index: AQHWJOffn2LCtl1ajU6wkOdgQM8xbaieOlpA Date: Fri, 8 May 2020 14:12:29 +0000 Message-ID: <6BD875C24FFE2A4E8D6EFC142C67836F03FFFF9BE0@atlms1.us.megatrends.com> References: <20200507191358.74904-1-oleksiyy@ami.com> <20200507191358.74904-4-oleksiyy@ami.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.97.158] MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDKsWRmVeSWpSXmKPExsWyRiBhhq5K5tY4g9evDS1+HZ3HZtE+YTab xYp7G9gtOjr+MVnsmv+EyYHVY/v3C4wei/e8ZApgimpgtEnMy8svSSxJVUhJLU62VQooyixL TK5UUshMsVUyVFIoyElMTs1NzSuxVUosKEjNS1Gy41LAADZAZZl5Cql5yfkpmXnptkqewf66 FhamlrqGSnYhGakKmXlp+UW5iSWZ+XkKyfl5JUDVqSlAUYWEbs6Mvd0/mQs2KFd8mf6DpYHx u2wXIyeHhICJRMfeT6xdjFwcQgK7mCTWnTzNDuEcYpTYe20KI0gVm4CmxJtzL1hAbBGBWImb N/qYQYqYBZYySpw4epEJJCEs4Cyx7dUJdogiF4mWcxOYIGwjiWPvrrCB2CwCKhL3p79iBbF5 BQIl3syfyAaxbQujxOu7a5hBEpxAG+4+egjWwCggJvH91BqwQcwC4hK3nsxngrhbQGLJnvPM ELaoxMvH/1ghbEWJpx9esEPU60gs2P2JDcLWlli28DUzxGJBiZMzn7BMYBSdhWTsLCQts5C0 zELSsoCRZRWjUGJJTm5iZk56uZFeYm6mXnJ+7iZGSNLI38H48aP5IUYmDkZg8HEwK4nwTqzY EifEm5JYWZValB9fVJqTWnyI0QkYEhOZpbhBcQSM9HhjAwMpURjH0MTMxNzI3NDSxNzYWEmc d9LaNXFCAunAxJOdmlqQWgQzhImDU6qB0c19m0H40vDFtorfl8kEuksxa1ZW3fvu18eswPnu SRXfu0XXH/9n9DRQevKi6yjHM4drqYrLXtQ3izp950pjtI6qrU88t6tOddmR+Vo/RIzPVHIu KnY2Fdl6+Kg817RddQvyP66JdeFn/ZOdW6J0LOR9ZU9FpJFO0pkZd1iVpyZu1JDM8nBXYinO SDTUYi4qTgQA9Uds9S8DAAA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Zhiguang. Commit messages are formatted correctly in patches when I view them in edi= tor (notepad ++). Looks like sending them via emails resulted in eliminatin= g all EOL before dot (making single sentences inline). I am using "git send-email --suppress-from --to ..." command. Is there any= key to avoid such behavior? Regards, Oleksiy. -----Original Message----- From: Liu, Zhiguang [mailto:zhiguang.liu@intel.com] Sent: Thursday, May 07, 2020 11:24 PM To: devel@edk2.groups.io; Oleksiy Yakovlev Cc: Feng, Bob C; Gao, Liming; Kinney, Michael D; Felix Polyudov Subject: RE: [edk2-devel] [PATCH v3 3/7] MdePkg: REST style formset Hi Oleksiy, Some lines in commit message is too long , from https://github.com/tianoco= re/tianocore.github.io/wiki/Commit-Message-Format, line length should be le= ss than 76 characters when possible. Other parts are fine to me. Thanks Zhiguang Reviewed-by: Zhiguang Liu -----Original Message----- From: devel@edk2.groups.io On Behalf Of Oleksiy Yak= ovlev Sent: Friday, May 8, 2020 3:14 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming = ; Kinney, Michael D ; Felixp@ami.com; oleksiyy@= ami.com Subject: [edk2-devel] [PATCH v3 3/7] MdePkg: REST style formset New ClassGuid EFI_HII_REST_STYLE_FORMSET_GUID is defined. A formset with this class GUID indicates all the questions in the formset support REST style operation and can be exposed to a REST service point. In question level, a new flag EFI_IFR_FLAG_REST_STYLE is defined. An Opcode with this flag indicates this question support REST style operat= ion and can be exposed to a REST service point. (UEFI 2.8 mantis 1853) Signed-off-by: Oleksiy Yakovlev --- MdePkg/Include/Guid/HiiPlatformSetupFormset.h | 4 ++++ MdePkg/Include/Uefi/UefiInternalFormRepresentation.h | 1 + 2 files changed, 5 insertions(+) diff --git a/MdePkg/Include/Guid/HiiPlatformSetupFormset.h b/MdePkg/Includ= e/Guid/HiiPlatformSetupFormset.h index 540483d..a6ba55b 100644 --- a/MdePkg/Include/Guid/HiiPlatformSetupFormset.h +++ b/MdePkg/Include/Guid/HiiPlatformSetupFormset.h @@ -22,8 +22,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #define EFI_HII_USER_CREDENTIAL_FORMSET_GUID \ { 0x337f4407, 0x5aee, 0x4b83, { 0xb2, 0xa7, 0x4e, 0xad, 0xca, 0x30, 0x8= 8, 0xcd } } +#define EFI_HII_REST_STYLE_FORMSET_GUID \ + { 0x790217bd, 0xbecf, 0x485b, { 0x91, 0x70, 0x5f, 0xf7, 0x11, 0x31, 0x8= b, 0x27 } } + extern EFI_GUID gEfiHiiPlatformSetupFormsetGuid; extern EFI_GUID gEfiHiiDriverHealthFormsetGuid; extern EFI_GUID gEfiHiiUserCredentialFormsetGuid; +extern EFI_GUID gEfiHiiRestStyleFormsetGuid; #endif diff --git a/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h b/MdePkg= /Include/Uefi/UefiInternalFormRepresentation.h index 4a1346a..40fcdb7 100644 --- a/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h +++ b/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h @@ -825,6 +825,7 @@ typedef struct _EFI_IFR_QUESTION_HEADER { #define EFI_IFR_FLAG_READ_ONLY 0x01 #define EFI_IFR_FLAG_CALLBACK 0x04 #define EFI_IFR_FLAG_RESET_REQUIRED 0x10 +#define EFI_IFR_FLAG_REST_STYLE 0x20 #define EFI_IFR_FLAG_RECONNECT_REQUIRED 0x40 #define EFI_IFR_FLAG_OPTIONS_ONLY 0x80 -- 2.9.0.windows.1 Please consider the environment before printing this email. The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be rea= d only by the individual or entity to whom it is addressed or by their desi= gnee. If the reader of this message is not the intended recipient, you are = on notice that any distribution of this message, in any form, is strictly p= rohibited. Please promptly notify the sender by reply e-mail or by telepho= ne at 770-246-8600, and then delete or destroy all copies of the transmissi= on. Please consider the environment before printing this email. The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be rea= d only by the individual or entity to whom it is addressed or by their desi= gnee. If the reader of this message is not the intended recipient, you are = on notice that any distribution of this message, in any form, is strictly p= rohibited. Please promptly notify the sender by reply e-mail or by telepho= ne at 770-246-8600, and then delete or destroy all copies of the transmissi= on.