From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atlmailgw1.ami.com (atlmailgw1.ami.com [63.147.10.40]) by mx.groups.io with SMTP id smtpd.web12.12875.1588951853896064084 for ; Fri, 08 May 2020 08:30:54 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: ami.com, ip: 63.147.10.40, mailfrom: oleksiyy@ami.com) X-AuditID: ac1060b2-0e1ff700000018d4-43-5eb57b2c9a2f Received: from atlms2.us.megatrends.com (atlms2.us.megatrends.com [172.16.96.152]) (using TLS with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client did not present a certificate) by atlmailgw1.ami.com (Symantec Messaging Gateway) with SMTP id D8.4D.06356.C2B75BE5; Fri, 8 May 2020 11:30:53 -0400 (EDT) Received: from ATLMS1.us.megatrends.com ([fe80::8c55:daf0:ef05:5605]) by atlms2.us.megatrends.com ([fe80::29dc:a91e:ea0c:cdeb%12]) with mapi id 14.03.0468.000; Fri, 8 May 2020 11:29:25 -0400 From: "Oleksiy Yakovlev" To: "Liu, Zhiguang" , "devel@edk2.groups.io" CC: "Gao, Liming" , "Kinney, Michael D" , Felix Polyudov Subject: Re: [edk2-devel] [PATCH v2 3/4] MdePkg: Add EFI_PROPERTIES_TABLE Thread-Topic: [edk2-devel] [PATCH v2 3/4] MdePkg: Add EFI_PROPERTIES_TABLE Thread-Index: AQHWJKaRoJZD3dmFq0mUYuXq991Ghqid9+mAgABT6fA= Date: Fri, 8 May 2020 15:29:24 +0000 Message-ID: <6BD875C24FFE2A4E8D6EFC142C67836F03FFFF9C25@atlms1.us.megatrends.com> References: <20200507193443.76728-1-oleksiyy@ami.com> <20200507193443.76728-4-oleksiyy@ami.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.97.158] MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCKsWRmVeSWpSXmKPExsWyRiBhhq5u9dY4g3+1Fu0TZrNZrLi3gd2i o+Mfk8Wu+U+YHFg8tn+/wOixeM9LpgCmqAZGm8S8vPySxJJUhZTU4mRbpYCizLLE5EolhcwU WyVDJYWCnMTk1NzUvBJbpcSCgtS8FCU7LgUMYANUlpmnkJqXnJ+SmZduq+QZ7K9rYWFqqWuo ZBeSkaqQmZeWX5SbWJKZn6eQnJ9XAlSdmgIUVUjo5syY+Oo4e8EP/YqZk1ayNzB+V+1i5OCQ EDCRON0e3MXIxSEksItJYkdnIyuEc4hR4uafn2xdjJwcbAKaEm/OvWABsUUEYiVu3uhjBrGZ BWolNlzfzg5iCwt4Skw8+5YVosZLYvL8pewQtpVE37V/YPUsAioSixYcBovzCgRKtM1eyAax bAujxKR9bWALOIEWnP92HKyBUUBM4vupNUwQy8Qlbj2ZD2ZLCAhILNlznhnCFpV4+fgfK4St KPH0wwt2iHodiQW7P7FB2NoSyxa+ZoZYLChxcuYTlgmMorOQjJ2FpGUWkpZZSFoWMLKsYhRK LMnJTczMSS831EvMzdRLzs/dxAhJEpt2MLZcND/EyMTBCAw9DmYlEd6JFVvihHhTEiurUovy 44tKc1KLDzE6AUNiIrMUNyiGgFEeb2xgICUK4xiamJmYG5kbWpqYGxsrifNOXrsmTkggHZh0 slNTC1KLYIYwcXBKNTAavS26Xv75pnbw8fNJbw5tm21weGXDw95lU76sdahRyAuyWjG9J+jK Rs5Dh+ZyM/5OOrnxyUQjlZM1cZu2SJeZvpeS+B62hjvxy+pPxhVS2lueCAm039gs1rD6W/Yq vtu7vjTN33z3eoN0kFj1NZcdlku5736xmKQm3PysUL3p3O9WVfF3xgvilViKMxINtZiLihMB spCl/icDAAA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Zhiguang. Is this about MdePkg.dec or about new added file RtPropertiesTable.h? Regards, Oleksiy. -----Original Message----- From: Liu, Zhiguang [mailto:zhiguang.liu@intel.com] Sent: Friday, May 08, 2020 2:08 AM To: devel@edk2.groups.io; Oleksiy Yakovlev Cc: Gao, Liming; Kinney, Michael D; Felix Polyudov Subject: RE: [edk2-devel] [PATCH v2 3/4] MdePkg: Add EFI_PROPERTIES_TABLE Hi Oleksiy, This patch is not correct and can't be applied to master branch. Can you confirm? The line number seems not consistent. Thanks Zhiguang > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Oleksiy > Yakovlev > Sent: Friday, May 8, 2020 3:35 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D > ; Felixp@ami.com; oleksiyy@ami.com > Subject: [edk2-devel] [PATCH v2 3/4] MdePkg: Add EFI_PROPERTIES_TABLE > > Define Guid & data structure for EFI_RT_PROPERTIES_TABLE, designed to be > published by a > platform if it no longer supports all EFI runtime services once > ExitBootServices() > has been called by the OS. > (UEFI 2.8 errata a, mantis 2049) > > Signed-off-by: Oleksiy Yakovlev > --- > MdePkg/Include/Guid/RtPropertiesTable.h | 68 > +++++++++++++++++++++++++++++++ > MdePkg/MdePkg.dec | 6 +++ > 2 files changed, 74 insertions(+) > create mode 100644 MdePkg/Include/Guid/RtPropertiesTable.h > > diff --git a/MdePkg/Include/Guid/RtPropertiesTable.h > b/MdePkg/Include/Guid/RtPropertiesTable.h > new file mode 100644 > index 0000000..a5b6c14 > --- /dev/null > +++ b/MdePkg/Include/Guid/RtPropertiesTable.h > @@ -0,0 +1,71 @@ > +/** @file > +Guid & data structure for EFI_RT_PROPERTIES_TABLE, designed to be > published by a > +platform if it no longer supports all EFI runtime services once > ExitBootServices() > +has been called by the OS. > + > + > +Copyright (c) 2020, American Megatrends International LLC. All rights > reserved.
> +SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#ifndef _RT_PROPERTIES_TABLE_GUID_H__ > +#define _RT_PROPERTIES_TABLE_GUID_H__ > + > +// > +// Table, defined here, should be published by a platform if it no long= er > supports all EFI runtime > +// services once ExitBootServices() has been called by the OS. Note tha= t this > is merely a hint > +// to the OS, which it is free to ignore, and so the platform is still = required to > provide callable > +// implementations of unsupported runtime services that simply return > EFI_UNSUPPORTED. > +// > +#define EFI_RT_PROPERTIES_TABLE_GUID \ > + { 0xeb66918a, 0x7eef, 0x402a, \ > + { 0x84, 0x2e, 0x93, 0x1d, 0x21, 0xc3, 0x8a, 0xe9 }} > + > + > + > +#pragma pack(1) > + > +typedef struct { > + /// > + /// Version of the structure, must be 0x1. > + /// > + UINT16 Version; > + > + /// > + /// Size in bytes of the entire EFI_RT_PROPERTIES_TABLE, must be 8. > + /// > + UINT16 Length; > + > + /// > + /// Bitmask of which calls are or are not supported, where a bit set = to 1 > indicates > + /// that the call is supported, and 0 indicates that it is not. > + /// > + UINT32 RuntimeServicesSupported; > +} EFI_RT_PROPERTIES_TABLE; > + > +#pragma pack() > + > +#define EFI_RT_PROPERTIES_TABLE_VERSION 0x1 > + > +#define EFI_RT_SUPPORTED_GET_TIME 0x0001 > +#define EFI_RT_SUPPORTED_SET_TIME 0x0002 > +#define EFI_RT_SUPPORTED_GET_WAKEUP_TIME 0x0004 > +#define EFI_RT_SUPPORTED_SET_WAKEUP_TIME 0x0008 > +#define EFI_RT_SUPPORTED_GET_VARIABLE 0x0010 > +#define EFI_RT_SUPPORTED_GET_NEXT_VARIABLE_NAME 0x0020 > +#define EFI_RT_SUPPORTED_SET_VARIABLE 0x0040 > +#define EFI_RT_SUPPORTED_SET_VIRTUAL_ADDRESS_MAP 0x0080 > +#define EFI_RT_SUPPORTED_CONVERT_POINTER 0x0100 > +#define EFI_RT_SUPPORTED_GET_NEXT_HIGH_MONOTONIC_COUNT > 0x0200 > +#define EFI_RT_SUPPORTED_RESET_SYSTEM 0x0400 > +#define EFI_RT_SUPPORTED_UPDATE_CAPSULE 0x0800 > +#define EFI_RT_SUPPORTED_QUERY_CAPSULE_CAPABILITIES 0x1000 > +#define EFI_RT_SUPPORTED_QUERY_VARIABLE_INFO 0x2000 > + > +extern EFI_GUID gEfiRtPropertiesTableGuid; > + > +#endif > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > index 99e75f7..d5340c5 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -655,6 +655,12 @@ > gEfiBttAbstractionGuid =3D { 0x18633bfc, 0x1735, 0x4217, { 0x= 8a, 0xc9, > 0x17, 0x23, 0x92, 0x82, 0xd3, 0xf8 }} > > # > + # GUIDs defined in UEFI2.8a > + # > + ## Include/Guid/RtPropertiesTable.h > + gEfiRtPropertiesTableGuid =3D { 0xeb66918a, 0x7eef, 0x402a, { 0x= 84, 0x2e, > 0x93, 0x1d, 0x21, 0xc3, 0x8a, 0xe9 }} > + > + # > # GUID defined in PI1.0 > # > ## Include/Guid/AprioriFileName.h > -- > 2.9.0.windows.1 > > > Please consider the environment before printing this email. > > The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intende= d > to be read only by the individual or entity to whom it is addressed or b= y their > designee. If the reader of this message is not the intended recipient, y= ou are > on notice that any distribution of this message, in any form, is strictl= y > prohibited. Please promptly notify the sender by reply e-mail or by > telephone at 770-246-8600, and then delete or destroy all copies of the > transmission. > >=20 Please consider the environment before printing this email. The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be rea= d only by the individual or entity to whom it is addressed or by their desi= gnee. If the reader of this message is not the intended recipient, you are = on notice that any distribution of this message, in any form, is strictly p= rohibited. Please promptly notify the sender by reply e-mail or by telepho= ne at 770-246-8600, and then delete or destroy all copies of the transmissi= on.