From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atlmailgw1.ami.com (atlmailgw1.ami.com [63.147.10.40]) by mx.groups.io with SMTP id smtpd.web12.6347.1589292092203771797 for ; Tue, 12 May 2020 07:01:32 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: ami.com, ip: 63.147.10.40, mailfrom: oleksiyy@ami.com) X-AuditID: ac1060b2-0e1ff700000018d4-11-5ebaac3a12b8 Received: from atlms2.us.megatrends.com (atlms2.us.megatrends.com [172.16.96.152]) (using TLS with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client did not present a certificate) by atlmailgw1.ami.com (Symantec Messaging Gateway) with SMTP id D5.72.06356.A3CAABE5; Tue, 12 May 2020 10:01:30 -0400 (EDT) Received: from ATLMS1.us.megatrends.com ([fe80::8c55:daf0:ef05:5605]) by atlms2.us.megatrends.com ([fe80::29dc:a91e:ea0c:cdeb%12]) with mapi id 14.03.0468.000; Tue, 12 May 2020 10:00:52 -0400 From: "Oleksiy Yakovlev" To: "Gao, Liming" , "devel@edk2.groups.io" CC: "Feng, Bob C" , "Kinney, Michael D" , Felix Polyudov Subject: Re: [edk2-devel] [PATCH v5 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid Thread-Topic: [edk2-devel] [PATCH v5 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid Thread-Index: AQHWJ9F4kDnT7CSVmkuH12edBZ2kPqij4m4AgACZN5A= Date: Tue, 12 May 2020 14:00:51 +0000 Message-ID: <6BD875C24FFE2A4E8D6EFC142C67836F03FFFFA032@atlms1.us.megatrends.com> References: <20200511201923.67744-1-oleksiyy@ami.com> <20200511201923.67744-2-oleksiyy@ami.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.97.158] MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKKsWRmVeSWpSXmKPExsWyRiBhhq7Vml1xBpPWWFn8OjqPzaJ9wmw2 ixX3NrBbdHT8Y3Jg8dj+/QKjx+I9L5kCmKIaGG0S8/LySxJLUhVSUouTbZUCijLLEpMrlRQy U2yVDJUUCnISk1NzU/NKbJUSCwpS81KU7LgUMIANUFlmnkJqXnJ+SmZeuq2SZ7C/roWFqaWu oZJdSEaqQmZeWn5RbmJJZn6eQnJ+XglQdWoKUFQhoZsz4/umF8wFC6UqVvQdZ2xgnCTWxcjJ ISFgIvH9+H3WLkYuDiGBXUwSE74cZoFwDjNKHJp8jh2kik1AU+LNuRcsILaIQKTEgs/H2EBs ZoFaid4HH5m7GDk4hAXCJf4c14coiZC43tTMBmFbSax6d4MZxGYRUJV4/28t2EhegUCJHYd3 QO3awijR9bqfCSTBKRArcfHANLAiRgExie+n1jBB7BKXuPVkPhPE1QISS/acZ4awRSVePv7H CmErSjz98IIdol5fYs/EUywQtrbEsoWvmSEWC0qcnPmEZQKj6CwkY2chaZmFpGUWkpYFjCyr GIUSS3JyEzNz0ssN9RJzM/WS83M3MULSxKYdjC0XzQ8xMnEwHmKU4GBWEuFtydwZJ8SbklhZ lVqUH19UmpNafIjRCRgSE5mluEExBIzyeGMDAylRGMfQxMzE3Mjc0NLE3NhYSZx38to1cUIC 6cCkk52aWpBaBDOEiYNTqoGRr+/FDg73fxVS8d+vnPQTF328c1u1/jm/0HviWdXXcrOf1996 dUqZT85vWZlml1zudI6uX5MeRF7bet7p7mS//bubPk8S53m4+3Bpx2urPfLxgYwzj/P3Xvwo 630m6ERQfOOba5/8t/2/euekUcYdDelfp509Offa2K39v4j9gdK6efObjixpUmIpzkg01GIu Kk4EAEFHIgUoAwAA Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Hi Liming. I did not understand your question about MdeModulePkg\Universal\SerialDxe = and MdeModulePkg\Bus\Pci\PciSioSerialDxe Regards, Oleksiy. -----Original Message----- From: Gao, Liming [mailto:liming.gao@intel.com] Sent: Monday, May 11, 2020 8:52 PM To: devel@edk2.groups.io; Oleksiy Yakovlev Cc: Feng, Bob C; Kinney, Michael D; Felix Polyudov Subject: RE: [edk2-devel] [PATCH v5 1/7] MdePkg: Extend SERIAL_IO with Dev= iceTypeGuid Oleksiy: Seemly, this patch doesn't response to my comment. Is there the comments= to be added for new field DeviceTypeGuid? Can its value be NULL? And, are = MdeModulePkg\Universal\SerialDxe and MdeModulePkg\Bus\Pci\PciSioSerialDxe r= equired to be updated together? Thanks Liming -----Original Message----- From: devel@edk2.groups.io On Behalf Of Oleksiy Yak= ovlev Sent: 2020=1B$BG/=1B(B5=1B$B7n=1B(B12=1B$BF|=1B(B 4:19 To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming = ; Kinney, Michael D ; Felixp@ami.com; oleksiyy@= ami.com Subject: [edk2-devel] [PATCH v5 1/7] MdePkg: Extend SERIAL_IO with DeviceT= ypeGuid EFI_SERIAL_IO_PROTOCOL_REVISION incremented to 0x00010001. CONST EFI_GUID *DeviceTypeGuid field added to the protocol structure. UEFI 2.8 mantis 1832. Signed-off-by: Oleksiy Yakovlev Reviewed-by: Liming Gao --- MdePkg/Include/Protocol/SerialIo.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/Protocol/SerialIo.h b/MdePkg/Include/Protocol/= SerialIo.h index 51eaa53..b2398c2 100644 --- a/MdePkg/Include/Protocol/SerialIo.h +++ b/MdePkg/Include/Protocol/SerialIo.h @@ -262,7 +262,7 @@ typedef struct { UINT32 StopBits; } EFI_SERIAL_IO_MODE; -#define EFI_SERIAL_IO_PROTOCOL_REVISION 0x00010000 +#define EFI_SERIAL_IO_PROTOCOL_REVISION 0x00010001 #define SERIAL_IO_INTERFACE_REVISION EFI_SERIAL_IO_PROTOCOL_REVISION /// @@ -287,6 +287,7 @@ struct _EFI_SERIAL_IO_PROTOCOL { /// Pointer to SERIAL_IO_MODE data. /// EFI_SERIAL_IO_MODE *Mode; + CONST EFI_GUID *DeviceTypeGuid; // Revision 1.1 }; extern EFI_GUID gEfiSerialIoProtocolGuid; -- 2.9.0.windows.1 Please consider the environment before printing this email. The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be rea= d only by the individual or entity to whom it is addressed or by their desi= gnee. If the reader of this message is not the intended recipient, you are = on notice that any distribution of this message, in any form, is strictly p= rohibited. Please promptly notify the sender by reply e-mail or by telepho= ne at 770-246-8600, and then delete or destroy all copies of the transmissi= on. Please consider the environment before printing this email. The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be rea= d only by the individual or entity to whom it is addressed or by their desi= gnee. If the reader of this message is not the intended recipient, you are = on notice that any distribution of this message, in any form, is strictly p= rohibited. Please promptly notify the sender by reply e-mail or by telepho= ne at 770-246-8600, and then delete or destroy all copies of the transmissi= on.