From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atlmailgw1.ami.com (atlmailgw1.ami.com [63.147.10.40]) by mx.groups.io with SMTP id smtpd.web12.7645.1589295691807521227 for ; Tue, 12 May 2020 08:01:31 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: ami.com, ip: 63.147.10.40, mailfrom: oleksiyy@ami.com) X-AuditID: ac1060b2-0f7ff700000018d4-d4-5ebaba4a680e Received: from atlms2.us.megatrends.com (atlms2.us.megatrends.com [172.16.96.152]) (using TLS with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client did not present a certificate) by atlmailgw1.ami.com (Symantec Messaging Gateway) with SMTP id 05.A2.06356.A4ABABE5; Tue, 12 May 2020 11:01:30 -0400 (EDT) Received: from ATLMS1.us.megatrends.com ([fe80::8c55:daf0:ef05:5605]) by atlms2.us.megatrends.com ([fe80::29dc:a91e:ea0c:cdeb%12]) with mapi id 14.03.0468.000; Tue, 12 May 2020 11:00:43 -0400 From: "Oleksiy Yakovlev" To: "Gao, Liming" , "devel@edk2.groups.io" CC: "Feng, Bob C" , "Kinney, Michael D" , Felix Polyudov Subject: Re: [edk2-devel] [PATCH v5 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid Thread-Topic: [edk2-devel] [PATCH v5 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid Thread-Index: AQHWJ9F4kDnT7CSVmkuH12edBZ2kPqij4m4AgACZN5CAAETzgP//vpqw Date: Tue, 12 May 2020 15:00:41 +0000 Message-ID: <6BD875C24FFE2A4E8D6EFC142C67836F03FFFFA083@atlms1.us.megatrends.com> References: <20200511201923.67744-1-oleksiyy@ami.com> <20200511201923.67744-2-oleksiyy@ami.com> <6BD875C24FFE2A4E8D6EFC142C67836F03FFFFA032@atlms1.us.megatrends.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.97.158] MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprEKsWRmVeSWpSXmKPExsWyRiBhhq7Xrl1xBodemFv8OjqPzaJ9wmw2 ixX3NrBbdHT8Y3Jg8dj+/QKjx+I9L5kCmKIaGG0S8/LySxJLUhVSUouTbZUCijLLEpMrlRQy U2yVDJUUCnISk1NzU/NKbJUSCwpS81KU7LgUMIANUFlmnkJqXnJ+SmZeuq2SZ7C/roWFqaWu oZJdSEaqQmZeWn5RbmJJZn6eQnJ+XglQdWoKUFQhoZsz4/yvBvaCm3oVl18cYWxgfKrWxcjB ISFgIrGkRbuLkZNDSGAXk0RviwGEfZhR4uBxXhCbTUBT4s25FywgtohApMSCz8fYQGxmgVqJ 3gcfmUHGCAuES/w5rg9REiFxvamZDcJ2k3jSc4IRxGYRUJXo+3WMGcTmFQiUWHn7I3sXIxfQ qvNMEtsXPQQr4hSIldj1dQsTiM0oICbx/dQaJohd4hK3nswHsyUEBCSW7DnPDGGLSrx8/I8V wlaUePrhBTtEvb7EnomnWCBsbYllC19DLRaUODnzCcsERtFZSMbOQtIyC0nLLCQtCxhZVjEK JZbk5CZm5qSXG+ol5mbqJefnbmKEJIhNOxhbLpofYmTiYDzEKMHBrCTC25K5M06INyWxsiq1 KD++qDQntfgQoxMwJCYyS3GDogcY3/HGBgZSojCOoYmZibmRuaGlibmxsZI47+S1a+KEBNKB 6SY7NbUgtQhmCBMHp1QDI6eBruut2XsyH7QLbE09yN0U3Wu9quhpmZDDtNrtppMXJ5x5qGs8 aw2LtN/GE1N1JRfLJU48+Jnx4BlJk8ajjxc3cvaWO+UH26uZ6Su3+pp0SL6cwHHI5/F79xmn 3818Olsz8rdqyMR1vX8031elKXzuNX6yvi+gdl7h3AXBm3b87Zqx+E2LkxJLcUaioRZzUXEi ABgdZ8slAwAA Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Hi Liming. The intention of this patch series was to add headers to MdePkg, to make i= t possible start working on features implementation. Implementing all features in all affected files through all possible modul= e was not in my intentions at all. I agreed to change DxeCapsuleLib to speed up adoption of this series. We n= eed this headers ASAP to start implementing those features in our own produ= cts. So we need headers before soft freeze. Regards, Oleksiy. -----Original Message----- From: Gao, Liming [mailto:liming.gao@intel.com] Sent: Tuesday, May 12, 2020 10:07 AM To: Oleksiy Yakovlev; devel@edk2.groups.io Cc: Feng, Bob C; Kinney, Michael D; Felix Polyudov Subject: RE: [edk2-devel] [PATCH v5 1/7] MdePkg: Extend SERIAL_IO with Dev= iceTypeGuid MdeModulePkg\Universal\SerialDxe and MdeModulePkg\Bus\Pci\PciSioSerialDxe = are two drivers to install SerialIo protocol with the original structure. P= lease see below code logic. With this patch, SERIAL_IO_INTERFACE_REVISION m= acro is updated to 1.1. But, this protocol doesn't set the value for new fi= eld DeviceTypeGuid. So, I want to confirm whether NULL DeviceTypeGuid is va= lid or not. EFI_SERIAL_IO_PROTOCOL mSerialIoTemplate =3D { SERIAL_IO_INTERFACE_REVISION, SerialReset, SerialSetAttributes, SerialSetControl, SerialGetControl, SerialWrite, SerialRead, &mSerialIoMode }; > -----Original Message----- > From: Oleksiy Yakovlev > Sent: Tuesday, May 12, 2020 10:01 PM > To: Gao, Liming ; devel@edk2.groups.io > Cc: Feng, Bob C ; Kinney, Michael D ; Felix Polyudov > Subject: RE: [edk2-devel] [PATCH v5 1/7] MdePkg: Extend SERIAL_IO with D= eviceTypeGuid > > Hi Liming. > > I did not understand your question about MdeModulePkg\Universal\SerialDx= e and MdeModulePkg\Bus\Pci\PciSioSerialDxe > > Regards, Oleksiy. > > -----Original Message----- > From: Gao, Liming [mailto:liming.gao@intel.com] > Sent: Monday, May 11, 2020 8:52 PM > To: devel@edk2.groups.io; Oleksiy Yakovlev > Cc: Feng, Bob C; Kinney, Michael D; Felix Polyudov > Subject: RE: [edk2-devel] [PATCH v5 1/7] MdePkg: Extend SERIAL_IO with D= eviceTypeGuid > > Oleksiy: > Seemly, this patch doesn't response to my comment. Is there the commen= ts to be added for new field DeviceTypeGuid? Can its > value be NULL? And, are MdeModulePkg\Universal\SerialDxe and MdeModulePk= g\Bus\Pci\PciSioSerialDxe required to be updated > together? > > Thanks > Liming > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Oleksiy Y= akovlev > Sent: 2020=1B$BG/=1B(B5=1B$B7n=1B(B12=1B$BF|=1B(B 4:19 > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming ; Kinney, Michael D ; > Felixp@ami.com; oleksiyy@ami.com > Subject: [edk2-devel] [PATCH v5 1/7] MdePkg: Extend SERIAL_IO with Devic= eTypeGuid > > EFI_SERIAL_IO_PROTOCOL_REVISION incremented to 0x00010001. > CONST EFI_GUID *DeviceTypeGuid field added to the protocol structure. > UEFI 2.8 mantis 1832. > > Signed-off-by: Oleksiy Yakovlev > > Reviewed-by: Liming Gao > --- > MdePkg/Include/Protocol/SerialIo.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/MdePkg/Include/Protocol/SerialIo.h b/MdePkg/Include/Protoco= l/SerialIo.h > index 51eaa53..b2398c2 100644 > --- a/MdePkg/Include/Protocol/SerialIo.h > +++ b/MdePkg/Include/Protocol/SerialIo.h > @@ -262,7 +262,7 @@ typedef struct { > UINT32 StopBits; > } EFI_SERIAL_IO_MODE; > > -#define EFI_SERIAL_IO_PROTOCOL_REVISION 0x00010000 > +#define EFI_SERIAL_IO_PROTOCOL_REVISION 0x00010001 > #define SERIAL_IO_INTERFACE_REVISION EFI_SERIAL_IO_PROTOCOL_REVISION > > /// > @@ -287,6 +287,7 @@ struct _EFI_SERIAL_IO_PROTOCOL { > /// Pointer to SERIAL_IO_MODE data. > /// > EFI_SERIAL_IO_MODE *Mode; > + CONST EFI_GUID *DeviceTypeGuid; // Revision 1.1 > }; > > extern EFI_GUID gEfiSerialIoProtocolGuid; > -- > 2.9.0.windows.1 > > > Please consider the environment before printing this email. > > The information contained in this message may be confidential and propri= etary to American Megatrends (AMI). This communication > is intended to be read only by the individual or entity to whom it is ad= dressed or by their designee. If the reader of this message is > not the intended recipient, you are on notice that any distribution of t= his message, in any form, is strictly prohibited. Please > promptly notify the sender by reply e-mail or by telephone at 770-246-86= 00, and then delete or destroy all copies of the transmission. > >=20 > > > Please consider the environment before printing this email. > > The information contained in this message may be confidential and propri= etary to American Megatrends (AMI). This communication > is intended to be read only by the individual or entity to whom it is ad= dressed or by their designee. If the reader of this message is > not the intended recipient, you are on notice that any distribution of t= his message, in any form, is strictly prohibited. Please > promptly notify the sender by reply e-mail or by telephone at 770-246-86= 00, and then delete or destroy all copies of the transmission. Please consider the environment before printing this email. The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be rea= d only by the individual or entity to whom it is addressed or by their desi= gnee. If the reader of this message is not the intended recipient, you are = on notice that any distribution of this message, in any form, is strictly p= rohibited. Please promptly notify the sender by reply e-mail or by telepho= ne at 770-246-8600, and then delete or destroy all copies of the transmissi= on.