From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atlmailgw2.ami.com (atlmailgw2.ami.com [63.147.10.42]) by mx.groups.io with SMTP id smtpd.web10.9545.1589301173967954332 for ; Tue, 12 May 2020 09:32:54 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: ami.com, ip: 63.147.10.42, mailfrom: oleksiyy@ami.com) X-AuditID: ac10606f-049ff70000001b62-fb-5ebacfb40f50 Received: from atlms2.us.megatrends.com (atlms2.us.megatrends.com [172.16.96.152]) (using TLS with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client did not present a certificate) by atlmailgw2.ami.com (Symantec Messaging Gateway) with SMTP id 5C.E1.07010.4BFCABE5; Tue, 12 May 2020 12:32:52 -0400 (EDT) Received: from ATLMS1.us.megatrends.com ([fe80::8c55:daf0:ef05:5605]) by atlms2.us.megatrends.com ([fe80::29dc:a91e:ea0c:cdeb%12]) with mapi id 14.03.0468.000; Tue, 12 May 2020 12:32:13 -0400 From: "Oleksiy Yakovlev" To: "Gao, Liming" , "devel@edk2.groups.io" CC: "Feng, Bob C" , "Kinney, Michael D" , Felix Polyudov Subject: Re: [edk2-devel] [PATCH v5 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid Thread-Topic: [edk2-devel] [PATCH v5 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid Thread-Index: AQHWJ9F4kDnT7CSVmkuH12edBZ2kPqij4m4AgADCX+A= Date: Tue, 12 May 2020 16:32:13 +0000 Message-ID: <6BD875C24FFE2A4E8D6EFC142C67836F03FFFFA0A5@atlms1.us.megatrends.com> References: <20200511201923.67744-1-oleksiyy@ami.com> <20200511201923.67744-2-oleksiyy@ami.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.97.158] MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKKsWRmVeSWpSXmKPExsWyRiBhhu6W87viDJqXmVj8OjqPzaJ9wmw2 ixX3NrBbdHT8Y3Jg8dj+/QKjx+I9L5kCmKIaGG0S8/LySxJLUhVSUouTbZUCijLLEpMrlRQy U2yVDJUUCnISk1NzU/NKbJUSCwpS81KU7LgUMIANUFlmnkJqXnJ+SmZeuq2SZ7C/roWFqaWu oZJdSEaqQmZeWn5RbmJJZn6eQnJ+XglQdWoKUFQhoZsz4/iTC6wFf2QqHlzZzN7AuFGii5GT Q0LAROLiuf1MXYxcHEICu5gkTnasZIdwDjNKnJ1znxmkik1AU+LNuRcsILaIQKTEgs/H2EBs ZoFaid4HH4FqODiEBcIl/hzXhyiJkLje1MwGYVtJNE56AWazCKhKfNp9G2wMr0CgxI7DSxgh dm1hlOh63c8EkuAUiJW4eGAaO4jNKCAm8f3UGiaIXeISt57MZ4K4WkBiyZ7zzBC2qMTLx/9Y IWxFiacfXrBD1OtL7Jl4igXC1pZYtvA1M8RiQYmTM5+wTGAUnYVk7CwkLbOQtMxC0rKAkWUV o1BiSU5uYmZOermRXmJupl5yfu4mRkiayN/B+PGj+SFGJg7GQ4wSHMxKIrwtmTvjhHhTEiur Uovy44tKc1KLDzE6AUNiIrMUNyiGgFEeb2xgICUK4xiamJmYG5kbWpqYGxsrifNOWrsmTkgg HZh0slNTC1KLYIYwcXBKNTBKL1lglLd+48vHszY9DLbf+Tpv3QWLy9ZH1soltrzJe5sX3dg6 +eDnFyV9G7vkXpYobvMUCt75vNPvZWfz7HuXb+2rVnjS/KsqU6XSJ3CllPoTrr1r9h7ytrl8 Zn3vOpsXtzxP+oUvVb14+It/Y0Zo//w3bqfsM7fk+7nrezBP7fys0Lxo36o6JZbijERDLeai 4kQAu4oDuygDAAA= Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Hi Liming. I made a mistake in implementation. Instead of changing EFI_SERIAL_IO_PROTOCOL_REVISION they introduced a new = definition - EFI_SERIAL_IO_PROTOCOL_REVISION1p1. This way it will be completely backward compatible and would not affect Md= eModulePkg\Universal\SerialDxe and MdeModulePkg\Bus\Pci\PciSioSerialDxe. I = used wrong ECR document. This way we will have no problems with Extend SERIAL_IO with DeviceTypeGui= d. I will resubmit patches asap. Regards, Oleksiy. -----Original Message----- From: Gao, Liming [mailto:liming.gao@intel.com] Sent: Monday, May 11, 2020 8:52 PM To: devel@edk2.groups.io; Oleksiy Yakovlev Cc: Feng, Bob C; Kinney, Michael D; Felix Polyudov Subject: RE: [edk2-devel] [PATCH v5 1/7] MdePkg: Extend SERIAL_IO with Dev= iceTypeGuid Oleksiy: Seemly, this patch doesn't response to my comment. Is there the comments= to be added for new field DeviceTypeGuid? Can its value be NULL? And, are = MdeModulePkg\Universal\SerialDxe and MdeModulePkg\Bus\Pci\PciSioSerialDxe r= equired to be updated together? Thanks Liming -----Original Message----- From: devel@edk2.groups.io On Behalf Of Oleksiy Yak= ovlev Sent: 2020=1B$BG/=1B(B5=1B$B7n=1B(B12=1B$BF|=1B(B 4:19 To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming = ; Kinney, Michael D ; Felixp@ami.com; oleksiyy@= ami.com Subject: [edk2-devel] [PATCH v5 1/7] MdePkg: Extend SERIAL_IO with DeviceT= ypeGuid EFI_SERIAL_IO_PROTOCOL_REVISION incremented to 0x00010001. CONST EFI_GUID *DeviceTypeGuid field added to the protocol structure. UEFI 2.8 mantis 1832. Signed-off-by: Oleksiy Yakovlev Reviewed-by: Liming Gao --- MdePkg/Include/Protocol/SerialIo.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/Protocol/SerialIo.h b/MdePkg/Include/Protocol/= SerialIo.h index 51eaa53..b2398c2 100644 --- a/MdePkg/Include/Protocol/SerialIo.h +++ b/MdePkg/Include/Protocol/SerialIo.h @@ -262,7 +262,7 @@ typedef struct { UINT32 StopBits; } EFI_SERIAL_IO_MODE; -#define EFI_SERIAL_IO_PROTOCOL_REVISION 0x00010000 +#define EFI_SERIAL_IO_PROTOCOL_REVISION 0x00010001 #define SERIAL_IO_INTERFACE_REVISION EFI_SERIAL_IO_PROTOCOL_REVISION /// @@ -287,6 +287,7 @@ struct _EFI_SERIAL_IO_PROTOCOL { /// Pointer to SERIAL_IO_MODE data. /// EFI_SERIAL_IO_MODE *Mode; + CONST EFI_GUID *DeviceTypeGuid; // Revision 1.1 }; extern EFI_GUID gEfiSerialIoProtocolGuid; -- 2.9.0.windows.1 Please consider the environment before printing this email. The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be rea= d only by the individual or entity to whom it is addressed or by their desi= gnee. If the reader of this message is not the intended recipient, you are = on notice that any distribution of this message, in any form, is strictly p= rohibited. Please promptly notify the sender by reply e-mail or by telepho= ne at 770-246-8600, and then delete or destroy all copies of the transmissi= on. Please consider the environment before printing this email. The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be rea= d only by the individual or entity to whom it is addressed or by their desi= gnee. If the reader of this message is not the intended recipient, you are = on notice that any distribution of this message, in any form, is strictly p= rohibited. Please promptly notify the sender by reply e-mail or by telepho= ne at 770-246-8600, and then delete or destroy all copies of the transmissi= on.