Re: [edk2-devel] [PATCH v7 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid

["Oleksiy Yakovlev" <oleksiyy@ami.com>]

There was a mistake in all previous v here.
I took it from original ECR and misted correction.
Now it is up to spec.

Regards, Oleksiy.

-----Original Message-----
From: Jiang, Guomin [mailto:guomin.jiang@intel.com]
Sent: Wednesday, May 13, 2020 11:43 PM
To: devel@edk2.groups.io; Oleksiy Yakovlev
Cc: Feng, Bob C; Gao, Liming; Kinney, Michael D; Felix Polyudov
Subject: RE: [edk2-devel] [PATCH v7 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid

Add some comments.

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oleksiy
> Yakovlev
> Sent: Thursday, May 14, 2020 3:53 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> Felixp@ami.com; oleksiyy@ami.com
> Subject: [edk2-devel] [PATCH v7 1/7] MdePkg: Extend SERIAL_IO with
> DeviceTypeGuid
>
> EFI_SERIAL_IO_PROTOCOL_REVISION incremented to 0x00010001.
> CONST EFI_GUID *DeviceTypeGuid field added to the protocol structure.
> UEFI 2.8 mantis 1832.
>
> Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
>
> Reviewed-by: Liming Gao <liming.gao@intel.com>
> ---
>  MdePkg/Include/Protocol/SerialIo.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/MdePkg/Include/Protocol/SerialIo.h
> b/MdePkg/Include/Protocol/SerialIo.h
> index 51eaa53..e2e0c61 100644
> --- a/MdePkg/Include/Protocol/SerialIo.h
> +++ b/MdePkg/Include/Protocol/SerialIo.h
> @@ -263,6 +263,7 @@ typedef struct {
>  } EFI_SERIAL_IO_MODE;
>
>  #define EFI_SERIAL_IO_PROTOCOL_REVISION    0x00010000
> +#define EFI_SERIAL_IO_PROTOCOL_REVISION1p1 0x00010001

Why add this new definition, it is not exist in patch v5 but exist in patch v6?

>  #define SERIAL_IO_INTERFACE_REVISION
> EFI_SERIAL_IO_PROTOCOL_REVISION
>
>  ///
> @@ -287,6 +288,14 @@ struct _EFI_SERIAL_IO_PROTOCOL {
>    /// Pointer to SERIAL_IO_MODE data.
>    ///
>    EFI_SERIAL_IO_MODE          *Mode;
> +  ///
> +  /// Pointer to a GUID identifying the device connected to the serial port.
> +  /// This field is NULL when the protocol is installed by the serial
> + port  /// driver and may be populated by a platform driver for a
> + serial port  /// with a known device attached. The field will remain
> + NULL if there is  /// no platform serial device identification information
> available.
> +  ///
> +  CONST EFI_GUID              *DeviceTypeGuid; // Revision 1.1
>  };
>
>  extern EFI_GUID gEfiSerialIoProtocolGuid;
> --
> 2.9.0.windows.1
>
>
> Please consider the environment before printing this email.
>
> The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI).  This communication is intended
> to be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited.  Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all copies of the
> transmission.
>
> 


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.