From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atlmailgw2.ami.com (atlmailgw2.ami.com [63.147.10.42]) by mx.groups.io with SMTP id smtpd.web11.13026.1589465857991363353 for ; Thu, 14 May 2020 07:17:38 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: ami.com, ip: 63.147.10.42, mailfrom: oleksiyy@ami.com) X-AuditID: ac10606f-05fff70000001b62-14-5ebd52ff8916 Received: from atlms2.us.megatrends.com (atlms2.us.megatrends.com [172.16.96.152]) (using TLS with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client did not present a certificate) by atlmailgw2.ami.com (Symantec Messaging Gateway) with SMTP id DE.A5.07010.FF25DBE5; Thu, 14 May 2020 10:17:36 -0400 (EDT) Received: from ATLMS1.us.megatrends.com ([fe80::8c55:daf0:ef05:5605]) by atlms2.us.megatrends.com ([fe80::29dc:a91e:ea0c:cdeb%12]) with mapi id 14.03.0468.000; Thu, 14 May 2020 10:16:51 -0400 From: "Oleksiy Yakovlev" To: "Jiang, Guomin" , "devel@edk2.groups.io" CC: "Feng, Bob C" , "Gao, Liming" , "Kinney, Michael D" , Felix Polyudov Subject: Re: [edk2-devel] [PATCH v7 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid Thread-Topic: [edk2-devel] [PATCH v7 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid Thread-Index: AQHWKWAWro1G7u2/S0CaQ/kxMPrnc6inM8WAgABttdA= Date: Thu, 14 May 2020 14:16:50 +0000 Message-ID: <6BD875C24FFE2A4E8D6EFC142C67836F03FFFFA33D@atlms1.us.megatrends.com> References: <20200513195248.50296-1-oleksiyy@ami.com> <20200513195248.50296-2-oleksiyy@ami.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.97.158] MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNKsWRmVeSWpSXmKPExsWyRiBhhi5D8N44g4uzeCx+HZ3HZtE+YTab xbVX21ktVtzbwG7R0fGPyYHVY/v3C4wei/e8ZApgimpgtEnMy8svSSxJVUhJLU62VQooyixL TK5UUshMsVUyVFIoyElMTs1NzSuxVUosKEjNS1Gy41LAADZAZZl5Cql5yfkpmXnptkqewf66 FhamlrqGSnYhGakKmXlp+UW5iSWZ+XkKyfl5JUDVqSlAUYWEbs6MF18WMBU8l6k4NfUVewPj dfEuRk4OCQETiTuX2pi7GLk4hAR2MUm8fjGNCcI5zCjRNuEjE0gVm4CmxJtzL1hAbBGBWIlT n44zghQxCyxllDhx9CJQEQeHsEC4xPVVxhA1ERJT9+9mhrCtJKb8WgjWyyKgKrFj/XlGEJtX IFDi2IavrBDLtjBKHJrZBVbECbRgwceLYIsZBcQkvp9aA2YzC4hL3HoynwnibAGJJXvOM0PY ohIvH/9jhbAVJZ5+eMEOUa8jsWD3JzYIW1ti2cLXzBCLBSVOznzCMoFRdBaSsbOQtMxC0jIL ScsCRpZVjEKJJTm5iZk56eVGeom5mXrJ+bmbGCEpI38H48eP5ocYmTgYDzFKcDArifD6rd8d J8SbklhZlVqUH19UmpNafIjRCRgSE5mluEFRBIzzeGMDAylRGMfQxMzE3Mjc0NLE3NhYSZx3 0to1cUIC6cC0k52aWpBaBDOEiYNTqoHR3+VXq5abcN+80tsSEyR2Jn+M7PuxW+lkTfXJmDMz hCu7zXhPq+TPXWD1Ydm0eX1nD2f2bVHgLlCYYvVilxDnM3bfAyHZaiUR1pad4W01BUuNZi1t dE+Xy8m95OdeO0058HVof7jYu62fwz9lfskuYfiwyvSARYz7XAuWyvI/BX7e09+bdSuxFGck GmoxFxUnAgDBbyvcLgMAAA== Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable There was a mistake in all previous v here. I took it from original ECR and misted correction. Now it is up to spec. Regards, Oleksiy. -----Original Message----- From: Jiang, Guomin [mailto:guomin.jiang@intel.com] Sent: Wednesday, May 13, 2020 11:43 PM To: devel@edk2.groups.io; Oleksiy Yakovlev Cc: Feng, Bob C; Gao, Liming; Kinney, Michael D; Felix Polyudov Subject: RE: [edk2-devel] [PATCH v7 1/7] MdePkg: Extend SERIAL_IO with Dev= iceTypeGuid Add some comments. > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Oleksiy > Yakovlev > Sent: Thursday, May 14, 2020 3:53 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > ; Kinney, Michael D ; > Felixp@ami.com; oleksiyy@ami.com > Subject: [edk2-devel] [PATCH v7 1/7] MdePkg: Extend SERIAL_IO with > DeviceTypeGuid > > EFI_SERIAL_IO_PROTOCOL_REVISION incremented to 0x00010001. > CONST EFI_GUID *DeviceTypeGuid field added to the protocol structure. > UEFI 2.8 mantis 1832. > > Signed-off-by: Oleksiy Yakovlev > > Reviewed-by: Liming Gao > --- > MdePkg/Include/Protocol/SerialIo.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/MdePkg/Include/Protocol/SerialIo.h > b/MdePkg/Include/Protocol/SerialIo.h > index 51eaa53..e2e0c61 100644 > --- a/MdePkg/Include/Protocol/SerialIo.h > +++ b/MdePkg/Include/Protocol/SerialIo.h > @@ -263,6 +263,7 @@ typedef struct { > } EFI_SERIAL_IO_MODE; > > #define EFI_SERIAL_IO_PROTOCOL_REVISION 0x00010000 > +#define EFI_SERIAL_IO_PROTOCOL_REVISION1p1 0x00010001 Why add this new definition, it is not exist in patch v5 but exist in patc= h v6? > #define SERIAL_IO_INTERFACE_REVISION > EFI_SERIAL_IO_PROTOCOL_REVISION > > /// > @@ -287,6 +288,14 @@ struct _EFI_SERIAL_IO_PROTOCOL { > /// Pointer to SERIAL_IO_MODE data. > /// > EFI_SERIAL_IO_MODE *Mode; > + /// > + /// Pointer to a GUID identifying the device connected to the serial = port. > + /// This field is NULL when the protocol is installed by the serial > + port /// driver and may be populated by a platform driver for a > + serial port /// with a known device attached. The field will remain > + NULL if there is /// no platform serial device identification informa= tion > available. > + /// > + CONST EFI_GUID *DeviceTypeGuid; // Revision 1.1 > }; > > extern EFI_GUID gEfiSerialIoProtocolGuid; > -- > 2.9.0.windows.1 > > > Please consider the environment before printing this email. > > The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intende= d > to be read only by the individual or entity to whom it is addressed or b= y their > designee. If the reader of this message is not the intended recipient, y= ou are > on notice that any distribution of this message, in any form, is strictl= y > prohibited. Please promptly notify the sender by reply e-mail or by > telephone at 770-246-8600, and then delete or destroy all copies of the > transmission. > >=20 Please consider the environment before printing this email. The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be rea= d only by the individual or entity to whom it is addressed or by their desi= gnee. If the reader of this message is not the intended recipient, you are = on notice that any distribution of this message, in any form, is strictly p= rohibited. Please promptly notify the sender by reply e-mail or by telepho= ne at 770-246-8600, and then delete or destroy all copies of the transmissi= on.