From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x234.google.com (mail-wm0-x234.google.com [IPv6:2a00:1450:400c:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E52B01A1E06 for ; Fri, 2 Sep 2016 08:02:49 -0700 (PDT) Received: by mail-wm0-x234.google.com with SMTP id 1so36194672wmz.1 for ; Fri, 02 Sep 2016 08:02:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:mime-version:in-reply-to:content-transfer-encoding :message-id:cc:from:subject:date:to; bh=yxz6xKIuOsg6xKaFLkk2qG+fl78fMSq1HPVs2X+gBzo=; b=DAIhsbnjBKcG4SO3xDFJ0dnz2SzztnxTaP23VNjPN4nCMVZBptaZ5r5v0a7XuMr5tV mnbFG85wXmO5Eaxpzmt6/4dg19zneVKOWsop9NwbEKtpvmVEwc2tRLR1yoF2YYztTnIH 4bjeMsabyNTXcrxIxXsY6sryxnqfpNhKANLPM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:references:mime-version:in-reply-to :content-transfer-encoding:message-id:cc:from:subject:date:to; bh=yxz6xKIuOsg6xKaFLkk2qG+fl78fMSq1HPVs2X+gBzo=; b=WPG6jpTR42xBXwe3VDbXOgCHeIkj8Gd7vGazGWkJXc9mZfpDkWMS6+RFvKLGlr5V1K VFvMWFOlQI2ZZsB9YJm238W20wsugIK6O0djowO5bBrqVyeBdypyUsiC5T2zb1AN75OL 7UTAkgXrexo7HcOZIq10Nzm2r9GXLGZMrELUjhZDhE+fjXXIoAXQ8702JgCv6oNqYtn1 4cgqQABHXo2pWnvB7i6z7IFsVUKSRZT0LoxjBpUjNhWgWMrbiIlBqg/8rXHcj10tUirQ QG84OQCuCigkr0HPSafX8dAnqkXrn8irNQT5dQuU0BuuV4hJ+EvaHrwKGeW/XJtOGzMr gHJg== X-Gm-Message-State: AE9vXwOGG7H5WSl1e+xbpVVztFvTeaDpY98fF4DQTZizL3LTiLjyuJrWCpCTZ5+w7BrEkYXh X-Received: by 10.28.163.199 with SMTP id m190mr3552979wme.5.1472828568388; Fri, 02 Sep 2016 08:02:48 -0700 (PDT) Received: from [10.19.140.63] (dynrak234g-63-4-67-105.inwitelecom.net. [105.67.4.63]) by smtp.gmail.com with ESMTPSA id v203sm4032370wmv.2.2016.09.02.08.02.47 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 02 Sep 2016 08:02:47 -0700 (PDT) References: <20160902142912.17297-1-leif.lindholm@linaro.org> <20160902142912.17297-2-leif.lindholm@linaro.org> Mime-Version: 1.0 (1.0) In-Reply-To: <20160902142912.17297-2-leif.lindholm@linaro.org> Message-Id: <6C8DC7F6-2459-4CD6-A556-3B17A1FBBF5F@linaro.org> Cc: edk2-devel@lists.01.org, Laszlo Ersek , Michael D Kinney , Liming Gao X-Mailer: iPhone Mail (13G35) From: Ard Biesheuvel Date: Fri, 2 Sep 2016 16:02:44 +0100 To: Leif Lindholm Subject: Re: [PATCH 1/3] MdePkg/Misc: Move ARM* BaseMemoryLibStm to MdePkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Sep 2016 15:02:50 -0000 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable > On 2 sep. 2016, at 15:29, Leif Lindholm wrote: >=20 > Recent changes to the BaseMemoryLib implementations in MdePkg, > and other changes dependent on these, left all ARM* platforms > unbuildable. To avoid this sort of thing in the future, move > the ARM* BaseMemoryLib implementations to the same locations > as the other ones. >=20 Can't we just get rid of the stm version, and move everything to the generic= version? Copying all this crap into MdePkg does not seem like an improvemen= t to me at all. The AArch64 optdxe changes i proposed are arguably as harmless, since they d= on't affect any other arch either. And the stm aarch64 versions are plain c t= o begin with > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leif Lindholm > --- > ArmPkg/ArmPkg.dsc | 1 - > ArmVirtPkg/ArmVirt.dsc.inc | 2 +- > BeagleBoardPkg/BeagleBoardPkg.dsc | 2 +- > {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/AArch64/CopyMem.c | 0 > {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/AArch64/SetMem.c | 0 > {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/Arm/CopyMem.S | 0 > {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/Arm/CopyMem.asm | 0 > {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/Arm/SetMem.S | 0 > {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/Arm/SetMem.asm | 0 > {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf | 0 > {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/CompareMemWrapper.c | 0 > {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/CopyMem.c | 0 > {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/CopyMemWrapper.c | 0 > {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/MemLibGeneric.c | 0 > {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/MemLibGuid.c | 0 > {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/MemLibInternals.h | 0 > {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/ScanMem16Wrapper.c | 0 > {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/ScanMem32Wrapper.c | 0 > {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/ScanMem64Wrapper.c | 0 > {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/ScanMem8Wrapper.c | 0 > {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/SetMem.c | 0 > {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/SetMem16Wrapper.c | 0 > {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/SetMem32Wrapper.c | 0 > {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/SetMem64Wrapper.c | 0 > {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/SetMemWrapper.c | 0 > {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/ZeroMemWrapper.c | 0 > MdePkg/MdePkg.dsc | 1 + > 27 files changed, 3 insertions(+), 3 deletions(-) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/AArch64/CopyMem.c (10= 0%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/AArch64/SetMem.c (100= %) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/Arm/CopyMem.S (100%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/Arm/CopyMem.asm (100%= ) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/Arm/SetMem.S (100%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/Arm/SetMem.asm (100%)= > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf (= 100%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/CompareMemWrapper.c (= 100%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/CopyMem.c (100%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/CopyMemWrapper.c (100= %) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/MemLibGeneric.c (100%= ) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/MemLibGuid.c (100%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/MemLibInternals.h (10= 0%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/ScanMem16Wrapper.c (1= 00%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/ScanMem32Wrapper.c (1= 00%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/ScanMem64Wrapper.c (1= 00%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/ScanMem8Wrapper.c (10= 0%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/SetMem.c (100%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/SetMem16Wrapper.c (10= 0%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/SetMem32Wrapper.c (10= 0%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/SetMem64Wrapper.c (10= 0%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/SetMemWrapper.c (100%= ) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/ZeroMemWrapper.c (100= %) >=20 > diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc > index 6f9fc66..09cbb85 100644 > --- a/ArmPkg/ArmPkg.dsc > +++ b/ArmPkg/ArmPkg.dsc > @@ -112,7 +112,6 @@ [Components.common] > ArmPkg/Library/ArmDisassemblerLib/ArmDisassemblerLib.inf > ArmPkg/Library/ArmDmaLib/ArmDmaLib.inf > ArmPkg/Library/ArmLib/Null/NullArmLib.inf > - ArmPkg/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf > ArmPkg/Library/BdsLib/BdsLib.inf > ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf > ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.inf > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index 6c6a52b..338c22c 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -69,7 +69,7 @@ [LibraryClasses.common] >=20 > # 1/123 faster than Stm or Vstm version > #BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > - BaseMemoryLib|ArmPkg/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf > + BaseMemoryLib|MdePkg/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf >=20 > # Networking Requirements > NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf > diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoar= dPkg.dsc > index b4a645b..7bf7d52 100644 > --- a/BeagleBoardPkg/BeagleBoardPkg.dsc > +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc > @@ -55,7 +55,7 @@ [LibraryClasses.common] > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAll= ocationLib.inf >=20 > BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > - BaseMemoryLib|ArmPkg/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf > + BaseMemoryLib|MdePkg/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf >=20 > EfiResetSystemLib|BeagleBoardPkg/Library/ResetSystemLib/ResetSystemLib.i= nf >=20 > diff --git a/ArmPkg/Library/BaseMemoryLibStm/AArch64/CopyMem.c b/MdePkg/Li= brary/BaseMemoryLibStm/AArch64/CopyMem.c > similarity index 100% > rename from ArmPkg/Library/BaseMemoryLibStm/AArch64/CopyMem.c > rename to MdePkg/Library/BaseMemoryLibStm/AArch64/CopyMem.c > diff --git a/ArmPkg/Library/BaseMemoryLibStm/AArch64/SetMem.c b/MdePkg/Lib= rary/BaseMemoryLibStm/AArch64/SetMem.c > similarity index 100% > rename from ArmPkg/Library/BaseMemoryLibStm/AArch64/SetMem.c > rename to MdePkg/Library/BaseMemoryLibStm/AArch64/SetMem.c > diff --git a/ArmPkg/Library/BaseMemoryLibStm/Arm/CopyMem.S b/MdePkg/Librar= y/BaseMemoryLibStm/Arm/CopyMem.S > similarity index 100% > rename from ArmPkg/Library/BaseMemoryLibStm/Arm/CopyMem.S > rename to MdePkg/Library/BaseMemoryLibStm/Arm/CopyMem.S > diff --git a/ArmPkg/Library/BaseMemoryLibStm/Arm/CopyMem.asm b/MdePkg/Libr= ary/BaseMemoryLibStm/Arm/CopyMem.asm > similarity index 100% > rename from ArmPkg/Library/BaseMemoryLibStm/Arm/CopyMem.asm > rename to MdePkg/Library/BaseMemoryLibStm/Arm/CopyMem.asm > diff --git a/ArmPkg/Library/BaseMemoryLibStm/Arm/SetMem.S b/MdePkg/Library= /BaseMemoryLibStm/Arm/SetMem.S > similarity index 100% > rename from ArmPkg/Library/BaseMemoryLibStm/Arm/SetMem.S > rename to MdePkg/Library/BaseMemoryLibStm/Arm/SetMem.S > diff --git a/ArmPkg/Library/BaseMemoryLibStm/Arm/SetMem.asm b/MdePkg/Libra= ry/BaseMemoryLibStm/Arm/SetMem.asm > similarity index 100% > rename from ArmPkg/Library/BaseMemoryLibStm/Arm/SetMem.asm > rename to MdePkg/Library/BaseMemoryLibStm/Arm/SetMem.asm > diff --git a/ArmPkg/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf b/MdePkg= /Library/BaseMemoryLibStm/BaseMemoryLibStm.inf > similarity index 100% > rename from ArmPkg/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf > rename to MdePkg/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf > diff --git a/ArmPkg/Library/BaseMemoryLibStm/CompareMemWrapper.c b/MdePkg/= Library/BaseMemoryLibStm/CompareMemWrapper.c > similarity index 100% > rename from ArmPkg/Library/BaseMemoryLibStm/CompareMemWrapper.c > rename to MdePkg/Library/BaseMemoryLibStm/CompareMemWrapper.c > diff --git a/ArmPkg/Library/BaseMemoryLibStm/CopyMem.c b/MdePkg/Library/Ba= seMemoryLibStm/CopyMem.c > similarity index 100% > rename from ArmPkg/Library/BaseMemoryLibStm/CopyMem.c > rename to MdePkg/Library/BaseMemoryLibStm/CopyMem.c > diff --git a/ArmPkg/Library/BaseMemoryLibStm/CopyMemWrapper.c b/MdePkg/Lib= rary/BaseMemoryLibStm/CopyMemWrapper.c > similarity index 100% > rename from ArmPkg/Library/BaseMemoryLibStm/CopyMemWrapper.c > rename to MdePkg/Library/BaseMemoryLibStm/CopyMemWrapper.c > diff --git a/ArmPkg/Library/BaseMemoryLibStm/MemLibGeneric.c b/MdePkg/Libr= ary/BaseMemoryLibStm/MemLibGeneric.c > similarity index 100% > rename from ArmPkg/Library/BaseMemoryLibStm/MemLibGeneric.c > rename to MdePkg/Library/BaseMemoryLibStm/MemLibGeneric.c > diff --git a/ArmPkg/Library/BaseMemoryLibStm/MemLibGuid.c b/MdePkg/Library= /BaseMemoryLibStm/MemLibGuid.c > similarity index 100% > rename from ArmPkg/Library/BaseMemoryLibStm/MemLibGuid.c > rename to MdePkg/Library/BaseMemoryLibStm/MemLibGuid.c > diff --git a/ArmPkg/Library/BaseMemoryLibStm/MemLibInternals.h b/MdePkg/Li= brary/BaseMemoryLibStm/MemLibInternals.h > similarity index 100% > rename from ArmPkg/Library/BaseMemoryLibStm/MemLibInternals.h > rename to MdePkg/Library/BaseMemoryLibStm/MemLibInternals.h > diff --git a/ArmPkg/Library/BaseMemoryLibStm/ScanMem16Wrapper.c b/MdePkg/L= ibrary/BaseMemoryLibStm/ScanMem16Wrapper.c > similarity index 100% > rename from ArmPkg/Library/BaseMemoryLibStm/ScanMem16Wrapper.c > rename to MdePkg/Library/BaseMemoryLibStm/ScanMem16Wrapper.c > diff --git a/ArmPkg/Library/BaseMemoryLibStm/ScanMem32Wrapper.c b/MdePkg/L= ibrary/BaseMemoryLibStm/ScanMem32Wrapper.c > similarity index 100% > rename from ArmPkg/Library/BaseMemoryLibStm/ScanMem32Wrapper.c > rename to MdePkg/Library/BaseMemoryLibStm/ScanMem32Wrapper.c > diff --git a/ArmPkg/Library/BaseMemoryLibStm/ScanMem64Wrapper.c b/MdePkg/L= ibrary/BaseMemoryLibStm/ScanMem64Wrapper.c > similarity index 100% > rename from ArmPkg/Library/BaseMemoryLibStm/ScanMem64Wrapper.c > rename to MdePkg/Library/BaseMemoryLibStm/ScanMem64Wrapper.c > diff --git a/ArmPkg/Library/BaseMemoryLibStm/ScanMem8Wrapper.c b/MdePkg/Li= brary/BaseMemoryLibStm/ScanMem8Wrapper.c > similarity index 100% > rename from ArmPkg/Library/BaseMemoryLibStm/ScanMem8Wrapper.c > rename to MdePkg/Library/BaseMemoryLibStm/ScanMem8Wrapper.c > diff --git a/ArmPkg/Library/BaseMemoryLibStm/SetMem.c b/MdePkg/Library/Bas= eMemoryLibStm/SetMem.c > similarity index 100% > rename from ArmPkg/Library/BaseMemoryLibStm/SetMem.c > rename to MdePkg/Library/BaseMemoryLibStm/SetMem.c > diff --git a/ArmPkg/Library/BaseMemoryLibStm/SetMem16Wrapper.c b/MdePkg/Li= brary/BaseMemoryLibStm/SetMem16Wrapper.c > similarity index 100% > rename from ArmPkg/Library/BaseMemoryLibStm/SetMem16Wrapper.c > rename to MdePkg/Library/BaseMemoryLibStm/SetMem16Wrapper.c > diff --git a/ArmPkg/Library/BaseMemoryLibStm/SetMem32Wrapper.c b/MdePkg/Li= brary/BaseMemoryLibStm/SetMem32Wrapper.c > similarity index 100% > rename from ArmPkg/Library/BaseMemoryLibStm/SetMem32Wrapper.c > rename to MdePkg/Library/BaseMemoryLibStm/SetMem32Wrapper.c > diff --git a/ArmPkg/Library/BaseMemoryLibStm/SetMem64Wrapper.c b/MdePkg/Li= brary/BaseMemoryLibStm/SetMem64Wrapper.c > similarity index 100% > rename from ArmPkg/Library/BaseMemoryLibStm/SetMem64Wrapper.c > rename to MdePkg/Library/BaseMemoryLibStm/SetMem64Wrapper.c > diff --git a/ArmPkg/Library/BaseMemoryLibStm/SetMemWrapper.c b/MdePkg/Libr= ary/BaseMemoryLibStm/SetMemWrapper.c > similarity index 100% > rename from ArmPkg/Library/BaseMemoryLibStm/SetMemWrapper.c > rename to MdePkg/Library/BaseMemoryLibStm/SetMemWrapper.c > diff --git a/ArmPkg/Library/BaseMemoryLibStm/ZeroMemWrapper.c b/MdePkg/Lib= rary/BaseMemoryLibStm/ZeroMemWrapper.c > similarity index 100% > rename from ArmPkg/Library/BaseMemoryLibStm/ZeroMemWrapper.c > rename to MdePkg/Library/BaseMemoryLibStm/ZeroMemWrapper.c > diff --git a/MdePkg/MdePkg.dsc b/MdePkg/MdePkg.dsc > index ab57689..75a8f1a 100644 > --- a/MdePkg/MdePkg.dsc > +++ b/MdePkg/MdePkg.dsc > @@ -177,6 +177,7 @@ [Components.EBC] > MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf >=20 > [Components.ARM, Components.AARCH64] > + MdePkg/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf > MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf >=20 > [BuildOptions] > --=20 > 2.9.3 >=20