From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Sami Mujawar <sami.mujawar@arm.com>, devel@edk2.groups.io
Cc: leif@nuviainc.com, Alexei.Fedorov@arm.com,
Pierre.Gondois@arm.com, Matteo.Carlini@arm.com,
Ben.Adderson@arm.com, thomas.abraham@arm.com, nd@arm.com
Subject: Re: [PATCH edk2-platforms v2 0/3] Merge ASL and CfgMngr directories
Date: Thu, 19 Nov 2020 12:59:00 +0100 [thread overview]
Message-ID: <6a2044f8-f2a5-3042-5bc9-5bd3a2cdc528@arm.com> (raw)
In-Reply-To: <20201107094532.42888-1-sami.mujawar@arm.com>
On 11/7/20 10:45 AM, Sami Mujawar wrote:
> This v2 patch series:
> - Merges the PlatformASLTablesLib and ConfigurationManagerDxe
> directories on the Juno and VExpress plarforms. The
> PlatformASLTablesLib directory used to be a separated module
> to build ASL files independantly. This is not necessary anymore.
>
> - Fixes the build break for FVP & Juno firmware when Dynamic
> Tables Framework is used for generating ACPI tables.
>
> - The last patch in this series increases the Juno FD size as
> this has increased following the merge of Dynamic AML feature
> in DynamicTablesPkg. This patch has been copied from the
> Dynamic AML platform support series at
> https://edk2.groups.io/g/devel/message/64169
>
> The changes can be seen at:
> https://github.com/samimujawar/edk2-platforms/tree/847_Merge_ASL_and_CfgMngr_dir_v2
>
> Pierre Gondois (3):
> Platform/ARM/Juno: Merge ASL and CfgMngr directories
> Platform/ARM/VExpressPkg: Merge ASL and CfgMngr directories
> Platform/ARM/Juno: Increase FD size
>
Pushed as 867efd012b2f..adcb0c92ca57
Apologies for the delay.
> Platform/ARM/JunoPkg/ArmJuno.fdf | 8 ++--
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.inc | 10 +----
> Platform/ARM/JunoPkg/ConfigurationManager/{PlatformASLTablesLib => ConfigurationManagerDxe/AslTables}/Dsdt.asl | 0
> Platform/ARM/JunoPkg/ConfigurationManager/{PlatformASLTablesLib => ConfigurationManagerDxe/AslTables}/SsdtJunoUsb.asl | 0
> Platform/ARM/JunoPkg/ConfigurationManager/{PlatformASLTablesLib => ConfigurationManagerDxe/AslTables}/SsdtPci.asl | 0
> Platform/ARM/JunoPkg/ConfigurationManager/{PlatformASLTablesLib => ConfigurationManagerDxe/AslTables}/SsdtUart.asl | 0
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 8 +---
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h | 11 +++++-
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf | 7 +++-
> Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf | 39 --------------------
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.dsc.inc | 10 +----
> Platform/ARM/VExpressPkg/ConfigurationManager/{PlatformASLTablesLib => ConfigurationManagerDxe/AslTables}/Dsdt.asl | 0
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 5 +--
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h | 8 +++-
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf | 4 +-
> Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf | 29 ---------------
> 16 files changed, 34 insertions(+), 105 deletions(-)
> rename Platform/ARM/JunoPkg/ConfigurationManager/{PlatformASLTablesLib => ConfigurationManagerDxe/AslTables}/Dsdt.asl (100%)
> rename Platform/ARM/JunoPkg/ConfigurationManager/{PlatformASLTablesLib => ConfigurationManagerDxe/AslTables}/SsdtJunoUsb.asl (100%)
> rename Platform/ARM/JunoPkg/ConfigurationManager/{PlatformASLTablesLib => ConfigurationManagerDxe/AslTables}/SsdtPci.asl (100%)
> rename Platform/ARM/JunoPkg/ConfigurationManager/{PlatformASLTablesLib => ConfigurationManagerDxe/AslTables}/SsdtUart.asl (100%)
> delete mode 100644 Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf
> rename Platform/ARM/VExpressPkg/ConfigurationManager/{PlatformASLTablesLib => ConfigurationManagerDxe/AslTables}/Dsdt.asl (100%)
> delete mode 100644 Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf
>
prev parent reply other threads:[~2020-11-19 11:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 9:45 [PATCH edk2-platforms v2 0/3] Merge ASL and CfgMngr directories Sami Mujawar
2020-11-07 9:45 ` [PATCH edk2-platforms v2 1/3] Platform/ARM/Juno: " Sami Mujawar
2020-11-07 9:45 ` [PATCH edk2-platforms v2 2/3] Platform/ARM/VExpressPkg: " Sami Mujawar
2020-11-07 9:45 ` [PATCH edk2-platforms v2 3/3] Platform/ARM/Juno: Increase FD size Sami Mujawar
2020-11-19 11:59 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a2044f8-f2a5-3042-5bc9-5bd3a2cdc528@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox