From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.8051.1605787149483324931 for ; Thu, 19 Nov 2020 03:59:09 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A19551396; Thu, 19 Nov 2020 03:59:08 -0800 (PST) Received: from [192.168.1.81] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D20CC3F718; Thu, 19 Nov 2020 03:59:06 -0800 (PST) Subject: Re: [PATCH edk2-platforms v2 0/3] Merge ASL and CfgMngr directories To: Sami Mujawar , devel@edk2.groups.io Cc: leif@nuviainc.com, Alexei.Fedorov@arm.com, Pierre.Gondois@arm.com, Matteo.Carlini@arm.com, Ben.Adderson@arm.com, thomas.abraham@arm.com, nd@arm.com References: <20201107094532.42888-1-sami.mujawar@arm.com> From: "Ard Biesheuvel" Message-ID: <6a2044f8-f2a5-3042-5bc9-5bd3a2cdc528@arm.com> Date: Thu, 19 Nov 2020 12:59:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201107094532.42888-1-sami.mujawar@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/7/20 10:45 AM, Sami Mujawar wrote: > This v2 patch series: > - Merges the PlatformASLTablesLib and ConfigurationManagerDxe > directories on the Juno and VExpress plarforms. The > PlatformASLTablesLib directory used to be a separated module > to build ASL files independantly. This is not necessary anymore. > > - Fixes the build break for FVP & Juno firmware when Dynamic > Tables Framework is used for generating ACPI tables. > > - The last patch in this series increases the Juno FD size as > this has increased following the merge of Dynamic AML feature > in DynamicTablesPkg. This patch has been copied from the > Dynamic AML platform support series at > https://edk2.groups.io/g/devel/message/64169 > > The changes can be seen at: > https://github.com/samimujawar/edk2-platforms/tree/847_Merge_ASL_and_CfgMngr_dir_v2 > > Pierre Gondois (3): > Platform/ARM/Juno: Merge ASL and CfgMngr directories > Platform/ARM/VExpressPkg: Merge ASL and CfgMngr directories > Platform/ARM/Juno: Increase FD size > Pushed as 867efd012b2f..adcb0c92ca57 Apologies for the delay. > Platform/ARM/JunoPkg/ArmJuno.fdf | 8 ++-- > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.inc | 10 +---- > Platform/ARM/JunoPkg/ConfigurationManager/{PlatformASLTablesLib => ConfigurationManagerDxe/AslTables}/Dsdt.asl | 0 > Platform/ARM/JunoPkg/ConfigurationManager/{PlatformASLTablesLib => ConfigurationManagerDxe/AslTables}/SsdtJunoUsb.asl | 0 > Platform/ARM/JunoPkg/ConfigurationManager/{PlatformASLTablesLib => ConfigurationManagerDxe/AslTables}/SsdtPci.asl | 0 > Platform/ARM/JunoPkg/ConfigurationManager/{PlatformASLTablesLib => ConfigurationManagerDxe/AslTables}/SsdtUart.asl | 0 > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 8 +--- > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h | 11 +++++- > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf | 7 +++- > Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf | 39 -------------------- > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.dsc.inc | 10 +---- > Platform/ARM/VExpressPkg/ConfigurationManager/{PlatformASLTablesLib => ConfigurationManagerDxe/AslTables}/Dsdt.asl | 0 > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 5 +-- > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h | 8 +++- > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf | 4 +- > Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf | 29 --------------- > 16 files changed, 34 insertions(+), 105 deletions(-) > rename Platform/ARM/JunoPkg/ConfigurationManager/{PlatformASLTablesLib => ConfigurationManagerDxe/AslTables}/Dsdt.asl (100%) > rename Platform/ARM/JunoPkg/ConfigurationManager/{PlatformASLTablesLib => ConfigurationManagerDxe/AslTables}/SsdtJunoUsb.asl (100%) > rename Platform/ARM/JunoPkg/ConfigurationManager/{PlatformASLTablesLib => ConfigurationManagerDxe/AslTables}/SsdtPci.asl (100%) > rename Platform/ARM/JunoPkg/ConfigurationManager/{PlatformASLTablesLib => ConfigurationManagerDxe/AslTables}/SsdtUart.asl (100%) > delete mode 100644 Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf > rename Platform/ARM/VExpressPkg/ConfigurationManager/{PlatformASLTablesLib => ConfigurationManagerDxe/AslTables}/Dsdt.asl (100%) > delete mode 100644 Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf >