From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Nhi Pham <nhi@os.amperecomputing.com>,
devel@edk2.groups.io, quic_llindhol@quicinc.com,
ardb+tianocore@kernel.org, quic_rcran@quicinc.com
Cc: patches@amperecomputing.com,
Minh Nguyen <minhn@amperecomputing.com>,
"nd@arm.com" <nd@arm.com>
Subject: Re: [PATCH 4/6] ArmPkg/SmbiosMiscDxe: Fix typo of "AssetTagType02"
Date: Tue, 23 Aug 2022 17:34:28 +0100 [thread overview]
Message-ID: <6a2e6eed-95e7-0421-47cd-89fbf273636f@arm.com> (raw)
In-Reply-To: <20220823105926.1379824-5-nhi@os.amperecomputing.com>
Hi Nhi,
Thank you for this fix.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 23/08/2022 11:59 am, Nhi Pham wrote:
> From: Minh Nguyen <minhn@amperecomputing.com>
>
> This patch fixes typo from "AssertTagType02"
> to "AssetTagType02".
>
> Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
> ---
> ArmPkg/Include/Library/OemMiscLib.h | 2 +-
> ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/OemMiscLib.h
> index d87737db9c2b..1936619d9b5b 100644
> --- a/ArmPkg/Include/Library/OemMiscLib.h
> +++ b/ArmPkg/Include/Library/OemMiscLib.h
> @@ -44,7 +44,7 @@ typedef enum {
> VersionType01,
>
> SkuNumberType01,
>
> FamilyType01,
>
> - AssertTagType02,
>
> + AssetTagType02,
>
> SerialNumberType02,
>
> BoardManufacturerType02,
>
> ProductNameType02,
>
> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c
> index 870610b17243..f61546955f12 100644
> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c
> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c
> @@ -4,6 +4,7 @@
>
>
> Based on files under Nt32Pkg/MiscSubClassPlatformDxe/
>
>
>
> + Copyright (c) 2022, Ampere Computing LLC. All rights reserved.<BR>
>
> Copyright (c) 2021, NUVIA Inc. All rights reserved.<BR>
>
> Copyright (c) 2009 - 2011, Intel Corporation. All rights reserved.<BR>
>
> Copyright (c) 2015, Hisilicon Limited. All rights reserved.<BR>
>
> @@ -112,7 +113,7 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBaseBoardManufacturer) {
> OemUpdateSmbiosInfo (
>
> mSmbiosMiscHiiHandle,
>
> STRING_TOKEN (STR_MISC_BASE_BOARD_ASSET_TAG),
>
> - AssertTagType02
>
> + AssetTagType02
>
> );
>
> OemUpdateSmbiosInfo (
>
> mSmbiosMiscHiiHandle,
>
next prev parent reply other threads:[~2022-08-23 16:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 10:59 [PATCH 0/6] ArmPkg/SMBIOS fixes and improvements Nhi Pham
2022-08-23 10:59 ` [PATCH 1/6] ArmPkg/ProcessorSubClassDxe: Get processor version from OemMiscLib Nhi Pham
2022-08-23 16:21 ` Sami Mujawar
2022-08-24 16:10 ` Nhi Pham
2022-08-23 10:59 ` [PATCH 2/6] ArmPkg: Correct return value of "SMCCC_ARCH_SOC_ID" Function ID call Nhi Pham
2022-08-23 16:28 ` Sami Mujawar
2022-08-23 10:59 ` [PATCH 3/6] ArmPkg/SmbiosMiscDxe: Support fetching System UUID Nhi Pham
2022-08-23 16:31 ` Sami Mujawar
2022-08-23 10:59 ` [PATCH 4/6] ArmPkg/SmbiosMiscDxe: Fix typo of "AssetTagType02" Nhi Pham
2022-08-23 16:34 ` Sami Mujawar [this message]
2022-08-23 10:59 ` [PATCH 5/6] ArmPkg/SmbiosMiscDxe: Remove redundant updates in SMBIOS Type 2 Nhi Pham
2022-08-23 16:36 ` Sami Mujawar
2022-08-23 10:59 ` [PATCH 6/6] ArmPkg/SmbiosMiscDxe: Get SMBIOS information from OemMiscLib Nhi Pham
2022-08-23 16:57 ` Sami Mujawar
2022-08-23 14:24 ` [edk2-devel] [PATCH 0/6] ArmPkg/SMBIOS fixes and improvements Rebecca Cran
2022-08-23 15:57 ` PierreGondois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a2e6eed-95e7-0421-47cd-89fbf273636f@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox