From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.43]) by mx.groups.io with SMTP id smtpd.web10.79.1661272484440707406 for ; Tue, 23 Aug 2022 09:34:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Lc9neCHc; spf=pass (domain: arm.com, ip: 40.107.20.43, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RncX+88Puk+AWy7puBzuj1BO2r12is7t0//9JyX0wM20lo1dKCofca0OFh3iN4+XQ84mHivREhvtKKvZNZ7y04pu4NpoEgqANGXnUJDTzmz6nsQuffQFke/VzWW6g8HpMK5oYWGLgrA3DpcLDXOjq4dxrqXd8leYO+kYrOzRE7kKxAM44rPEPUu/ZOAeC5cbjDu+YsdkSJP1CQHqDtk5L3Rv8UartKwkEd2esfTVSDZmlgxVGxsj6b1KT/Wsbu53y2J8MWEBW2J2YTiVZmzPG2sTDmJEX9d+pJiPxNlgOcR8CvPk8TnanXCYR6O7HojV1vbkPnjzXPasbzGUxxzyLQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=974SWrgse4AzGYXnqEc+00pZxIIR4Eee9jkFyzh/TgQ=; b=Q2E095q1c7KMLXJ1rvVoVOS8zz7GqUQ+/sMdiGb+bD/XjWG9W6aG+St6A9aRAnXf6W2MMIR+7IJ/sCr9XCI3B5QpTMkULJfH+pnwFihMi8PUiizv6m0ixfrb1Vkjjq+YGeoaMRct5FbK/ASQIMUimAup9luVQ+kcAuP1eA7UJgquwK8p6PetghAqkKfyE7kNNkweb2Q1gHio0/nwGdcGfbwWcETuZvAfYuAl16GQOhHK7n+5+WB883p0GE/NYZjjaSzLnXYRf8kEjKdmBPCjzUR4jhmVZ1ZC1mawZtktuJ/xfiHiJG/ej71bDQQqdewGuYPq4XBrZYFNobcYsMA8sg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=974SWrgse4AzGYXnqEc+00pZxIIR4Eee9jkFyzh/TgQ=; b=Lc9neCHctDQwp222Whv17NEdq1SHru3K4yEyPVwWo67BnoJhkuslJksdvVxkEAbeco8PMK44WTP/hmCWwbKS0yAQYV7FsI/uiE68nvrnxOUeJvx7Hnzmqkp9juLQInP2XSF9iWqdNoTiM4qgOgAXvyG8O8YAzIHI3p0gRGddTWs= Received: from DB6PR0301CA0065.eurprd03.prod.outlook.com (2603:10a6:4:54::33) by VI1PR0801MB2031.eurprd08.prod.outlook.com (2603:10a6:800:8b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.16; Tue, 23 Aug 2022 16:34:40 +0000 Received: from DBAEUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:54:cafe::f0) by DB6PR0301CA0065.outlook.office365.com (2603:10a6:4:54::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.24 via Frontend Transport; Tue, 23 Aug 2022 16:34:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT054.mail.protection.outlook.com (100.127.142.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.15 via Frontend Transport; Tue, 23 Aug 2022 16:34:39 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Tue, 23 Aug 2022 16:34:39 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: e361c06cd79c1fc1 X-CR-MTA-TID: 64aa7808 Received: from 3be2589289e8.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A1C167B9-9209-449C-81F7-03E192BC1636.1; Tue, 23 Aug 2022 16:34:32 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3be2589289e8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 23 Aug 2022 16:34:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AmguzcxXKcpbqPhNLQoO5rFj1oWFRsXmrZYAs9jADLWLZB4V2UPL4zkjnGB8bbKAxYDcnPGbLxDiBX+XuqjIbCOnGhr3TDyAKz4z21ys+DVDZojWDK0CBWu2QMuxsyBCBAsh6gt+diGVwgFdmlJLFC2D3llNNxG4LSzYBfcNFWQNYL5oVl8FhNd96JXtLgFEAWw9pA8lVEHY091bBf4vJNvyfTJ+sLFJ4PFEfxU98xYf2/D3TaUI3NDXMilEFBi8bYTXBFZ5WBc6Ute+wbYFUBsWTaZVHVjaK/NLSnIZDPWmC3qcAdotufvVeORYsWP7JiBlqe067JgdIZ8t7yUHdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=974SWrgse4AzGYXnqEc+00pZxIIR4Eee9jkFyzh/TgQ=; b=G4y+d5UharZuHpyNlpQwrfZ1s4PDHizqxYmm3NBehLIK8sGvfTsv2HhlpOpR1XBPsWWIGcGXPrlHPX5FYDG+UkTOLA37prDVGoseLm26is43jUleK7XYfTzy8kms5MRNoqMcEDnpu4Zofg7ufwrEp31y4EsSskD0F73uuaKwKg9F8crW3WLR3JMl41KUmn3g3PsMIB00H6Gp2iarKt9WEeUYgSSTm+D2xjvUu6VN/SFO80SlZXXhiKB5LYHJ+bF054L6vbzvVUV8BBrDGQyW+9C4sM+HHRLXlnYyJHuUebfISuSGVvpNLH6BLEX7YsNZvlgi4kYKv2wSU27j+tmTjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=974SWrgse4AzGYXnqEc+00pZxIIR4Eee9jkFyzh/TgQ=; b=Lc9neCHctDQwp222Whv17NEdq1SHru3K4yEyPVwWo67BnoJhkuslJksdvVxkEAbeco8PMK44WTP/hmCWwbKS0yAQYV7FsI/uiE68nvrnxOUeJvx7Hnzmqkp9juLQInP2XSF9iWqdNoTiM4qgOgAXvyG8O8YAzIHI3p0gRGddTWs= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS2PR08MB8808.eurprd08.prod.outlook.com (2603:10a6:20b:5f4::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14; Tue, 23 Aug 2022 16:34:30 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::b480:677a:ac9b:8f24]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::b480:677a:ac9b:8f24%6]) with mapi id 15.20.5546.022; Tue, 23 Aug 2022 16:34:30 +0000 Message-ID: <6a2e6eed-95e7-0421-47cd-89fbf273636f@arm.com> Date: Tue, 23 Aug 2022 17:34:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 4/6] ArmPkg/SmbiosMiscDxe: Fix typo of "AssetTagType02" To: Nhi Pham , devel@edk2.groups.io, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, quic_rcran@quicinc.com Cc: patches@amperecomputing.com, Minh Nguyen , "nd@arm.com" References: <20220823105926.1379824-1-nhi@os.amperecomputing.com> <20220823105926.1379824-5-nhi@os.amperecomputing.com> From: "Sami Mujawar" In-Reply-To: <20220823105926.1379824-5-nhi@os.amperecomputing.com> X-ClientProxiedBy: LO4P123CA0611.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:314::10) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: ebd6befa-f0d2-4980-7826-08da85256007 X-MS-TrafficTypeDiagnostic: AS2PR08MB8808:EE_|DBAEUR03FT054:EE_|VI1PR0801MB2031:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ry4iFQGFznjsXqtnj+acdi3hf395Ht0s+wzdXtgIcLwa0hx9OEvtN+fZW5kcrCx74DiZtXhRCI5cC19hGam/5/BepjcR+lr+Uf0rsJWQXeiOPu85CAv0logb/XtiOEgPoVVZsR2tRapWr5lIPAP65w4yvDfls1b/jlJD5SYQLwENavT+YpyMKN6k7JQnnA8y3LdbemyUNyzM7iE/P0P/tYzCW6hp+CsoJWl3nNZnGUNOmD1AcYxbyFTpKatk46Uov5PpZEhahixTND67d7PVxZKF+G5G0puV3PWqmi0+3k1XaVijCkUG6Vs9q6V2QVsrf8X93viRKZrjFrfvp8IWNNjgiBUXW8pHp32ugBQCNyPdVBBc3ZU6n4ClOXJcTcpWpWa5PwUAyu27ullqsVN3dYWeQdv/8/gJgKro1j6BLPFZxlQ4xXYEEz/FyjgZ6onEIWoy//50Yji3mu3mAarZjGFsIB82QE1fUN3UtFsj+H6L8Wz5j4K6eHvMPPRhuhlp9phoM9zGSXJuwPQ44dLygbcFEB69ZCSvQTmGLW3pJhlbxfeh1NWQKwNxM7tYi2zRQ3ClI3+7nYbHNGn6P943UrfkSUHE7jSOD93sK3PjidSo4IuxJrpXvhzWCjzAH0HOBxGd9WF7UO6YQJeVBw1zdZG6omqKjWl49LpyZR8E8lg/SyT8/Zchx+6lOo32o7ud+rj4x5juwmhH6fJH2865d7www/Em5ipRTn4EkbeWysDPxmR4TeUQrRBlvszvOZM/LYJ3BZqw+jZ4nbBlf1sJsWLrfTCcb6E1d5nzkxPjl/8= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(136003)(366004)(39860400002)(396003)(31686004)(5660300002)(8936002)(26005)(6506007)(53546011)(6512007)(2906002)(44832011)(478600001)(41300700001)(86362001)(6486002)(31696002)(36756003)(45954011)(186003)(83380400001)(66556008)(54906003)(8676002)(4326008)(316002)(19627235002)(38100700002)(66476007)(66946007)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8808 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4b1b5f0b-2d8c-49a1-a115-08da85255ab3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GtlBhIU0le0czWEhpZOn8amlGAm3YapNkDPW01JaH1YaHX8HOfTRMh8xhSG+FZTKQ7TAW4NBLuZKOAFsPAt2BWKZg0G0hd/NCaaAA/3xSgoFvEhyR+75HUPzFo7+Xtl3lgLjFu7vqqLlgbn9T58hnzWYf8wgagazZ06KSKG+kku6NexACXOphqo93dOY2Mcp2ei0UtZK4BPM+ePOw0ZvF/fKjDiU4eNsPDIO1vc9iq77ysbbDnef75ur+avqxn9RoH6tzOj+aZeAS+Duqbqy0VG8ercd1Nt8Za590sGvdi69d6au30E4+kzZE2Xfv39Xf2wnmASdnm4wiCHar+0fJN8bE9tkj4hcA+klzk4WPyfDWPJEPN8Om5RzxBgJB2+4elrnTlO+jK9ns6jfvA1VsH3tvoY/CZFwGYKOGhVS8lsXaKumXYDRud3WI7mkNmVFC+8kxyfXGfRsT0ThQaXcHFwonRTDDrXfZaR8Aj/nbr8uW71keTUARFvADKcuUCh0VSoOSBbjkkelliEJoz4qf0uW6gKRrsScrFbsB9xbTQr9JpVjuxOfuOfw6Q08pflcm9tjtSuOYZGfC2v0TzTH7DXiS4r17R6DKbBZwsXTzDUKwT0TbsdJcnNmHnSf/lv58MGECVz7jpbUK+JnmRFmT4+9cbpeSICY2vJwgttUr5Zj2e5ZTOPK7fov0MVxBNFGXvfqJ1aYtW8lTwFM5PoqvlHfh3NOuJAmL9wSpjDHAkTKggAAiV6Q5sHznzz+W7jE85tKQb/EPicfOjJECUIapr1Bet/lZm65IT44ge+mgsE= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(346002)(396003)(136003)(36840700001)(46966006)(40470700004)(41300700001)(5660300002)(6486002)(8936002)(478600001)(31696002)(53546011)(2906002)(6506007)(44832011)(40460700003)(26005)(6512007)(81166007)(82740400003)(356005)(86362001)(40480700001)(82310400005)(45954011)(36860700001)(186003)(336012)(2616005)(47076005)(83380400001)(70586007)(8676002)(70206006)(31686004)(4326008)(316002)(36756003)(54906003)(19627235002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2022 16:34:39.7576 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ebd6befa-f0d2-4980-7826-08da85256007 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB2031 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Nhi, Thank you for this fix. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/08/2022 11:59 am, Nhi Pham wrote: > From: Minh Nguyen > > This patch fixes typo from "AssertTagType02" > to "AssetTagType02". > > Signed-off-by: Nhi Pham > --- > ArmPkg/Include/Library/OemMiscLib.h | 2 +- > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/OemMiscLib.h > index d87737db9c2b..1936619d9b5b 100644 > --- a/ArmPkg/Include/Library/OemMiscLib.h > +++ b/ArmPkg/Include/Library/OemMiscLib.h > @@ -44,7 +44,7 @@ typedef enum { > VersionType01, > > SkuNumberType01, > > FamilyType01, > > - AssertTagType02, > > + AssetTagType02, > > SerialNumberType02, > > BoardManufacturerType02, > > ProductNameType02, > > diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c > index 870610b17243..f61546955f12 100644 > --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c > +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c > @@ -4,6 +4,7 @@ > > > Based on files under Nt32Pkg/MiscSubClassPlatformDxe/ > > > > + Copyright (c) 2022, Ampere Computing LLC. All rights reserved.
> > Copyright (c) 2021, NUVIA Inc. All rights reserved.
> > Copyright (c) 2009 - 2011, Intel Corporation. All rights reserved.
> > Copyright (c) 2015, Hisilicon Limited. All rights reserved.
> > @@ -112,7 +113,7 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBaseBoardManufacturer) { > OemUpdateSmbiosInfo ( > > mSmbiosMiscHiiHandle, > > STRING_TOKEN (STR_MISC_BASE_BOARD_ASSET_TAG), > > - AssertTagType02 > > + AssetTagType02 > > ); > > OemUpdateSmbiosInfo ( > > mSmbiosMiscHiiHandle, >