From: "Laszlo Ersek" <lersek@redhat.com>
To: "Gao, Zhichao" <zhichao.gao@intel.com>,
"Wu, Hao A" <hao.a.wu@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>,
"Ni, Ray" <ray.ni@intel.com>,
"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH 1/3] MdeModulePkg: Entend the support keyboard type of Terminal console
Date: Mon, 16 Sep 2019 13:24:42 +0200 [thread overview]
Message-ID: <6a481c73-9d5a-2ade-b6a1-d422fec35844@redhat.com> (raw)
In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B83A789@SHSMSX101.ccr.corp.intel.com>
Hi Zhichao,
On 09/16/19 07:15, Gao, Zhichao wrote:
> Hi Roy, Ard, Laszlo,
>
> Do you have any comment if I add the new terminal type to TtyTerm.h? As PcAnsi.h, the spec mentioned terminal types are put into one header file.
I've seen the original posting. I have no particular comments.
In ArmVirtPkg, there is a build flag (-D TTY_TERMINAL) for setting
TtyTerm as the default terminal type. But, I don't use it, so I can't
comment from that perspective either.
So, from my side, the only request is that the current functionality
should not be regressed please.
Thanks
Laszlo
next prev parent reply other threads:[~2019-09-16 11:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 1:02 [PATCH 0/3] MdeModulePkg/TerminalConsole: Extend the support terminal types Gao, Zhichao
2019-09-12 1:02 ` [PATCH 1/3] MdeModulePkg: Entend the support keyboard type of Terminal console Gao, Zhichao
2019-09-12 2:42 ` Wu, Hao A
2019-09-13 18:09 ` [edk2-devel] " Brian J. Johnson
2019-09-16 0:32 ` Gao, Zhichao
2019-09-16 5:12 ` Gao, Zhichao
2019-09-16 5:15 ` Gao, Zhichao
2019-09-16 11:24 ` Laszlo Ersek [this message]
2019-09-12 1:02 ` [PATCH 2/3] MdeModulePkg/TerminalDxe: Extend the terminal console support types Gao, Zhichao
2019-09-12 2:44 ` Wu, Hao A
2019-09-12 1:02 ` [PATCH 3/3] MdeModulePkg/BM_UI: Add the new terminal types to related menu Gao, Zhichao
2019-09-12 2:49 ` Wu, Hao A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a481c73-9d5a-2ade-b6a1-d422fec35844@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox