From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Mon, 16 Sep 2019 04:24:47 -0700
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id EE96A30833A8;
	Mon, 16 Sep 2019 11:24:46 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-35.rdu2.redhat.com [10.10.120.35])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 0AF4F60C80;
	Mon, 16 Sep 2019 11:24:43 +0000 (UTC)
Subject: Re: [PATCH 1/3] MdeModulePkg: Entend the support keyboard type of Terminal console
To: "Gao, Zhichao" <zhichao.gao@intel.com>, "Wu, Hao A" <hao.a.wu@intel.com>,
 "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
 "ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>
References: <20190912010231.19544-1-zhichao.gao@intel.com>
 <20190912010231.19544-2-zhichao.gao@intel.com>
 <B80AF82E9BFB8E4FBD8C89DA810C6A093C931F1F@SHSMSX104.ccr.corp.intel.com>
 <3CE959C139B4C44DBEA1810E3AA6F9000B83A789@SHSMSX101.ccr.corp.intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <6a481c73-9d5a-2ade-b6a1-d422fec35844@redhat.com>
Date: Mon, 16 Sep 2019 13:24:42 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B83A789@SHSMSX101.ccr.corp.intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Mon, 16 Sep 2019 11:24:47 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Zhichao,

On 09/16/19 07:15, Gao, Zhichao wrote:
> Hi Roy, Ard, Laszlo,
> 
> Do you have any comment if I add the new terminal type to TtyTerm.h? As PcAnsi.h, the spec mentioned terminal types are put into one header file.

I've seen the original posting. I have no particular comments.

In ArmVirtPkg, there is a build flag (-D TTY_TERMINAL) for setting
TtyTerm as the default terminal type. But, I don't use it, so I can't
comment from that perspective either.

So, from my side, the only request is that the current functionality
should not be regressed please.

Thanks
Laszlo