From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B944E940EA5 for ; Thu, 4 Jan 2024 02:11:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=QIlJV7KqF8Uy1fXccx9Tg/Ru0EvQPGF9dhuB6Baa9rs=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704334277; v=1; b=THE4L0DZ/jaROjCsGbEqVekq08ieOHSoTpqI7ur45/7dJdMdxu9K4hZcRpEHX/dUSm9k4pH3 eOmCAoR2C4jBew7lhfRa3SN18ZLSmPb1BFm67fO4D4EDiY81IU2u6a9YYINutLjVzrtl1DLBZgu aq8fs5uZq9Z3X/1fHIxQnWdk= X-Received: by 127.0.0.2 with SMTP id BNUbYY7687511x8iSqwVQnnW; Wed, 03 Jan 2024 18:11:17 -0800 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.40]) by mx.groups.io with SMTP id smtpd.web11.45502.1704334275979724409 for ; Wed, 03 Jan 2024 18:11:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D1rx67Q6t1QZ9ZqXaQw7S4fCYEzhtVdos9iR2eK+5QSAUmRiSIg2vhWLW33cae2yPmLAjgXYbID3R1eNEQ+9mKcoDkhMRtKSRBTHsRc0B2iBpXl3aJ0AmAEGvlff4CyEekPRnzbKm1v0q1YF5Brxm2JWjezsmu1bMxl9RJPSTKc5R1Zxir4SCXzi34q7XfE29xSwQfuXnYbT23xsQMu+nrk2Z0WA/5eR78PuHBtUqnWFdyoEknDfTdscOp/Kb3y2fs1lnbSJXT3Kv7b7UqgRWbYxk0j72iGUIklZSi8U+udWWLQqndqnG6H8QeUHNdFfXzN24OmNZGghHPSukzA6Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7GbuPmGwRV0LNOsLfo4iBKweUa/udzBKEPqFOcPWFAo=; b=Ncx9oyqX1+t+xBYQDACPvFvq/kJFssKkKIhkwboyd3BPEp6dawz+acVpigtZiB6qXn9yqp3I27QHTBvQ8nLYChsAOn+AHriZtrVq6r2M6ulufTPLnOVwIn1DDtJWgVf1MhczUNuy8f/o216M2Kg510FH/5C5Yisfk3IvRjvJ2hU2PrknMqRpCZSkagvrITwN7Usfc5C9x/Dtv/lZS0+Az9A68C7s+MTWApk2jvXqVsnB70muJ37I5GtDcXMBzhNS8RoKD1OlMIB75VAL2McEV/V4J8BIV8Q/92Po32ov8i5dg+BRKZlN1uRf5DkZvps5LxjlsEkBmk4VgLtsNzw6Pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) by BY5PR12MB4129.namprd12.prod.outlook.com (2603:10b6:a03:213::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.13; Thu, 4 Jan 2024 02:11:13 +0000 X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::c436:397e:a940:5e6d]) by IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::c436:397e:a940:5e6d%4]) with mapi id 15.20.7135.023; Thu, 4 Jan 2024 02:11:12 +0000 Message-ID: <6a52f5e6-3a20-435e-aeac-981d26bcfd31@amd.com> Date: Thu, 4 Jan 2024 07:41:05 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 compilation errors To: Sami Mujawar , devel@edk2.groups.io, "nd@arm.com" , Pierre Gondois References: From: "Abdul Lateef Attar via groups.io" In-Reply-To: X-ClientProxiedBy: PN3PR01CA0177.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:de::19) To IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR12MB6458:EE_|BY5PR12MB4129:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f6d0a57-ffeb-45cc-f52b-08dc0cca6c37 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: QoI3Imc4taKpTKp+tNv0rmiSs9eF9ubCFBSLxRQox9vSSCm5gzcOO72ol/Q25eU4OcRpGGDYIWewPr6SE8XNNO+TQRaMx/xBa9DX492l3DpSwYAPDtSkBbsQcyGO+y0vC4Iu6335OAP+2Zaquwst65ltwUUZhEzwCHMp47QqBEAAssXM4vPjQI38MCcnOteNsriUNhUabIzu5804xgd27xwZmH+KDIreIOFMBW7n+Ju004uKloilvyRPdrsQlMKi7zHlf6mAOQyo8ngncslwFvAC/LcpgKiNZ+aDJwI3xS+11wxRhtgD6igdf77AX5nysMcmfU/eyCsDIAQD4ZQkQwTFe1jr3ZcyjuGnjyamEH77Ghs0lfcuATv9KnsIXZZoTHolntSSJnHQ3zjN2lvBhy4ixRSI1/k+1vXvi6o8SWFi7qzpQPPiT9pj1Y0NaZns1riQ6hhMXg0FiDLTUH7agYqO2wLYM7+dG2B4x/XNW4cen5mbkl2LC4w0O30vH+Nj/7wB20510RZDZX0lxlyW9Isq7ghHMWlNR/jgUugoZ0av9BWCAW523u3FjRRRgftBjS8e3FDnbRR/wWeK6lyFqOav95okWFI/gLnfov6Obljm6MeTctK0ymJgbqpfL0y8JnOP3WwDB76FsVo3pU7h0FYrTjGdbC8STOInGKkShe6+iydWxt2Kx66o96LrSc0oFEwFUQ8UOb+e0GKtlqR7cg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9dv2LXXQM53SIn3TPHmDj7HFdWPjmRb2XozppjGotXov5Zt0gUJqEFq5KIwT?= =?us-ascii?Q?bsOG5mWWQ9HZHDvylIPv6OQXXBR8fzTt4c9evw93LXL1QYP2rTnnc00ZvEDp?= =?us-ascii?Q?mOAHhNU6+QIVMCujqDMXLwZPHkYdNiu5n7cek2GPnAJbzoSwD/gmdEClPicJ?= =?us-ascii?Q?gLA9FYNZLUUfKazKsdJGprwtMNGoAo0ZMAJd7bbUe9AFSCYcWdNd0fX6nLIq?= =?us-ascii?Q?UrWO8iq769gdMOGQNDPnM4YjbbaMr7yAfU6AJSzMwFSiqNf8b0IrBASZD2Ep?= =?us-ascii?Q?ZFV40zMGNnGkH9je/jJFy28NypYR0qg/fhjxyZGms9FMlQRH1GXzGoLmJnCn?= =?us-ascii?Q?1NUd3LS5Ly6VCHmV4MpuHMl0scIb3HxwOuPaabdSrey/g6bAjPCq15PxHp4D?= =?us-ascii?Q?/hi3wYXpMZECAjuXwdhYBl+flwl6plBa/+P5gd9P9IV4zvcEv8UW6jsXjMmL?= =?us-ascii?Q?dshymZGBLuEKsaTSfgbai6xt1GlmehgO2KJZOYrbgUetdpNNXAs2Rv9rG4aP?= =?us-ascii?Q?5U7iMrmWtEVb1MsvWRmSvKM1tIknXNjVQFMp3Io4qLOswtdbMxcpNUetBq2b?= =?us-ascii?Q?1QVk6PwGT/XQbD8Ya9WoGElXnQKQMZv5mFoQWzvT3TL2OpvFlwJRu2tshDex?= =?us-ascii?Q?uXDuuXLkcJzZlQi89m9HTM2McWYkTs4EasmVZOu7IYGXNCwI0MAMc05eUMSh?= =?us-ascii?Q?puY2K98Ox4r5+KMbsJE+OP+eooB2RK56Ec9rASmu9IB1lwL02D7P/gw60GuN?= =?us-ascii?Q?GHKNLJqJai/wzZCGO2oFdZtGBRIZeY84NrxbCi4sR4dnhqg8sykhWzloHNOL?= =?us-ascii?Q?cKF26ftFUdKsFZyZyosQSKWXk4sRcgUxlfyR2gg8aGrFe9QVn1fk6y2gdh5K?= =?us-ascii?Q?GGt7uQzhhOD9hqBrUCFB/ogoEMM+7Y6LeByJ3WOVGF6NjOn1Mo6i4UETHszy?= =?us-ascii?Q?j6OZolA6YQQWwM4Yz+mXLGHKENJbHHOPqQveu0yc/AUMNnwkdTAh9YTqHvhA?= =?us-ascii?Q?97j1OEQYmCf4sJgb02e4LQLKOOC95i3b5bsb5uv5NmwX4lSJZTWCLqstQupV?= =?us-ascii?Q?PAeP+6ZDlBvxumGP/JXQ0nZ6/z/M6kFS0c2lFygYKDGoyYuX0eZu0mkroIlm?= =?us-ascii?Q?2TTKGbLw7J/2O7bJoLX6JuSepatL3ytbJbIWk60zJ1OhSR9FD3LzY2etdK29?= =?us-ascii?Q?00ZUgIXZuFX8thxhMwXJdPrOcq7a1cJ8d2MmNFxax2d78ilvXGTHYLBp4ZjZ?= =?us-ascii?Q?nAtAa1BtlVo1jwjmc2FUbn01CwBm4d7DS9dCacPt5JhvTBt2iFXdxuZjjATz?= =?us-ascii?Q?E+98xs5xTUSGUNc7VcE4W/AFwZGnb6L6Di9Z1Vmd/emo3b4akAkEbdozx9JN?= =?us-ascii?Q?QY7S4mGe7JbzVc9p8VB3X5vdjmQX3ocevabKruFNJ5xn3ps0crVblNrVQr/Z?= =?us-ascii?Q?hOL/uOhwBO4T8QjMlzz6qT2L/45uBbXac3uB697JfjLdEFtMjw8bvwpQioDv?= =?us-ascii?Q?QFasq5dGMAwAcWQEP8jNPJVZtu2wNPaC1yZDapB9/egJ0jfKVCdR0diJ9Jjl?= =?us-ascii?Q?wchtP/QLsylpn8Gp6Z4Sxpe5Xmy9JqLeS5uPOBbe?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f6d0a57-ffeb-45cc-f52b-08dc0cca6c37 X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6458.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2024 02:11:12.2010 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dfEo6RU8VXRzECK5yPSXb+fwiDmxD8LcloZIup5Krsf8r3XNkP7jHRDYnxZahgNFFUYpu0c3yKtv1zqeLyrFZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4129 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: V1R9ltDTuEUvL0qw8BTugPFtx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=THE4L0DZ; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Sami Mujawar, =C2=A0=C2=A0=C2=A0 Thanks for quick response, update and merge of the patc= h. Yes, I build DynamicTablesPkg for IA32 and X64 using VS2019(tool-chain=20 VS2019) and also using GCC 11.4 (tool-chain GCC). I'll take a look at edk2 CI. Thanks AbduL I'll take a look at edk2 CI and On 03-01-2024 20:24, Sami Mujawar wrote: > Caution: This message originated from an External Source. Use proper=20 > caution when opening attachments, clicking links, or responding. > > > Hi Abdul, > > I have merged this series as d7d4f09ff815..2576cbafec98. > > Now that support for X64 and IA32 is enabled in DynamicTablesPkg, it > would be good to enable that in the edk2 CI. That way we do not > accidently break the builds. > > To enable edk2 CI for AARCH64 using GCC, I had made the change at > https://github.com/tianocore/edk2/blob/master/.azurepipelines/templates/p= r-gate-build-job.yml#L50=20 > > > I am not sure what is required to support X64 and IA32 builds using > VS2019. Can you provide a patch for that, please? > > Also, by any chance have you tried building DynamicTablesPkg with GCC > for X64 and IA32? > > Regards, > > Sami Mujawar > > On 03/01/2024 09:52 am, Abdul Lateef Attar via groups.io wrote: >> From: Abdul Lateef Attar >> >> PR: https://github.com/tianocore/edk2/pull/5209 >> v2: Fix the IA32 compilation errors. >> v1: Fix the X64 compilation errors. >> >> Cc: Pierre Gondois pierre.gondois@arm.com >> Cc: Sami Mujawar sami.mujawar@arm.com >> Cc: Abdul Lateef Attar >> >> Abdul Lateef Attar (2): >> =C2=A0=C2=A0 DynamicTablesPkg: Fix X64 compilation errors >> =C2=A0=C2=A0 DynamicTablesPkg: Fix IA32 compilation errors >> >> =C2=A0 DynamicTablesPkg/DynamicTables.dsc.inc=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 | 17 ++++++++++++----- >> =C2=A0 DynamicTablesPkg/DynamicTablesPkg.dsc=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 7 +++++-- >> =C2=A0 .../Library/Common/AmlLib/AmlLib.inf=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 2 ++ >> =C2=A0 .../Library/Common/AmlLib/CodeGen/AmlCodeGen.c=C2=A0 |=C2=A0 4 ++= -- >> =C2=A0 .../Common/DynamicPlatRepoLib/DynamicPlatRepo.c |=C2=A0 7 ++++--- >> =C2=A0 .../ConfigurationManagerObjectParser.c=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 2 +- >> =C2=A0 .../Library/Common/TableHelperLib/TableHelper.c |=C2=A0 6 ++++-- >> =C2=A0 .../Common/TableHelperLib/TableHelperLib.inf=C2=A0=C2=A0=C2=A0 |= =C2=A0 2 ++ >> =C2=A0 8 files changed, 32 insertions(+), 15 deletions(-) >> > IMPORTANT NOTICE: The contents of this email and any attachments are=20 > confidential and may also be privileged. If you are not the intended=20 > recipient, please notify the sender immediately and do not disclose=20 > the contents to any other person, use it for any purpose, or store or=20 > copy the information in any medium. Thank you. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113111): https://edk2.groups.io/g/devel/message/113111 Mute This Topic: https://groups.io/mt/103499168/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-