From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.14.1635454652474792593 for ; Thu, 28 Oct 2021 13:57:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=Zu2XVRZO; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [10.0.0.19] (c-73-27-179-174.hsd1.fl.comcast.net [73.27.179.174]) by linux.microsoft.com (Postfix) with ESMTPSA id A38F0209F33D; Thu, 28 Oct 2021 13:57:30 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A38F0209F33D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1635454651; bh=zWK5d6SEHAs6WoE9m8MOBpaFlEU/kOH9cM0tqcRMm3I=; h=Date:Subject:From:To:Cc:Reply-To:References:In-Reply-To:From; b=Zu2XVRZOX7P61oJuOrldrskZdn8croRxVAWunWgZN86zMx/lMpO/gBqGsxQXQDatt 3tB8l2UMxTJGlNVOSvvvQwpNqrDm+zCDGX5Zum0tBBJDkUQdCzflp42MdErkTF6n99 jcPQ/J+xwbCH9L7OHltnD95QAgJdLjQPWc1M11kU= Message-ID: <6a56b2f6-b304-c40d-6c8d-ea6a641de047@linux.microsoft.com> Date: Thu, 28 Oct 2021 16:57:29 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [edk2-devel] [PATCH v6 00/52] Consolidate SpiFlashCommonLib instances From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Agyeman Prince , Chasel Chiu , Deepika Kethi Reddy , Eric Dong , Heng Luo , Jeremy Soller , Kathappan Esakkithevar , Liming Gao , Nate DeSimone , Rangasai V Chaganty , Benjamin Doron Reply-To: devel@edk2.groups.io, mikuback@linux.microsoft.com References: <16B24C98D3AEBB49.7726@groups.io> In-Reply-To: <16B24C98D3AEBB49.7726@groups.io> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Fyi, I stopped sending patches at 35/52 to stop safely before the maximum message limit. Patches 36-52 will be sent in 1-2 hours from now. Thanks, Michael On 10/28/2021 4:42 PM, Michael Kubacki wrote: > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 > > SpiFlashCommonLib is duplicated in multiple places across the MinPlatform > design in edk2-platforms. I'm planning to build some additional > functionality on top of SpiFlashCommonLib and, ideally, this duplication > will be consolidated into a single instance usable across all current library > consumers. > > This patch series focuses on consolidating the various SpiFlashCommonLib > instances as agreed upon in https://edk2.groups.io/g/devel/message/71701. > > Read the BZ for more general background around this series. > > I only have an UpXtreme board on hand so maintainers/reviewers of other > board packages should test these changes on those boards. > > V6 changes: > - Changed the name of the new SPI PPI and SPI Protocol to > "PCH_SPI2_PPI" and "PCH_SPI2_PROTOCOL" to differentiate the > interfaces from prior definitions. The previous PPI and > Protocol interfaces are available in IntelSiliconPkg. > - Corresponding PPI and Protocol GUIDs are updated. > - Included changes for the "AspireVn7Dash572G" that was added after > the V5 patch series was sent. > - Rebased the patch series for changes that have happened since the > V5 patch series to resolve merge conflicts. > > V5 changes: > - Added build support for PurleyOpenBoardPkg and WhitleyOpenBoardPkg > (added to edk2-platforms during the lifetime of this patch series). > - Updated KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash to > use the new SPI PPI interface that identifies SPI flash regions > by GUID. > - Added new Reviewed-by replies that came in to existing patches > during v4. > > V4 changes: > - Assigned new GUID values to the PCH SPI PPI and Protocols to > differentiate from previous instances. This was done because > the interface changed to identify SPI flash regions by GUID. > > V3 changes: > - Added support to IntelSiliconPkg to identify flash regions by GUID as > requested in v2 review feedback. > > V2 changes: > - Rebased patch series on current edk2-platforms master (32183bdaa91) > > Note: Previous patch series only received a couple review comments after > being on the mailing list for over 2 months. Please be respectful of > contributors time and efforts and review in a timely manner. > > Cc: Agyeman Prince > Cc: Chasel Chiu > Cc: Deepika Kethi Reddy > Cc: Eric Dong > Cc: Heng Luo > Cc: Jeremy Soller > Cc: Kathappan Esakkithevar > Cc: Liming Gao > Cc: Nate DeSimone > Cc: Rangasai V Chaganty > Cc: Benjamin Doron > Signed-off-by: Michael Kubacki > > Michael Kubacki (52): > CometlakeOpenBoardPkg: Remove redundant IntelSiliconPkg.dec entry > WhiskeylakeOpenBoardPkg: Remove redundant IntelSiliconPkg.dec entry > CometlakeOpenBoardPkg/PeiPolicyUpdateLib: Add missing GUID to INF > IntelSiliconPkg: Add BIOS area base address and size PCDs > IntelSiliconPkg: Add microcode FV PCDs > IntelSiliconPkg: Add PCH SPI PPI > IntelSiliconPkg: Add PCH SPI Protocol > IntelSiliconPkg: Add SpiFlashCommonLib > IntelSiliconPkg: Add SmmSpiFlashCommonLib > IntelSiliconPkg: Add MM SPI FVB services > CometlakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs > KabylakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs > SimicsOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs > TigerlakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs > WhiskeylakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs > CoffeelakeSiliconPkg: Use IntelSiliconPkg BIOS area and ucode PCDs > KabylakeSiliconPkg: Use IntelSiliconPkg BIOS area and ucode PCDs > SimicsIch10Pkg: Use IntelSiliconPkg BIOS area and ucode PCDs > TigerlakeSiliconPkg: Use IntelSiliconPkg BIOS area and ucode PCDs > CometlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib > KabylakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib > SimicsOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib > TigerlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib > WhiskeylakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib > PurleyOpenBoardPkg: Use IntelSiliconPkg SpiFvbServiceSmm > WhitleyOpenBoardPkg: UseIntelSiliconPkg SpiFvbServiceSmm > MinPlatformPkg: Remove SpiFvbService modules > CoffeelakeSiliconPkg: Remove SmmSpiFlashCommonLib > KabylakeSiliconPkg: Remove SmmSpiFlashCommonLib > SimicsIch10Pkg: Remove SmmSpiFlashCommonLib > TigerlakeOpenBoardPkg: Remove SmmSpiFlashCommonLib > MinPlatformPkg: Remove SpiFlashCommonLibNull > PurleyOpenBoardPkg: Add SpiFlashCommonLib.h > KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Add IntelSiliconPkg.dec > CoffeelakeSiliconPkg: Remove PCH SPI PPI and Protocol from package > KabylakeSiliconPkg: Remove PCH SPI PPI and Protocol from package > SimicsIch10Pkg: Remove PCH SPI SMM Protocol from package > TigerlakeSiliconPkg: Remove PCH SPI PPI and Protocol from package > IntelSiliconPkg: Add flash region GUIDs > IntelSiliconPkg: Identify flash regions by GUID > CoffeelakeSiliconPkg/BasePchSpiCommonLib: Identify flash regions by > GUID > CoffeelakeSiliconPkg: Update for SPI2 PPI and Protocol > CometlakeOpenBoardPkg: Remove unnecessary gPchSpiPpiGuid reference > KabylakeSiliconPkg: Identify flash regions by GUID > KabylakeSiliconPkg: Update for SPI2 PPI and Protocol > KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Update for new SPI PPI > API > KabylakeOpenBoardPkg/KabylakeRvp3: Add PeiSerialPortlibSpiFlash to > build > SimicsIch10Pkg/BasePchSpiCommonLib: Identify flash regions by GUID > SimicsIch10Pkg/PchSpiSmm: Update for SPI2 Protocol > TigerlakeSiliconPkg/BasePchSpiCommonLib: Identify flash regions by > GUID > TigerlakeSiliconPkg/SpiSmm: Update for SPI2 Protocol > WhiskeylakeOpenBoardPkg: Update for SPI2 PPI > > Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/PeiSerialPortLibSpiFlash.c | 46 +-- > Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiSpiLib/PchSpi.c | 10 +- > Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/BasePchSpiCommonLib/SpiCommon.c | 192 +++++++++---- > Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiFlashCommon.c | 196 ------------- > Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiFlashCommonSmmLib.c | 54 ---- > Silicon/Intel/CoffeelakeSiliconPkg/Pch/Spi/Smm/PchSpi.c | 10 +- > {Platform/Intel/MinPlatformPkg => Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/FvbInfo.c | 0 > {Platform/Intel/MinPlatformPkg => Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServiceCommon.c | 4 +- > {Platform/Intel/MinPlatformPkg => Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServiceMm.c | 8 +- > {Platform/Intel/MinPlatformPkg => Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServiceStandaloneMm.c | 0 > {Platform/Intel/MinPlatformPkg => Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServiceTraditionalMm.c | 0 > Platform/Intel/TigerlakeOpenBoardPkg/Library/SmmSpiFlashCommonLib/SpiFlashCommonSmmLib.c => Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiFlashCommonLib.c | 16 +- > {Platform/Intel/TigerlakeOpenBoardPkg => Silicon/Intel/IntelSiliconPkg}/Library/SmmSpiFlashCommonLib/SpiFlashCommon.c | 33 ++- > {Platform/Intel/MinPlatformPkg/Flash => Silicon/Intel/IntelSiliconPkg}/Library/SpiFlashCommonLibNull/SpiFlashCommonLibNull.c | 12 +- > Silicon/Intel/KabylakeSiliconPkg/Hsti/Dxe/SecureMemoryMapConfiguration.c | 108 ++++++- > Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.c | 10 +- > Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiFlashCommon.c | 196 ------------- > Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiFlashCommonSmmLib.c | 54 ---- > Silicon/Intel/KabylakeSiliconPkg/Pch/LibraryPrivate/BasePchSpiCommonLib/SpiCommon.c | 188 +++++++++---- > Silicon/Intel/KabylakeSiliconPkg/Pch/Spi/Smm/PchSpi.c | 8 +- > Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonLib/SpiFlashCommon.c | 194 ------------- > Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonLib/SpiFlashCommonSmmLib.c | 54 ---- > Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/SpiCommon.c | 189 +++++++++---- > Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.c | 8 +- > Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/LibraryPrivate/BaseSpiCommonLib/SpiCommon.c | 224 +++++++++++---- > Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/Spi.c | 10 +- > Platform/Intel/CometlakeOpenBoardPkg/BiosInfo/BiosInfo.inf | 4 +- > Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/Include/Fdf/FlashMapInclude.fdf | 4 +- > Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 7 +- > Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf | 38 +-- > Platform/Intel/CometlakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLib/PeiPolicyUpdateLib.inf | 3 +- > Platform/Intel/CometlakeOpenBoardPkg/Policy/PolicyInitDxe/PolicyInitDxe.inf | 4 +- > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/Fdf/FlashMapInclude.fdf | 4 +- > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg.dsc | 7 +- > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg.fdf | 40 +-- > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/PeiSiliconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf | 4 +- > Platform/Intel/KabylakeOpenBoardPkg/BiosInfo/BiosInfo.inf | 4 +- > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/Fdf/FlashMapInclude.fdf | 4 +- > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 7 +- > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf | 40 +-- > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/Fdf/FlashMapInclude.fdf | 4 +- > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 9 +- > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf | 40 +-- > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/PeiSiliconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf | 4 +- > Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/PeiSerialPortLibSpiFlash.inf | 4 +- > Platform/Intel/MinPlatformPkg/Include/Library/SpiFlashCommonLib.h | 98 ------- > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 2 - > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 6 - > Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/OpenBoardPkg.dsc | 2 +- > Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/OpenBoardPkg.fdf | 2 +- > Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/OpenBoardPkg.dsc | 4 +- > Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/OpenBoardPkg.fdf | 5 +- > Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 6 +- > Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf | 2 +- > Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf.inc | 8 +- > Platform/Intel/TigerlakeOpenBoardPkg/BiosInfo/BiosInfo.inf | 8 +- > Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Include/Fdf/FlashMapInclude.fdf | 4 +- > Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc | 7 +- > Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fdf | 40 +-- > Platform/Intel/WhiskeylakeOpenBoardPkg/BiosInfo/BiosInfo.inf | 4 +- > Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLib/PeiPolicyUpdateLib.inf | 3 +- > Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/PolicyInitDxe/PolicyInitDxe.inf | 4 +- > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/Fdf/FlashMapInclude.fdf | 4 +- > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/BoardInitLib/PeiMultiBoardInitPreMemLib.inf | 2 +- > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 7 +- > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf | 38 +-- > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Include/Fdf/FlashMapInclude.fdf | 4 +- > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc | 7 +- > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.fdf | 38 +-- > {Silicon/Intel/SimicsIch10Pkg => Platform/Intel/WhitleyOpenBoardPkg}/Include/Library/SpiFlashCommonLib.h | 2 +- > Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc | 2 +- > Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.fdf | 5 +- > Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPolicyLib.inf | 4 +- > Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Private/Library/PchSpiCommonLib.h | 60 ++-- > Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Protocol/Spi.h | 295 -------------------- > Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.inf | 3 +- > Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/BasePchSpiCommonLib/BasePchSpiCommonLib.inf | 13 + > Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SmmSpiFlashCommonLib.inf | 51 ---- > Silicon/Intel/CoffeelakeSiliconPkg/Pch/Spi/Smm/PchSpiSmm.inf | 3 +- > Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec | 8 - > {Platform/Intel/MinPlatformPkg => Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServiceCommon.h | 0 > {Platform/Intel/MinPlatformPkg => Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServiceMm.h | 0 > {Platform/Intel/MinPlatformPkg => Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServiceSmm.inf | 6 +- > {Platform/Intel/MinPlatformPkg => Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServiceStandaloneMm.inf | 6 +- > Silicon/Intel/IntelSiliconPkg/Include/Guid/FlashRegion.h | 45 +++ > Silicon/Intel/{CoffeelakeSiliconPkg/Pch => IntelSiliconPkg}/Include/Library/SpiFlashCommonLib.h | 2 +- > Silicon/Intel/{CoffeelakeSiliconPkg/Pch => IntelSiliconPkg}/Include/Ppi/Spi.h | 4 +- > Silicon/Intel/IntelSiliconPkg/Include/Ppi/Spi2.h | 31 ++ > Silicon/Intel/{TigerlakeSiliconPkg => IntelSiliconPkg}/Include/Protocol/Spi.h | 0 > Silicon/Intel/{SimicsIch10Pkg/Include/Protocol/Spi.h => IntelSiliconPkg/Include/Protocol/Spi2.h} | 106 ++++--- > Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 45 +++ > Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc | 17 ++ > {Platform/Intel/TigerlakeOpenBoardPkg => Silicon/Intel/IntelSiliconPkg}/Library/SmmSpiFlashCommonLib/SmmSpiFlashCommonLib.inf | 26 +- > {Platform/Intel/MinPlatformPkg/Flash => Silicon/Intel/IntelSiliconPkg}/Library/SpiFlashCommonLibNull/SpiFlashCommonLibNull.inf | 3 +- > Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPolicyLib.inf | 4 +- > Silicon/Intel/KabylakeSiliconPkg/Hsti/Dxe/HstiSiliconDxe.h | 2 +- > Silicon/Intel/KabylakeSiliconPkg/Hsti/Dxe/HstiSiliconDxe.inf | 12 +- > Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Library/SpiFlashCommonLib.h | 98 ------- > Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Ppi/Spi.h | 26 -- > Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Protocol/Spi.h | 293 ------------------- > Silicon/Intel/KabylakeSiliconPkg/Pch/IncludePrivate/Library/PchSpiCommonLib.h | 68 ++--- > Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.inf | 3 +- > Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SmmSpiFlashCommonLib.inf | 53 ---- > Silicon/Intel/KabylakeSiliconPkg/Pch/LibraryPrivate/BasePchSpiCommonLib/BasePchSpiCommonLib.inf | 11 + > Silicon/Intel/KabylakeSiliconPkg/Pch/Spi/Smm/PchSpi.h | 2 +- > Silicon/Intel/KabylakeSiliconPkg/Pch/Spi/Smm/PchSpiSmm.inf | 3 +- > Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec | 13 +- > Silicon/Intel/SimicsIch10Pkg/Ich10Pkg.dec | 11 - > Silicon/Intel/SimicsIch10Pkg/IncludePrivate/Library/PchSpiCommonLib.h | 68 ++--- > Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonLib/SmmSpiFlashCommonLib.inf | 50 ---- > Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/BasePchSpiCommonLib.inf | 16 +- > Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.h | 2 +- > Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpiSmm.inf | 3 +- > Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/IncludePrivate/Library/SpiCommonLib.h | 60 ++-- > Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/LibraryPrivate/BaseSpiCommonLib/BaseSpiCommonLib.inf | 19 +- > Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/SpiSmm.inf | 3 +- > Silicon/Intel/TigerlakeSiliconPkg/Pch/PchInit/Dxe/PchInitDxeTgl.inf | 1 + > Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec | 8 - > 118 files changed, 1450 insertions(+), 2476 deletions(-) > delete mode 100644 Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiFlashCommon.c > delete mode 100644 Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiFlashCommonSmmLib.c > rename {Platform/Intel/MinPlatformPkg => Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/FvbInfo.c (100%) > rename {Platform/Intel/MinPlatformPkg => Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServiceCommon.c (96%) > rename {Platform/Intel/MinPlatformPkg => Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServiceMm.c (94%) > rename {Platform/Intel/MinPlatformPkg => Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServiceStandaloneMm.c (100%) > rename {Platform/Intel/MinPlatformPkg => Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServiceTraditionalMm.c (100%) > rename Platform/Intel/TigerlakeOpenBoardPkg/Library/SmmSpiFlashCommonLib/SpiFlashCommonSmmLib.c => Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiFlashCommonLib.c (75%) > rename {Platform/Intel/TigerlakeOpenBoardPkg => Silicon/Intel/IntelSiliconPkg}/Library/SmmSpiFlashCommonLib/SpiFlashCommon.c (84%) > rename {Platform/Intel/MinPlatformPkg/Flash => Silicon/Intel/IntelSiliconPkg}/Library/SpiFlashCommonLibNull/SpiFlashCommonLibNull.c (83%) > delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiFlashCommon.c > delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiFlashCommonSmmLib.c > delete mode 100644 Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonLib/SpiFlashCommon.c > delete mode 100644 Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonLib/SpiFlashCommonSmmLib.c > delete mode 100644 Platform/Intel/MinPlatformPkg/Include/Library/SpiFlashCommonLib.h > rename {Silicon/Intel/SimicsIch10Pkg => Platform/Intel/WhitleyOpenBoardPkg}/Include/Library/SpiFlashCommonLib.h (96%) > delete mode 100644 Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Protocol/Spi.h > delete mode 100644 Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SmmSpiFlashCommonLib.inf > rename {Platform/Intel/MinPlatformPkg => Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServiceCommon.h (100%) > rename {Platform/Intel/MinPlatformPkg => Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServiceMm.h (100%) > rename {Platform/Intel/MinPlatformPkg => Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServiceSmm.inf (88%) > rename {Platform/Intel/MinPlatformPkg => Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServiceStandaloneMm.inf (88%) > create mode 100644 Silicon/Intel/IntelSiliconPkg/Include/Guid/FlashRegion.h > rename Silicon/Intel/{CoffeelakeSiliconPkg/Pch => IntelSiliconPkg}/Include/Library/SpiFlashCommonLib.h (96%) > rename Silicon/Intel/{CoffeelakeSiliconPkg/Pch => IntelSiliconPkg}/Include/Ppi/Spi.h (85%) > create mode 100644 Silicon/Intel/IntelSiliconPkg/Include/Ppi/Spi2.h > rename Silicon/Intel/{TigerlakeSiliconPkg => IntelSiliconPkg}/Include/Protocol/Spi.h (100%) > rename Silicon/Intel/{SimicsIch10Pkg/Include/Protocol/Spi.h => IntelSiliconPkg/Include/Protocol/Spi2.h} (76%) > rename {Platform/Intel/TigerlakeOpenBoardPkg => Silicon/Intel/IntelSiliconPkg}/Library/SmmSpiFlashCommonLib/SmmSpiFlashCommonLib.inf (65%) > rename {Platform/Intel/MinPlatformPkg/Flash => Silicon/Intel/IntelSiliconPkg}/Library/SpiFlashCommonLibNull/SpiFlashCommonLibNull.inf (91%) > delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Library/SpiFlashCommonLib.h > delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Ppi/Spi.h > delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Protocol/Spi.h > delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SmmSpiFlashCommonLib.inf > delete mode 100644 Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonLib/SmmSpiFlashCommonLib.inf >