From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.zytor.com (terminus.zytor.com [65.50.211.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9662521D046BE for ; Mon, 18 Sep 2017 10:49:04 -0700 (PDT) Received: from [10.26.0.110] (corporativo.static.gvt.net.br [177.135.97.54] (may be forged)) (authenticated bits=0) by mail.zytor.com (8.15.2/8.15.2) with ESMTPSA id v8IHnqsG009946 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Mon, 18 Sep 2017 10:49:54 -0700 To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" Cc: "Kinney, Michael D" , "Gao, Liming" , Laszlo Ersek , "Zeng, Star" , "Yao, Jiewen" References: <734D49CCEBEEF84792F5B80ED585239D5BA45A4E@SHSMSX151.ccr.corp.intel.com> From: Paulo Alcantara Message-ID: <6a891c1a-796d-0ad1-7304-c3e8c482b74b@zytor.com> Date: Mon, 18 Sep 2017 14:49:46 -0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BA45A4E@SHSMSX151.ccr.corp.intel.com> Subject: Re: [PATCH v2 0/3] UDF partition driver fix X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2017 17:49:04 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Ruiyu, On 9/18/2017 1:52 AM, Ni, Ruiyu wrote: > Paulo, > Could you please paste a "map -r" output on a CDROM which > contains Eltorito volume? > I want to confirm that the result is expected. With UdfDxe driver disabled in OVMF: >Mapping table > FS0: Alias(s):CD0c65535a1:;BLK2: > PciRoot(0x0)/Pci(0x1F,0x2)/Sata(0x2,0xFFFF,0x0)/CDROM(0x1) > BLK0: Alias(s): > PciRoot(0x0)/Pci(0x1F,0x2)/Sata(0x2,0xFFFF,0x0) > BLK1: Alias(s): > PciRoot(0x0)/Pci(0x1F,0x2)/Sata(0x2,0xFFFF,0x0)/CDROM(0x0) > BLK3: Alias(s): > PciRoot(0x0)/Pci(0x1F,0x2)/Sata(0x2,0xFFFF,0x0)/VenMedia(C5BD4D42-1A76-4996-8956-73CDA326CD0A) With UdfDxe driver enabled in OVMF: > Mapping table > FS0: Alias(s):CD0c65535a1:;BLK2: > PciRoot(0x0)/Pci(0x1F,0x2)/Sata(0x2,0xFFFF,0x0)/CDROM(0x1) > FS1: Alias(s):F0c65535a:;BLK3: > PciRoot(0x0)/Pci(0x1F,0x2)/Sata(0x2,0xFFFF,0x0)/VenMedia(C5BD4D42-1A76-4996-8956-73CDA326CD0A) > BLK0: Alias(s): > PciRoot(0x0)/Pci(0x1F,0x2)/Sata(0x2,0xFFFF,0x0) > BLK1: Alias(s): > PciRoot(0x0)/Pci(0x1F,0x2)/Sata(0x2,0xFFFF,0x0)/CDROM(0x0) Thanks! Paulo > > Thanks/Ray > >> -----Original Message----- >> From: Paulo Alcantara [mailto:pcacjr@zytor.com] >> Sent: Sunday, September 17, 2017 9:13 PM >> To: edk2-devel@lists.01.org >> Cc: Paulo Alcantara ; Kinney, Michael D >> ; Gao, Liming ; Laszlo >> Ersek ; Ni, Ruiyu ; Zeng, Star >> ; Yao, Jiewen >> Subject: [PATCH v2 0/3] UDF partition driver fix >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=707 >> >> Hi, >> >> This patchset fixes a bug in Partition driver that UDF partitions occupied the >> entire disk space instead of using LVD space only. >> >> BTW, I've only tested it under OVMF and built it with GCC only. That would >> be appreciable if someone could build with other toolchains and see if this >> doesn't break. >> >> I used a Windows 10 ISO image with UdfDxe disabled and enabled. The `map >> -r` output seemed OK. No breakage when booting an OS off an ElTorito >> partition from an UDF bridge disk. >> >> v1->v2: >> - Followed Laszlo's suggestions to submit a proper patchset. Thanks! >> - As I'm still waiting for Ruiyu and Star to test this fix, I took >> advantage of it and did some code cleanups :-) >> >> Repo: https://github.com/pcacjr/edk2.git >> Branch: udf-partition-fix-v2 >> >> Cc: Michael D Kinney >> Cc: Liming Gao >> Cc: Laszlo Ersek >> Cc: Ruiyu Ni >> Cc: Star Zeng >> Cc: Jiewen Yao >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Reported-by: Ruiyu Ni >> Signed-off-by: Paulo Alcantara >> --- >> >> Paulo Alcantara (3): >> MdePkg: Add UDF volume structure definitions >> MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition >> MdeModulePkg/UdfDxe: Rework driver to support PartitionDxe changes >> >> MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c | 323 >> +++++++++++- >> MdeModulePkg/Universal/Disk/UdfDxe/File.c | 13 +- >> MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 515 >> ++++++++------------ >> MdeModulePkg/Universal/Disk/UdfDxe/Udf.c | 7 - >> MdeModulePkg/Universal/Disk/UdfDxe/Udf.h | 88 +--- >> MdePkg/Include/IndustryStandard/Udf.h | 63 +++ >> 6 files changed, 566 insertions(+), 443 deletions(-) >> >> -- >> 2.11.0 > >