From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: ipark@nvidia.com, devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] ArmPlatformPkg/PL011UartLib: Add PCD for FIFO depth
Date: Mon, 8 Jun 2020 18:44:51 +0200 [thread overview]
Message-ID: <6a925a5e-4de0-99dd-7dce-00cc00628315@arm.com> (raw)
In-Reply-To: <1266.1591627626574447386@groups.io>
On 6/8/20 4:47 PM, Irene Park via Groups.Io wrote:
> Hi Ard,
> I feel bad that I confused you. I'll update the commit message later.
> SBSA spec doesn't "mandate" that the optional registers such as PID2 are
> present in a UART compliant to PL011.
> Therefore this register access to PID2 will generate a fault onto SOC
> when its UART doesn't provide such registers.
> PID2 is used to determine the FIFO depth in the library so I'd like to
> propose a new PCD to define a FIFO depth.
I'd prefer it if we could change the existing code so that the register
is never checked if
gEfiMdePkgTokenSpaceGuid.PcdUartDefaultReceiveFifoDepth is set to a
value > 0
prev parent reply other threads:[~2020-06-08 16:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-06 3:23 [PATCH] ArmPlatformPkg/PL011UartLib: Add PCD for FIFO depth Irene Park
2020-06-06 3:24 ` Irene Park
2020-06-08 6:06 ` Irene Park
2020-06-08 8:29 ` [edk2-devel] " Ard Biesheuvel
2020-06-08 14:47 ` Irene Park
2020-06-08 16:44 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a925a5e-4de0-99dd-7dce-00cc00628315@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox