From: Jaben Carsey <jaben.carsey@intel.com>
To: edk2-devel@lists.01.org
Cc: Yonghong Zhu <yonghong.zhu@intel.com>, Liming Gao <liming.gao@intel.com>
Subject: [PATCH v1 3/5] BaseTools: Expression - change from series of if to elif
Date: Tue, 13 Mar 2018 16:11:33 -0700 [thread overview]
Message-ID: <6ac40f3a1349fa1ae00458f532bbc1138b0f536b.1520982577.git.jaben.carsey@intel.com> (raw)
In-Reply-To: <cover.1520982577.git.jaben.carsey@intel.com>
In-Reply-To: <cover.1520982577.git.jaben.carsey@intel.com>
since the first character of the string cannot be found by multiple if
statements, use elif to optomize the behavior.
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
---
BaseTools/Source/Python/Common/Expression.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/BaseTools/Source/Python/Common/Expression.py b/BaseTools/Source/Python/Common/Expression.py
index c7037dd0d00b..85c1ce9bbc09 100644
--- a/BaseTools/Source/Python/Common/Expression.py
+++ b/BaseTools/Source/Python/Common/Expression.py
@@ -93,18 +93,18 @@ def SplitPcdValueString(String):
for i, ch in enumerate(String):
if ch == '(':
InParenthesis += 1
- if ch == ')':
+ elif ch == ')':
if InParenthesis:
InParenthesis -= 1
else:
raise BadExpression(ERR_STRING_TOKEN % Item)
- if ch == '"' and not InSingleQuote:
+ elif ch == '"' and not InSingleQuote:
if String[i-1] != '\\':
InDoubleQuote = not InDoubleQuote
- if ch == "'" and not InDoubleQuote:
+ elif ch == "'" and not InDoubleQuote:
if String[i-1] != '\\':
InSingleQuote = not InSingleQuote
- if ch == ',':
+ elif ch == ',':
if InParenthesis or InSingleQuote or InDoubleQuote:
Item += String[i]
continue
--
2.16.2.windows.1
next prev parent reply other threads:[~2018-03-13 23:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 23:11 [PATCH v1 0/5] BaseTools - some simple cleanups for BaseTools Jaben Carsey
2018-03-13 23:11 ` [PATCH v1 1/5] BaseTools: Expression - remove redundant variable Jaben Carsey
2018-03-13 23:11 ` [PATCH v1 2/5] BaseTools: Expression refactor function Jaben Carsey
2018-03-13 23:11 ` Jaben Carsey [this message]
2018-03-13 23:11 ` [PATCH v1 4/5] BaseTools: Expression - remove variable Jaben Carsey
2018-03-13 23:11 ` [PATCH v1 5/5] BaseTools: RangeExpression - remove unused variable Jaben Carsey
2018-03-16 6:52 ` [PATCH v1 0/5] BaseTools - some simple cleanups for BaseTools Zhu, Yonghong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ac40f3a1349fa1ae00458f532bbc1138b0f536b.1520982577.git.jaben.carsey@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox