public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io, wei6.xu@intel.com
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Sami Mujawar <sami.mujawar@arm.com>, Ray Ni <ray.ni@intel.com>
Subject: Re: [edk2-devel] [PATCH 0/2] Add Platform Hook Lib into StandaloneMmCore
Date: Fri, 27 Oct 2023 12:08:49 -0400	[thread overview]
Message-ID: <6add8265-f950-404c-be10-8a8bd8763af7@linux.microsoft.com> (raw)
In-Reply-To: <cover.1698375369.git.wei6.xu@intel.com>

This allows ambiguous "platform" code in the critical path of the MM 
core. Is this necessary?

Do you need this for one feature that others might too and can be 
abstracted? Or, do you plan to perform an unknown and arbitrary number 
of changes behind the hook over time?

Thanks,
Michael

On 10/26/2023 11:28 PM, Xu, Wei6 wrote:
> This patch set is to add StandaloneMmCorePlatformHookLib into StandaloneMmCore.
> 
> This library class defines a set of platform hooks called by the Standalone Mm Core. With this library, platform can perform specific tasks before and after invoking registered MMI handlers.
> We need this library to implement our feature.
> 
> PR: https://github.com/tianocore/edk2/pull/4949
> 
> 
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> 
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> 
> Cc: Ray Ni <ray.ni@intel.com>
> 
> 
> Wei6 Xu (2):
>    StandaloneMmPkg: Add Standalone Mm Core platform hook lib.
>    StandaloneMmPkg/Core: Consumes Standalone Mm Core Platform Hook Lib.
> 
>   StandaloneMmPkg/Core/StandaloneMmCore.c       |  7 ++-
>   .../StandaloneMmCorePlatformHookLibNull.c     | 45 +++++++++++++++++++
>   StandaloneMmPkg/Core/StandaloneMmCore.h       |  1 +
>   StandaloneMmPkg/Core/StandaloneMmCore.inf     |  1 +
>   .../Library/StandaloneMmCorePlatformHookLib.h | 44 ++++++++++++++++++
>   .../StandaloneMmCorePlatformHookLibNull.inf   | 30 +++++++++++++
>   StandaloneMmPkg/StandaloneMmPkg.dec           |  4 ++
>   StandaloneMmPkg/StandaloneMmPkg.dsc           |  2 +
>   8 files changed, 133 insertions(+), 1 deletion(-)
>   create mode 100644 StandaloneMmPkg/Library/StandaloneMmCorePlatformHookLibNull/StandaloneMmCorePlatformHookLibNull.c
>   create mode 100644 StandaloneMmPkg/Include/Library/StandaloneMmCorePlatformHookLib.h
>   create mode 100644 StandaloneMmPkg/Library/StandaloneMmCorePlatformHookLibNull/StandaloneMmCorePlatformHookLibNull.inf
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110220): https://edk2.groups.io/g/devel/message/110220
Mute This Topic: https://groups.io/mt/102214566/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  parent reply	other threads:[~2023-10-27 16:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-27  3:28 [edk2-devel] [PATCH 0/2] Add Platform Hook Lib into StandaloneMmCore Xu, Wei6
2023-10-27  3:28 ` [edk2-devel] [PATCH 1/2] StandaloneMmPkg: Add Standalone Mm Core platform hook lib Xu, Wei6
2023-10-27  3:28 ` [edk2-devel] [PATCH 2/2] StandaloneMmPkg/Core: Consumes Standalone Mm Core Platform Hook Lib Xu, Wei6
2023-10-27 16:08 ` Michael Kubacki [this message]
2023-10-28 14:03   ` [edk2-devel] [PATCH 0/2] Add Platform Hook Lib into StandaloneMmCore Laszlo Ersek
2023-10-30  0:52     ` Xu, Wei6
2023-10-30 19:27     ` Michael Kubacki
2023-10-31  1:18       ` Xu, Wei6
2023-10-31  1:40         ` Michael Kubacki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6add8265-f950-404c-be10-8a8bd8763af7@linux.microsoft.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox