From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E83219418D0 for ; Fri, 27 Oct 2023 16:08:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=s+VA/eyKIFv9FnVRE5lRQTCtH/Lv/nCZ6b57DF5JLJY=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698422932; v=1; b=jxW+NcPDawf/NNNuuuqzlncZA9MeiL+qzJoHZPLdJaBJt+1qVTcwPUGBrbV5D8GRLeCBSJgK il8nyo8H8UyJlgVpqCidQbERckfmlwFAwHlwLQECjzL0maygKBpbHRPlD8kQo4OzL5UwAmKwLYf dxO0aBig9LmxtMeT/kgEbjEY= X-Received: by 127.0.0.2 with SMTP id LWBvYY7687511xcVtID3klew; Fri, 27 Oct 2023 09:08:52 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.10936.1698422931943816019 for ; Fri, 27 Oct 2023 09:08:52 -0700 X-Received: from [192.168.4.22] (unknown [47.201.241.95]) by linux.microsoft.com (Postfix) with ESMTPSA id C462920B74C0; Fri, 27 Oct 2023 09:08:50 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C462920B74C0 Message-ID: <6add8265-f950-404c-be10-8a8bd8763af7@linux.microsoft.com> Date: Fri, 27 Oct 2023 12:08:49 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH 0/2] Add Platform Hook Lib into StandaloneMmCore To: devel@edk2.groups.io, wei6.xu@intel.com Cc: Ard Biesheuvel , Sami Mujawar , Ray Ni References: From: "Michael Kubacki" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: SnmcCeGJz6emOYNBMBoUYJMix7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=jxW+NcPD; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io This allows ambiguous "platform" code in the critical path of the MM=20 core. Is this necessary? Do you need this for one feature that others might too and can be=20 abstracted? Or, do you plan to perform an unknown and arbitrary number=20 of changes behind the hook over time? Thanks, Michael On 10/26/2023 11:28 PM, Xu, Wei6 wrote: > This patch set is to add StandaloneMmCorePlatformHookLib into StandaloneM= mCore. >=20 > This library class defines a set of platform hooks called by the Standalo= ne Mm Core. With this library, platform can perform specific tasks before a= nd after invoking registered MMI handlers. > We need this library to implement our feature. >=20 > PR: https://github.com/tianocore/edk2/pull/4949 >=20 >=20 >=20 > Cc: Ard Biesheuvel >=20 > Cc: Sami Mujawar >=20 > Cc: Ray Ni >=20 >=20 > Wei6 Xu (2): > StandaloneMmPkg: Add Standalone Mm Core platform hook lib. > StandaloneMmPkg/Core: Consumes Standalone Mm Core Platform Hook Lib. >=20 > StandaloneMmPkg/Core/StandaloneMmCore.c | 7 ++- > .../StandaloneMmCorePlatformHookLibNull.c | 45 +++++++++++++++++++ > StandaloneMmPkg/Core/StandaloneMmCore.h | 1 + > StandaloneMmPkg/Core/StandaloneMmCore.inf | 1 + > .../Library/StandaloneMmCorePlatformHookLib.h | 44 ++++++++++++++++++ > .../StandaloneMmCorePlatformHookLibNull.inf | 30 +++++++++++++ > StandaloneMmPkg/StandaloneMmPkg.dec | 4 ++ > StandaloneMmPkg/StandaloneMmPkg.dsc | 2 + > 8 files changed, 133 insertions(+), 1 deletion(-) > create mode 100644 StandaloneMmPkg/Library/StandaloneMmCorePlatformHook= LibNull/StandaloneMmCorePlatformHookLibNull.c > create mode 100644 StandaloneMmPkg/Include/Library/StandaloneMmCorePlat= formHookLib.h > create mode 100644 StandaloneMmPkg/Library/StandaloneMmCorePlatformHook= LibNull/StandaloneMmCorePlatformHookLibNull.inf >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110220): https://edk2.groups.io/g/devel/message/110220 Mute This Topic: https://groups.io/mt/102214566/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-