From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Rebecca Cran <rebecca@bsdio.com>, devel@edk2.groups.io
Cc: Jordan Justen <jordan.l.justen@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: Re: [PATCH v3 1/1] OvmfPkg: Add QemuFwCfgLibNull
Date: Mon, 4 May 2020 13:45:42 +0200 [thread overview]
Message-ID: <6ae108da-a543-58d0-6b3c-3be6f07ce22f@redhat.com> (raw)
In-Reply-To: <20200503230910.26783-1-rebecca@bsdio.com>
On 5/4/20 1:09 AM, Rebecca Cran wrote:
> Add a null implementation library for QemuFwCfgLib, in order to
> support building PciHostBridgeLib for bhyve.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> I think I've addressed all previous review feedback this time.
>
> .../Library/QemuFwCfgLib/QemuFwCfgLibNull.inf | 30 +++
> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNull.c | 209 ++++++++++++++++++
> 2 files changed, 239 insertions(+)
> create mode 100644 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibNull.inf
> create mode 100644 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNull.c
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
next prev parent reply other threads:[~2020-05-04 11:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-03 23:09 [PATCH v3 1/1] OvmfPkg: Add QemuFwCfgLibNull Rebecca Cran
2020-05-04 11:45 ` Philippe Mathieu-Daudé [this message]
2020-05-05 17:03 ` [edk2-devel] " Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ae108da-a543-58d0-6b3c-3be6f07ce22f@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox