From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web10.4278.1588592747324133008 for ; Mon, 04 May 2020 04:45:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=fJRmsol8; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588592746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UL+CO088Gg06Uz38oGG34sgdKOm2EwmH07n9L1JJRPM=; b=fJRmsol8Zlh3ZH0Bs3vgHan1uO0S/5rVMpTw0F5A4+1SZbhDC4z/DbHKwfTkWgnXeUBCFD hcCHy43Y/69JS5b3Bpx0JrON0KbfgBHyDYSgJJBUSAwZjZdZGvRVyw1c+4xYaayXbP6FSA ySxH/ZRol00KPRB0XQfFrSj4FQ3Bvgc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-177-tmCjF36JMhm0qP2e4e-PFQ-1; Mon, 04 May 2020 07:45:44 -0400 X-MC-Unique: tmCjF36JMhm0qP2e4e-PFQ-1 Received: by mail-wr1-f70.google.com with SMTP id x8so1847075wrl.16 for ; Mon, 04 May 2020 04:45:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=P/cy8vt+664OTI+0cNrSXk3H03PQh/KIp9/TjdjzsXc=; b=AcwmdyNWnsxHwrepC652y7xluGxierBuTbWsaA4KfmVj/GRRoMEZed3KBbWfk89R9k YWNIqhhQh66g9IOLBXdw4nVHTMQZHmHasQgTbKd50bNt0KvlROW9d26+roN2DKP0P/t8 cnwACASyDTwV0/LWE9k0b/GSdMy44mIzmfrRqu0fwoEps4BfZhIHXOXmhjiIYOu3GPEa YxXD6d/pix5dNjM/k7RIcdDitASGpzv+aUsL97GrHmi+AMwoqHOgrrK99B1mD+Mgk8UX C8Zfg7ZTjclLa/DdTSPbNo1QUBOOnEHFIXebV51m6E0UrfRvHGMNhozXWgJtJ9vvNJrb /S5A== X-Gm-Message-State: AGi0PuaJL23lUbtbhe8Xh5Iq4LFjyHW2XZFof0Px6wMF6H86iEdxTHMP ZQ9+yWb39ZSH+ILrpAq+KHSvPXh2dI9FACEuo5Y3uwMw3TUQOz3De3EuvVEqA4bqZE9ixXUSzbQ MgSu+0SKyrC/H+A== X-Received: by 2002:adf:9447:: with SMTP id 65mr7153312wrq.331.1588592743440; Mon, 04 May 2020 04:45:43 -0700 (PDT) X-Google-Smtp-Source: APiQypJgTpgOSeRZRVDBi8PVPdjJXhLQ/5b8sAVtSou9Y82qcWbhhZx01jY8JkutU7Flin/C7pY1jg== X-Received: by 2002:adf:9447:: with SMTP id 65mr7153300wrq.331.1588592743243; Mon, 04 May 2020 04:45:43 -0700 (PDT) Return-Path: Received: from [192.168.1.39] (26.red-88-21-207.staticip.rima-tde.net. [88.21.207.26]) by smtp.gmail.com with ESMTPSA id 88sm227507wrq.77.2020.05.04.04.45.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 May 2020 04:45:42 -0700 (PDT) Subject: Re: [PATCH v3 1/1] OvmfPkg: Add QemuFwCfgLibNull To: Rebecca Cran , devel@edk2.groups.io Cc: Jordan Justen , Laszlo Ersek , Ard Biesheuvel References: <20200503230910.26783-1-rebecca@bsdio.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <6ae108da-a543-58d0-6b3c-3be6f07ce22f@redhat.com> Date: Mon, 4 May 2020 13:45:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200503230910.26783-1-rebecca@bsdio.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 5/4/20 1:09 AM, Rebecca Cran wrote: > Add a null implementation library for QemuFwCfgLib, in order to > support building PciHostBridgeLib for bhyve. >=20 > Signed-off-by: Rebecca Cran > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Philippe Mathieu-Daud=C3=A9 > --- > I think I've addressed all previous review feedback this time. >=20 > .../Library/QemuFwCfgLib/QemuFwCfgLibNull.inf | 30 +++ > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNull.c | 209 ++++++++++++++++++ > 2 files changed, 239 insertions(+) > create mode 100644 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibNull.inf > create mode 100644 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNull.c Reviewed-by: Philippe Mathieu-Daude