From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by mx.groups.io with SMTP id smtpd.web10.30163.1620645217013764445 for ; Mon, 10 May 2021 04:13:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=niilKzA1; spf=pass (domain: akeo.ie, ip: 209.85.221.47, mailfrom: pete@akeo.ie) Received: by mail-wr1-f47.google.com with SMTP id d11so16176259wrw.8 for ; Mon, 10 May 2021 04:13:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EdzONGIZhlDijIFOOZacH7XFfFT/aVos65rwfInGk4s=; b=niilKzA1VcAyn8DU4v7Ok9HHctw+mgx4E5NVa7VL2zVGIwSjqIisulGaAxAiQP+d1m WmWbj1JwnwDs1yRoR/qjkAHuQH52kypGUQJ6fGXnoJ3Kfw9qIRlx6t6OfpJjPGC+2LQk P+kPYz/0KXNmxR1xEWBOFQqZ1HR+lx+b0xtO8B1j6hvHk2TalkxDPkJ1FBiFb7OxlWUp YXjXPv9sya6c5m6bU1rSTr7FJ65SpelwLr52Zm3HVD7m5fV/lTt569p4qI55szTUZwx9 zuWMgKlA5KiGHh6Ccgd2WRuAN2Bqxl/4uUOWBtlIZD9u3W3vx0tpVQFx0lPjyjEUhHOW nYVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EdzONGIZhlDijIFOOZacH7XFfFT/aVos65rwfInGk4s=; b=Ko5rG8PA9fP1/UNCqyByCqRc/DqPv7Eqcwiw0uCyaQ1Q0uvmdQAA5ZJowFdtF9DOx6 XM897sS99opX969e7nRnkDZnLawM8ETgMNNzjdUl8Eejl/o1Osgd/QpPtCDcKn1qxIke EWA8AChjpjwlXxBtXnDSyUl5qbJhuLGUhb6qQar/wc2n6rH4GMDgEHYSaGvWNOIaxOrz xfU+TpEe63CZ6FgaGrSFkEyK/9oUI+LEQie+bY9zInDiO5zWp5WJhpr8/c6hxmJc2kF6 ZHYuDhgwbKD4un6w1WQIR+Ov1iyfZbkhKAp2woMD3OVSpvSVwpMt6lbkS17d/r3L4vS2 TtIw== X-Gm-Message-State: AOAM533rrl5DRWTaOPAxdZwZuDgHMP5e09nfx/gT+oeBz7ITY+HiMsoJ geXMAdIYmTwKR41nzihhOLZc8g== X-Google-Smtp-Source: ABdhPJwsptcMtNoEKIwi+0pY5ucwko0JXxtIwjKOkFICaQEhahNB5ZXHk4SkebIHtCLG8C9msyKRVQ== X-Received: by 2002:adf:dfd1:: with SMTP id q17mr29120298wrn.177.1620645215610; Mon, 10 May 2021 04:13:35 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.35.175]) by smtp.googlemail.com with ESMTPSA id j13sm27460197wrd.81.2021.05.10.04.13.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 May 2021 04:13:34 -0700 (PDT) Subject: Re: [PATCH 1/1] Platform/RaspberryPi: Update ACPI table revision To: Sunny Wang , devel@edk2.groups.io Cc: Samer El-Haj-Mahmoud , Jeremy Linton , Sami Mujawar , Ard Biesheuvel References: <20210510090849.1828-1-Sunny.Wang@arm.com> From: "Pete Batard" Message-ID: <6ae92d81-0d90-20dc-e0b9-64b1f4dc65cd@akeo.ie> Date: Mon, 10 May 2021 12:13:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210510090849.1828-1-Sunny.Wang@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2021.05.10 10:08, Sunny Wang wrote: > As per ACPI 6.3 specification, the DSDT/SSDT table should use revision 2 > , so update the revision numbers to 2. > This also fixes https://github.com/pftf/RPi4/issues/94 (FWTS failures). > > Testing Done: > - Booted to UEFI Shell and used apciview command to check all ACPI > tables' revision. > - Ran FWTS test and no longer see the ACPI DSDT and SSDT revision > failures. Note that the XSDT revision failure is caused by the FWTS > tool's issue that got fixed in > commit c522bfedc9839a474b8d590ba36bec77436d2e90 > > Cc: Samer El-Haj-Mahmoud > Cc: Jeremy Linton > Cc: Sami Mujawar > Cc: Pete Batard > Cc: Ard Biesheuvel > Signed-off-by: Sunny Wang > --- > Platform/RaspberryPi/AcpiTables/Dsdt.asl | 3 ++- > Platform/RaspberryPi/AcpiTables/Emmc.asl | 4 ++-- > Platform/RaspberryPi/AcpiTables/SsdtThermal.asl | 4 ++-- > 3 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/Platform/RaspberryPi/AcpiTables/Dsdt.asl b/Platform/RaspberryPi/AcpiTables/Dsdt.asl > index d116f965e1..54fa3eca7b 100644 > --- a/Platform/RaspberryPi/AcpiTables/Dsdt.asl > +++ b/Platform/RaspberryPi/AcpiTables/Dsdt.asl > @@ -5,6 +5,7 @@ > * Copyright (c) 2020, Pete Batard > * Copyright (c) 2018-2020, Andrey Warkentin > * Copyright (c) Microsoft Corporation. All rights reserved. > + * Copyright (c) 2021, ARM Limited. All rights reserved. > * > * SPDX-License-Identifier: BSD-2-Clause-Patent > * > @@ -58,7 +59,7 @@ > Store (Length, LE ## Index) \ > Add (MI ## Index, LE ## Index - 1, MA ## Index) > > -DefinitionBlock ("Dsdt.aml", "DSDT", 5, "RPIFDN", "RPI", 2) > +DefinitionBlock ("Dsdt.aml", "DSDT", 2, "RPIFDN", "RPI", 2) > { > Scope (\_SB_) > { > diff --git a/Platform/RaspberryPi/AcpiTables/Emmc.asl b/Platform/RaspberryPi/AcpiTables/Emmc.asl > index 179dd3ecdb..88811eb354 100644 > --- a/Platform/RaspberryPi/AcpiTables/Emmc.asl > +++ b/Platform/RaspberryPi/AcpiTables/Emmc.asl > @@ -1,6 +1,6 @@ > /** @file > * > - * Copyright (c) 2021 Arm. All rights reserved. > + * Copyright (c) 2021, ARM Limited. All rights reserved. > * > * SPDX-License-Identifier: BSD-2-Clause-Patent > * > @@ -11,7 +11,7 @@ > > #include "AcpiTables.h" > > -DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPI4EMMC", 2) > +DefinitionBlock (__FILE__, "SSDT", 2, "RPIFDN", "RPI4EMMC", 2) > { > Scope (\_SB_) > { > diff --git a/Platform/RaspberryPi/AcpiTables/SsdtThermal.asl b/Platform/RaspberryPi/AcpiTables/SsdtThermal.asl > index acfa4699bb..e82f55bebd 100644 > --- a/Platform/RaspberryPi/AcpiTables/SsdtThermal.asl > +++ b/Platform/RaspberryPi/AcpiTables/SsdtThermal.asl > @@ -2,7 +2,7 @@ > * > * Secondary System Description Table (SSDT) for active (fan) cooling > * > - * Copyright (c) 2020, Arm Ltd. All rights reserved. > + * Copyright (c) 2020 - 2021, ARM Limited. All rights reserved. > * > * SPDX-License-Identifier: BSD-2-Clause-Patent > * > @@ -14,7 +14,7 @@ > > #include > > -DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPITHFAN", 2) > +DefinitionBlock (__FILE__, "SSDT", 2, "RPIFDN", "RPITHFAN", 2) > { > External (\_SB_.EC00, DeviceObj) > External (\_SB_.EC00.TZ00, DeviceObj) > Reviewed-by: Pete Batard Tested-by: Pete Batard (Windows 10 boot)