From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CB9DE210E3DE0 for ; Thu, 9 Aug 2018 06:35:46 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 15ED840216EB; Thu, 9 Aug 2018 13:35:46 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-52.rdu2.redhat.com [10.10.121.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 575E42026D66; Thu, 9 Aug 2018 13:35:45 +0000 (UTC) To: shenglei , edk2-devel@lists.01.org Cc: Eric Dong , Star Zeng References: <20180808084712.34696-1-shenglei.zhang@intel.com> <20180808084712.34696-7-shenglei.zhang@intel.com> From: Laszlo Ersek Message-ID: <6b05eaf2-2d1a-2818-e1b4-9478f414fd55@redhat.com> Date: Thu, 9 Aug 2018 15:35:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180808084712.34696-7-shenglei.zhang@intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Thu, 09 Aug 2018 13:35:46 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Thu, 09 Aug 2018 13:35:46 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 06/26] MdeModulePkg PciBusDxe: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 13:35:47 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/08/18 10:46, shenglei wrote: > The functions that are never called have been removed. > They are UpStreamBridgesAttributes and GetHpcPciAddressFromRootBridge. > https://bugzilla.tianocore.org/show_bug.cgi?id=1062 > > Cc: Star Zeng > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei > --- > .../Bus/Pci/PciBusDxe/PciDeviceSupport.c | 80 ------------------- > .../Bus/Pci/PciBusDxe/PciDeviceSupport.h | 17 ---- > MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 41 ---------- > MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h | 21 ----- > 4 files changed, 159 deletions(-) Reviewed-by: Laszlo Ersek