From: Ryszard Knop <ryszard.knop@linux.intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, edk2-devel@lists.01.org
Cc: kamil.kacperski@intel.com, eric.jin@intel.com,
pawel.orlowski@intel.com, michael.d.kinney@intel.com,
harry.l.hsiung@intel.com
Subject: Re: [PATCH edk2-staging 16/20] IntelUndiPkg/XGigUndiDxe: add missing EFIAPI modifiers
Date: Wed, 30 Jan 2019 17:27:25 +0100 [thread overview]
Message-ID: <6b110d4db260b0ec0949bf018297153a1063703d.camel@linux.intel.com> (raw)
In-Reply-To: <20181115023353.20159-17-ard.biesheuvel@linaro.org>
Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>
On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote:
> When building for the X64 target using GCC, correct use of the
> EFIAPI modifiers is essential to ensure that the correct calling
> convention is used. So add the missing ones where appropriate.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> ---
> IntelUndiPkg/XGigUndiDxe/AdapterInformation.c | 3 +++
> IntelUndiPkg/XGigUndiDxe/ComponentName.c | 2 ++
> IntelUndiPkg/XGigUndiDxe/ComponentName.h | 1 +
> IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c | 1 +
> IntelUndiPkg/XGigUndiDxe/DriverHealth.c | 2 ++
> IntelUndiPkg/XGigUndiDxe/StartStop.c | 2 ++
> 6 files changed, 11 insertions(+)
>
> diff --git a/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c
> b/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c
> index 26556e284381..b25ed7c4f022 100644
> --- a/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c
> +++ b/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c
> @@ -123,6 +123,7 @@ GetIpv6SupportInformationBlock (
> **/
> STATIC
> EFI_STATUS
> +EFIAPI
> GetInformation (
> IN EFI_ADAPTER_INFORMATION_PROTOCOL *This,
> IN EFI_GUID * InformationType,
> @@ -188,6 +189,7 @@ GetInformation (
> **/
> STATIC
> EFI_STATUS
> +EFIAPI
> SetInformation (
> IN EFI_ADAPTER_INFORMATION_PROTOCOL *This,
> IN EFI_GUID * InformationType,
> @@ -234,6 +236,7 @@ SetInformation (
> **/
> STATIC
> EFI_STATUS
> +EFIAPI
> GetSupportedTypes (
> IN EFI_ADAPTER_INFORMATION_PROTOCOL *This,
> OUT EFI_GUID ** InfoTypesBuffer,
> diff --git a/IntelUndiPkg/XGigUndiDxe/ComponentName.c
> b/IntelUndiPkg/XGigUndiDxe/ComponentName.c
> index 2972c28bda4e..eee59d7c14f4 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ComponentName.c
> +++ b/IntelUndiPkg/XGigUndiDxe/ComponentName.c
> @@ -116,6 +116,7 @@ ComponentNameInitializeControllerName (
> language specified by Language.
> **/
> EFI_STATUS
> +EFIAPI
> ComponentNameGetDriverName (
> IN EFI_COMPONENT_NAME_PROTOCOL *This,
> IN CHAR8 * Language,
> @@ -186,6 +187,7 @@ ComponentNameGetDriverName (
> language specified by Language.
> **/
> EFI_STATUS
> +EFIAPI
> ComponentNameGetControllerName (
> IN EFI_COMPONENT_NAME_PROTOCOL
> * This,
> IN EFI_HANDLE Co
> ntrollerHandle,
> diff --git a/IntelUndiPkg/XGigUndiDxe/ComponentName.h
> b/IntelUndiPkg/XGigUndiDxe/ComponentName.h
> index f63d58b8a18c..4f62e48379ed 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ComponentName.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ComponentName.h
> @@ -67,6 +67,7 @@ ComponentNameInitializeControllerName (
> language specified by Language.
> **/
> EFI_STATUS
> +EFIAPI
> ComponentNameGetDriverName (
> IN EFI_COMPONENT_NAME_PROTOCOL *This,
> IN CHAR8 * Language,
> diff --git a/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c
> b/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c
> index 2f9c66771910..77b7a954698b 100644
> --- a/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c
> +++ b/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c
> @@ -370,6 +370,7 @@ XgbeUndiPhyLoopback (
> ChildHandle did not pass
> the diagnostic.
> **/
> EFI_STATUS
> +EFIAPI
> XgbeUndiDriverDiagnosticsRunDiagnostics (
> IN EFI_DRIVER_DIAGNOSTICS_PROTOCOL
> * This,
> IN
> EFI_HANDLE C
> ontrollerHandle,
> diff --git a/IntelUndiPkg/XGigUndiDxe/DriverHealth.c
> b/IntelUndiPkg/XGigUndiDxe/DriverHealth.c
> index df6cfdf8a123..4b173bc8d8a9 100644
> --- a/IntelUndiPkg/XGigUndiDxe/DriverHealth.c
> +++ b/IntelUndiPkg/XGigUndiDxe/DriverHealth.c
> @@ -45,6 +45,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
> @retval !EFI_SUCCESS Failure to retrieve health status
> **/
> EFI_STATUS
> +EFIAPI
> GetHealthStatus (
> IN EFI_DRIVER_HEALTH_PROTOCOL * This,
> IN EFI_HANDLE ControllerHandle, OPTIONAL
> @@ -145,6 +146,7 @@ GetHealthStatus (
> @retval EFI_UNSUPPORTED This function is unsupported
> **/
> EFI_STATUS
> +EFIAPI
> Repair (
> IN EFI_DRIVER_HEALTH_PROTOCOL *This,
> IN EFI_HANDLE ControllerHandle,
> diff --git a/IntelUndiPkg/XGigUndiDxe/StartStop.c
> b/IntelUndiPkg/XGigUndiDxe/StartStop.c
> index 156e927a35c6..c881c811aefb 100644
> --- a/IntelUndiPkg/XGigUndiDxe/StartStop.c
> +++ b/IntelUndiPkg/XGigUndiDxe/StartStop.c
> @@ -38,6 +38,7 @@ EFI_GUID gEfiStartStopProtocolGuid =
> EFI_DRIVER_STOP_PROTOCOL_GUID;
> @retval EFI_SUCCESS Driver is stopped successfully
> **/
> EFI_STATUS
> +EFIAPI
> StopDriver (
> IN EFI_DRIVER_STOP_PROTOCOL *This
> )
> @@ -63,6 +64,7 @@ StopDriver (
> @retval EFI_DEVICE_ERROR Failed to initialize hardware
> **/
> EFI_STATUS
> +EFIAPI
> StartDriver (
> IN EFI_DRIVER_STOP_PROTOCOL *This
> )
next prev parent reply other threads:[~2019-01-30 16:27 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 2:33 [PATCH edk2-staging 00/20] IntelUndiPkg/XGigUndiDxe: fix GCC / ARM build issues Ard Biesheuvel
2018-11-15 2:33 ` [PATCH edk2-staging 01/20] IntelUndiPkg/XGigUndiDxe: create GCC alternatives for MSFT build options Ard Biesheuvel
2019-01-30 15:41 ` Ryszard Knop
2018-11-15 2:33 ` [PATCH edk2-staging 02/20] IntelUndiPkg/XGigUndiDxe: move MSFT warning overrides to INF file Ard Biesheuvel
2019-01-30 15:44 ` Ryszard Knop
2018-11-15 2:33 ` [PATCH edk2-staging 03/20] IntelUndiPkg/XGigUndiDxe: consistently use forward slashes as path separators Ard Biesheuvel
2019-01-30 15:49 ` Ryszard Knop
2018-11-15 2:33 ` [PATCH edk2-staging 04/20] IntelUndiPkg/XGigUndiDxe: move BRAND_STRUCT declaration after type definition Ard Biesheuvel
2019-01-30 15:49 ` Ryszard Knop
2018-11-15 2:33 ` [PATCH edk2-staging 05/20] IntelUndiPkg/XGigUndiDxe: add missing VOID** cast Ard Biesheuvel
2019-01-30 15:51 ` Ryszard Knop
2018-11-15 2:33 ` [PATCH edk2-staging 06/20] IntelUndiPkg/XGigUndiDxe: add missing UINT8* cast Ard Biesheuvel
2019-01-30 15:51 ` Ryszard Knop
2018-11-15 2:33 ` [PATCH edk2-staging 07/20] IntelUndiPkg/XGigUndiDxe: drop definition of gImageHandle Ard Biesheuvel
2019-01-30 16:05 ` Ryszard Knop
2019-01-30 16:06 ` Ard Biesheuvel
2019-01-30 16:17 ` Ryszard Knop
2019-01-30 16:56 ` Andrew Fish
2018-11-15 2:33 ` [PATCH edk2-staging 08/20] IntelUndiPkg/XGigUndiDxe: add missing braces to GUID literals Ard Biesheuvel
2019-01-30 16:06 ` Ryszard Knop
2018-11-15 2:33 ` [PATCH edk2-staging 09/20] IntelUndiPkg/XGigUndiDxe: fix incorrect use of CPP token pasting Ard Biesheuvel
2019-01-30 16:06 ` Ryszard Knop
2018-11-15 2:33 ` [PATCH edk2-staging 10/20] IntelUndiPkg/XGigUndiDxe: drop StdLibC library class reference Ard Biesheuvel
2018-11-15 15:16 ` Carsey, Jaben
2019-01-30 17:26 ` Ryszard Knop
2019-01-30 18:34 ` Andrew Fish
2019-02-06 9:46 ` Ryszard Knop
2019-01-30 20:58 ` Kinney, Michael D
2019-02-06 10:14 ` Ryszard Knop
2018-11-15 2:33 ` [PATCH edk2-staging 11/20] IntelUndiPkg/XGigUndiDxe: cast XgbeMemCopy () args to correct pointer type Ard Biesheuvel
2019-01-30 16:20 ` Ryszard Knop
2018-11-15 2:33 ` [PATCH edk2-staging 12/20] IntelUndiPkg/XGigUndiDxe: don't take address of cast expression Ard Biesheuvel
2019-01-30 16:20 ` Ryszard Knop
2018-11-15 2:33 ` [PATCH edk2-staging 13/20] IntelUndiPkg/XGigUndiDxe: drop locally defined ASSERT() macro Ard Biesheuvel
2018-11-15 2:33 ` [PATCH edk2-staging 14/20] IntelUndiPkg/XGigUndiDxe: redefine UNREFERENCED_nPARAMETER macros for GCC Ard Biesheuvel
2019-01-30 16:22 ` Ryszard Knop
2018-11-15 2:33 ` [PATCH edk2-staging 15/20] IntelUndiPkg/XGigUndiDxe: use intermediate UINTN casts for pointers Ard Biesheuvel
2019-01-30 16:26 ` Ryszard Knop
2018-11-15 2:33 ` [PATCH edk2-staging 16/20] IntelUndiPkg/XGigUndiDxe: add missing EFIAPI modifiers Ard Biesheuvel
2019-01-30 16:27 ` Ryszard Knop [this message]
2018-11-15 2:33 ` [PATCH edk2-staging 17/20] IntelUndiPkg/XGigUndiDxe: drop unused variables Ard Biesheuvel
2019-01-30 16:39 ` Ryszard Knop
2018-11-15 2:33 ` [PATCH edk2-staging 18/20] IntelUndiPkg/XGigUndiDxe: set MDEPKG_NDEBUG only for RELEASE builds Ard Biesheuvel
2019-01-30 17:15 ` Ryszard Knop
2018-11-15 2:33 ` [PATCH edk2-staging 19/20] IntelUndiPkg/XGigUndiDxe: drop separate debug macros for DBG_LVL Ard Biesheuvel
2018-11-15 2:33 ` [PATCH edk2-staging 20/20] IntelUndiPkg/XGigUndiDxe: avoid unused var warnings for ERROR_REPORTn() Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b110d4db260b0ec0949bf018297153a1063703d.camel@linux.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox