From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=ryszard.knop@linux.intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 349422096964D for ; Wed, 30 Jan 2019 08:27:30 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 08:27:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,541,1539673200"; d="scan'208";a="314909823" Received: from linux.intel.com ([10.54.29.200]) by fmsmga006.fm.intel.com with ESMTP; 30 Jan 2019 08:27:29 -0800 Received: from torii (torii.igk.intel.com [10.102.24.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 9ABDC580550; Wed, 30 Jan 2019 08:27:27 -0800 (PST) Message-ID: <6b110d4db260b0ec0949bf018297153a1063703d.camel@linux.intel.com> From: Ryszard Knop To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: kamil.kacperski@intel.com, eric.jin@intel.com, pawel.orlowski@intel.com, michael.d.kinney@intel.com, harry.l.hsiung@intel.com Date: Wed, 30 Jan 2019 17:27:25 +0100 In-Reply-To: <20181115023353.20159-17-ard.biesheuvel@linaro.org> References: <20181115023353.20159-1-ard.biesheuvel@linaro.org> <20181115023353.20159-17-ard.biesheuvel@linaro.org> Organization: Intel Corporation User-Agent: Evolution 3.30.4 Mime-Version: 1.0 Subject: Re: [PATCH edk2-staging 16/20] IntelUndiPkg/XGigUndiDxe: add missing EFIAPI modifiers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 16:27:30 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:27:30 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:27:30 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:27:30 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:27:30 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:27:30 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Reviewed-by: Ryszard Knop On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote: > When building for the X64 target using GCC, correct use of the > EFIAPI modifiers is essential to ensure that the correct calling > convention is used. So add the missing ones where appropriate. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > IntelUndiPkg/XGigUndiDxe/AdapterInformation.c | 3 +++ > IntelUndiPkg/XGigUndiDxe/ComponentName.c | 2 ++ > IntelUndiPkg/XGigUndiDxe/ComponentName.h | 1 + > IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c | 1 + > IntelUndiPkg/XGigUndiDxe/DriverHealth.c | 2 ++ > IntelUndiPkg/XGigUndiDxe/StartStop.c | 2 ++ > 6 files changed, 11 insertions(+) > > diff --git a/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c > b/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c > index 26556e284381..b25ed7c4f022 100644 > --- a/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c > +++ b/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c > @@ -123,6 +123,7 @@ GetIpv6SupportInformationBlock ( > **/ > STATIC > EFI_STATUS > +EFIAPI > GetInformation ( > IN EFI_ADAPTER_INFORMATION_PROTOCOL *This, > IN EFI_GUID * InformationType, > @@ -188,6 +189,7 @@ GetInformation ( > **/ > STATIC > EFI_STATUS > +EFIAPI > SetInformation ( > IN EFI_ADAPTER_INFORMATION_PROTOCOL *This, > IN EFI_GUID * InformationType, > @@ -234,6 +236,7 @@ SetInformation ( > **/ > STATIC > EFI_STATUS > +EFIAPI > GetSupportedTypes ( > IN EFI_ADAPTER_INFORMATION_PROTOCOL *This, > OUT EFI_GUID ** InfoTypesBuffer, > diff --git a/IntelUndiPkg/XGigUndiDxe/ComponentName.c > b/IntelUndiPkg/XGigUndiDxe/ComponentName.c > index 2972c28bda4e..eee59d7c14f4 100644 > --- a/IntelUndiPkg/XGigUndiDxe/ComponentName.c > +++ b/IntelUndiPkg/XGigUndiDxe/ComponentName.c > @@ -116,6 +116,7 @@ ComponentNameInitializeControllerName ( > language specified by Language. > **/ > EFI_STATUS > +EFIAPI > ComponentNameGetDriverName ( > IN EFI_COMPONENT_NAME_PROTOCOL *This, > IN CHAR8 * Language, > @@ -186,6 +187,7 @@ ComponentNameGetDriverName ( > language specified by Language. > **/ > EFI_STATUS > +EFIAPI > ComponentNameGetControllerName ( > IN EFI_COMPONENT_NAME_PROTOCOL > * This, > IN EFI_HANDLE Co > ntrollerHandle, > diff --git a/IntelUndiPkg/XGigUndiDxe/ComponentName.h > b/IntelUndiPkg/XGigUndiDxe/ComponentName.h > index f63d58b8a18c..4f62e48379ed 100644 > --- a/IntelUndiPkg/XGigUndiDxe/ComponentName.h > +++ b/IntelUndiPkg/XGigUndiDxe/ComponentName.h > @@ -67,6 +67,7 @@ ComponentNameInitializeControllerName ( > language specified by Language. > **/ > EFI_STATUS > +EFIAPI > ComponentNameGetDriverName ( > IN EFI_COMPONENT_NAME_PROTOCOL *This, > IN CHAR8 * Language, > diff --git a/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c > b/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c > index 2f9c66771910..77b7a954698b 100644 > --- a/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c > +++ b/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c > @@ -370,6 +370,7 @@ XgbeUndiPhyLoopback ( > ChildHandle did not pass > the diagnostic. > **/ > EFI_STATUS > +EFIAPI > XgbeUndiDriverDiagnosticsRunDiagnostics ( > IN EFI_DRIVER_DIAGNOSTICS_PROTOCOL > * This, > IN > EFI_HANDLE C > ontrollerHandle, > diff --git a/IntelUndiPkg/XGigUndiDxe/DriverHealth.c > b/IntelUndiPkg/XGigUndiDxe/DriverHealth.c > index df6cfdf8a123..4b173bc8d8a9 100644 > --- a/IntelUndiPkg/XGigUndiDxe/DriverHealth.c > +++ b/IntelUndiPkg/XGigUndiDxe/DriverHealth.c > @@ -45,6 +45,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE > POSSIBILITY OF SUCH DAMAGE. > @retval !EFI_SUCCESS Failure to retrieve health status > **/ > EFI_STATUS > +EFIAPI > GetHealthStatus ( > IN EFI_DRIVER_HEALTH_PROTOCOL * This, > IN EFI_HANDLE ControllerHandle, OPTIONAL > @@ -145,6 +146,7 @@ GetHealthStatus ( > @retval EFI_UNSUPPORTED This function is unsupported > **/ > EFI_STATUS > +EFIAPI > Repair ( > IN EFI_DRIVER_HEALTH_PROTOCOL *This, > IN EFI_HANDLE ControllerHandle, > diff --git a/IntelUndiPkg/XGigUndiDxe/StartStop.c > b/IntelUndiPkg/XGigUndiDxe/StartStop.c > index 156e927a35c6..c881c811aefb 100644 > --- a/IntelUndiPkg/XGigUndiDxe/StartStop.c > +++ b/IntelUndiPkg/XGigUndiDxe/StartStop.c > @@ -38,6 +38,7 @@ EFI_GUID gEfiStartStopProtocolGuid = > EFI_DRIVER_STOP_PROTOCOL_GUID; > @retval EFI_SUCCESS Driver is stopped successfully > **/ > EFI_STATUS > +EFIAPI > StopDriver ( > IN EFI_DRIVER_STOP_PROTOCOL *This > ) > @@ -63,6 +64,7 @@ StopDriver ( > @retval EFI_DEVICE_ERROR Failed to initialize hardware > **/ > EFI_STATUS > +EFIAPI > StartDriver ( > IN EFI_DRIVER_STOP_PROTOCOL *This > )