public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: stephen@redhat.com
Cc: ting.ye@intel.com, edk2-devel@lists.01.org, Jiaxin.wu@intel.com,
	siyuan.fu@intel.com
Subject: Re: [Patch] MdeModulePkg/Library/DxeHttpLib: Handle the blank value in HTTP header.
Date: Tue, 11 Sep 2018 17:10:04 +0200	[thread overview]
Message-ID: <6b16cec2-8563-c597-86c2-8f1efe8befe6@redhat.com> (raw)
In-Reply-To: <CACmh_15mVguK_b6sh=x0-05ZdWXtBj4A7Hc8YidcqSgwGCvc=A@mail.gmail.com>

On 09/04/18 15:43, Stephen Benjamin wrote:
> On Tue, Sep 4, 2018 at 7:02 AM Laszlo Ersek <lersek@redhat.com> wrote:
>>
>> On 09/04/18 09:17, Jiaxin Wu wrote:
>>> This patch is to resolve the lock-up issue if the value of HTTP header
>>> is blank.  The issue is recorded @
>>> https://bugzilla.tianocore.org/show_bug.cgi?id=1102.
>>>
>>> Cc: Stephen Benjamin <stephen@redhat.com>
>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>> Cc: Ye Ting <ting.ye@intel.com>
>>> Cc: Fu Siyuan <siyuan.fu@intel.com>
>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
>>> ---
>>>  MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 57 +++++++++++++++-----
>>>  1 file changed, 44 insertions(+), 13 deletions(-)
>>
>> Thank you, Jiaxin, I'll let Stephen test this :)
>>
>> Stephen, can you please respond with your Tested-by, if the patch solves
>> the problem for you?
>>
>> Also, would you prefer a remote repo+branch that you could pull (over
>> applying this patch with "git-am") for testing? The edk2 project uses
>> CRLF source files, so "git-am" is a bit quirky.
> 
> No need, the patch applied fine. Thanks for the quick turnaround! It
> resolved my issue.
> 
> Tested-by: Stephen Benjamin <stephen@redhat.com>

Siyuan, Ting, can you guys please review Jiaxin's patch?

Thanks
Laszlo


  reply	other threads:[~2018-09-11 15:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-04  7:17 [Patch] MdeModulePkg/Library/DxeHttpLib: Handle the blank value in HTTP header Jiaxin Wu
2018-09-04 11:02 ` Laszlo Ersek
2018-09-04 13:43   ` Stephen Benjamin
2018-09-11 15:10     ` Laszlo Ersek [this message]
2018-09-12  8:54 ` Fu, Siyuan
2018-09-13  2:32 ` Ye, Ting

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b16cec2-8563-c597-86c2-8f1efe8befe6@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox