From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A883E21AE30DB for ; Tue, 11 Sep 2018 08:10:08 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F2AA840216E8; Tue, 11 Sep 2018 15:10:07 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-36.rdu2.redhat.com [10.10.120.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4EE4A20389E0; Tue, 11 Sep 2018 15:10:05 +0000 (UTC) To: stephen@redhat.com Cc: ting.ye@intel.com, edk2-devel@lists.01.org, Jiaxin.wu@intel.com, siyuan.fu@intel.com References: <20180904071722.7728-1-Jiaxin.wu@intel.com> From: Laszlo Ersek Message-ID: <6b16cec2-8563-c597-86c2-8f1efe8befe6@redhat.com> Date: Tue, 11 Sep 2018 17:10:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Tue, 11 Sep 2018 15:10:08 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Tue, 11 Sep 2018 15:10:08 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [Patch] MdeModulePkg/Library/DxeHttpLib: Handle the blank value in HTTP header. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Sep 2018 15:10:08 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/04/18 15:43, Stephen Benjamin wrote: > On Tue, Sep 4, 2018 at 7:02 AM Laszlo Ersek wrote: >> >> On 09/04/18 09:17, Jiaxin Wu wrote: >>> This patch is to resolve the lock-up issue if the value of HTTP header >>> is blank. The issue is recorded @ >>> https://bugzilla.tianocore.org/show_bug.cgi?id=1102. >>> >>> Cc: Stephen Benjamin >>> Cc: Laszlo Ersek >>> Cc: Ye Ting >>> Cc: Fu Siyuan >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Wu Jiaxin >>> --- >>> MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 57 +++++++++++++++----- >>> 1 file changed, 44 insertions(+), 13 deletions(-) >> >> Thank you, Jiaxin, I'll let Stephen test this :) >> >> Stephen, can you please respond with your Tested-by, if the patch solves >> the problem for you? >> >> Also, would you prefer a remote repo+branch that you could pull (over >> applying this patch with "git-am") for testing? The edk2 project uses >> CRLF source files, so "git-am" is a bit quirky. > > No need, the patch applied fine. Thanks for the quick turnaround! It > resolved my issue. > > Tested-by: Stephen Benjamin Siyuan, Ting, can you guys please review Jiaxin's patch? Thanks Laszlo