Re: [edk2-platforms][PATCH v2 1/1] Platform/RPi3: Add TFTP command to UEFI Shell

["Pete Batard" <pete@akeo.ie>]

On 2019.10.18 13:52, Leif Lindholm wrote:
> On Fri, Oct 18, 2019 at 01:41:30PM +0100, Pete Batard wrote:
>> TFTP support, which is enabled by default, can be disabled by setting
>> INCLUDE_TFTP_COMMAND to FALSE.
> 
> Would you be OK with flipping the default to FALSE?

Yes, I have no issue with a default set to FALSE.

> It is a custom extension not described by the UEFI Shell
> Specification.
> 
> I could flip the logic in the DEFINE and commit message if so, no need
> for a v3.

If you can do that, that would be great. Thanks!

/Pete

> 
> Regards,
> 
> Leif
> 
>> Signed-off-by: Pete Batard <pete@akeo.ie>
>> ---
>>   Platform/RaspberryPi/RPi3/RPi3.dsc | 8 ++++++++
>>   Platform/RaspberryPi/RPi3/RPi3.fdf | 3 +++
>>   2 files changed, 11 insertions(+)
>>
>> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
>> index bc424a06bb45..2289ad8c2ed2 100644
>> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
>> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
>> @@ -36,6 +36,7 @@ [Defines]
>>     # -D FLAG=VALUE
>>     #
>>     DEFINE SECURE_BOOT_ENABLE      = FALSE
>> +  DEFINE INCLUDE_TFTP_COMMAND    = TRUE
>>     DEFINE DEBUG_PRINT_ERROR_LEVEL = 0x8000004F
>>   
>>   ################################################################################
>> @@ -181,6 +182,10 @@ [LibraryClasses.common.DXE_DRIVER]
>>     SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf
>>     PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
>>     MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
>> +!if $(INCLUDE_TFTP_COMMAND) == TRUE
>> +  ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>> +  FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf
>> +!endif
>>   
>>   [LibraryClasses.common.UEFI_APPLICATION]
>>     PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
>> @@ -616,3 +621,6 @@ [Components.common]
>>         gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|8000
>>         gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize|0x200000
>>     }
>> +!if $(INCLUDE_TFTP_COMMAND) == TRUE
>> +  ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
>> +!endif
>> diff --git a/Platform/RaspberryPi/RPi3/RPi3.fdf b/Platform/RaspberryPi/RPi3/RPi3.fdf
>> index 17c0094ac1cf..b06a15fb8ec3 100644
>> --- a/Platform/RaspberryPi/RPi3/RPi3.fdf
>> +++ b/Platform/RaspberryPi/RPi3/RPi3.fdf
>> @@ -232,6 +232,9 @@ [FV.FvMain]
>>     # UEFI application (Shell Embedded Boot Loader)
>>     #
>>     INF ShellPkg/Application/Shell/Shell.inf
>> +!if $(INCLUDE_TFTP_COMMAND) == TRUE
>> +  INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
>> +!endif
>>   
>>     #
>>     # ACPI Support
>> -- 
>> 2.21.0.windows.1
>>