From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web12.5764.1571405160224313192 for ; Fri, 18 Oct 2019 06:26:00 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=NcfqKQuB; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.221.67, mailfrom: pete@akeo.ie) Received: by mail-wr1-f67.google.com with SMTP id l10so5855419wrb.2 for ; Fri, 18 Oct 2019 06:25:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kkEgpZAI20Ba5HcjsMLrPapmXpYOk/udWO44sRXs43w=; b=NcfqKQuBvQ1D6Bmk8EBRsc5vHRXhrwDUZ983RFCAA9szoZA0V0LW7piXrTmuUuISW4 bwMjyMqk4gzyPdJWbxxRM+wlelQHnauod1iVFbeY4Zv9Ue7uVCwb3MYCjOE+PYT4AUEB mFZZpyCvhRRMd4WTIWrHjtrWI+C3vN/lCcEcOS6eMq5dW1Ue91ui4AY6NtFMvwCZ8NN2 VL5WspKbe5EnlfIIst0ZXAQ4OYIaB47ADdN31/X49AsY9guikakV+OqhAcUmpkrqOZam voXNuS8Jin6R+7Qzc8W4/6Hw6jRDN0vyffKBGns+nb6JoTKghy6nk0QDlrd9FdBomeUJ iW/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kkEgpZAI20Ba5HcjsMLrPapmXpYOk/udWO44sRXs43w=; b=lymE47c+0JE3NJwq8tzroN0YmiB65MIy9ced8kaEdpBzJH8peZA6Ba81v2eHwL+n0F iRfVbKU86q6EAdNTA0F1T608LZqzYH6W9Gd6+AEp00GqV0DBNmdgJFddGRNxoF5Db+R3 XD7MUA9PisqeJjsMOvDStC+PNwYxLmTBTjZSa6WdZMCGROKbOgY5ahJ3tLrig07i4TX0 Zuo9gQKgSXNv6QJk1tIazYQNVfigsIG23JFXhi19MNYv1V6Hu684q3tLSKx4jKg5jG0K orK0OClcE54t9RqvDHRTmzBKrXE8sKt3KACqR5/AGRaSnT7DgvpbXMW4D1lB86f0cAVL /t4g== X-Gm-Message-State: APjAAAV9FcfJPLev/3zQ8e5dHqO14ZBkj1XlzVuM6VI9mWTGq892b2Gw 7hqFuj9mA/gOfF6cF0AfmQB62w== X-Google-Smtp-Source: APXvYqwyq9PpGijDgth/vME9jCySSev1appoLer2zVayhmvtl2I8UsRxi4+kEVT/AdsxAy3Z9mTB8Q== X-Received: by 2002:adf:f592:: with SMTP id f18mr2326057wro.33.1571405158672; Fri, 18 Oct 2019 06:25:58 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.68.221]) by smtp.googlemail.com with ESMTPSA id p5sm5707152wmi.4.2019.10.18.06.25.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Oct 2019 06:25:57 -0700 (PDT) Subject: Re: [edk2-platforms][PATCH v2 1/1] Platform/RPi3: Add TFTP command to UEFI Shell To: Leif Lindholm Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org References: <20191018124130.8456-1-pete@akeo.ie> <20191018124130.8456-2-pete@akeo.ie> <20191018125205.GE25504@bivouac.eciton.net> From: "Pete Batard" Message-ID: <6b23a960-8af8-2ab3-69c8-454f3f0eef37@akeo.ie> Date: Fri, 18 Oct 2019 14:25:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191018125205.GE25504@bivouac.eciton.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2019.10.18 13:52, Leif Lindholm wrote: > On Fri, Oct 18, 2019 at 01:41:30PM +0100, Pete Batard wrote: >> TFTP support, which is enabled by default, can be disabled by setting >> INCLUDE_TFTP_COMMAND to FALSE. > > Would you be OK with flipping the default to FALSE? Yes, I have no issue with a default set to FALSE. > It is a custom extension not described by the UEFI Shell > Specification. > > I could flip the logic in the DEFINE and commit message if so, no need > for a v3. If you can do that, that would be great. Thanks! /Pete > > Regards, > > Leif > >> Signed-off-by: Pete Batard >> --- >> Platform/RaspberryPi/RPi3/RPi3.dsc | 8 ++++++++ >> Platform/RaspberryPi/RPi3/RPi3.fdf | 3 +++ >> 2 files changed, 11 insertions(+) >> >> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc >> index bc424a06bb45..2289ad8c2ed2 100644 >> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc >> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc >> @@ -36,6 +36,7 @@ [Defines] >> # -D FLAG=VALUE >> # >> DEFINE SECURE_BOOT_ENABLE = FALSE >> + DEFINE INCLUDE_TFTP_COMMAND = TRUE >> DEFINE DEBUG_PRINT_ERROR_LEVEL = 0x8000004F >> >> ################################################################################ >> @@ -181,6 +182,10 @@ [LibraryClasses.common.DXE_DRIVER] >> SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf >> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf >> MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf >> +!if $(INCLUDE_TFTP_COMMAND) == TRUE >> + ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf >> + FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf >> +!endif >> >> [LibraryClasses.common.UEFI_APPLICATION] >> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf >> @@ -616,3 +621,6 @@ [Components.common] >> gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|8000 >> gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize|0x200000 >> } >> +!if $(INCLUDE_TFTP_COMMAND) == TRUE >> + ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf >> +!endif >> diff --git a/Platform/RaspberryPi/RPi3/RPi3.fdf b/Platform/RaspberryPi/RPi3/RPi3.fdf >> index 17c0094ac1cf..b06a15fb8ec3 100644 >> --- a/Platform/RaspberryPi/RPi3/RPi3.fdf >> +++ b/Platform/RaspberryPi/RPi3/RPi3.fdf >> @@ -232,6 +232,9 @@ [FV.FvMain] >> # UEFI application (Shell Embedded Boot Loader) >> # >> INF ShellPkg/Application/Shell/Shell.inf >> +!if $(INCLUDE_TFTP_COMMAND) == TRUE >> + INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf >> +!endif >> >> # >> # ACPI Support >> -- >> 2.21.0.windows.1 >>