From: Laszlo Ersek <lersek@redhat.com>
To: Leo Duran <leo.duran@amd.com>, edk2-devel@ml01.01.org
Cc: brijesh.singh@amd.com, jordan.l.justen@intel.com,
jeff.fan@intel.com, michael.d.kinney@intel.com,
liming.gao@intel.com, maurice.ma@intel.com,
prince.agyeman@intel.com, ruiyu.ni@intel.com,
kelly.steele@intel.com, david.wei@intel.com, mang.guo@intel.com
Subject: Re: [PATCH v4 9/9] Modify QemuFwCfgLib to use new BaseIoFifoLib library.
Date: Fri, 6 Jan 2017 17:40:21 +0100 [thread overview]
Message-ID: <6b2dff56-8916-1b52-2a4b-bf8cba9345e0@redhat.com> (raw)
In-Reply-To: <1483719899-16125-10-git-send-email-leo.duran@amd.com>
On 01/06/17 17:24, Leo Duran wrote:
> From: Brijesh Singh <brijesh.singh@amd.com>
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
> Signed-off-by: Leo Duran <leo.duran@amd.com>
> ---
> OvmfPkg/Library/QemuFwCfgLib/Ia32/IoLibExAsm.nasm | 55 -----------------------
> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 55 +----------------------
> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf | 8 +---
> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSecLib.inf | 8 +---
> OvmfPkg/Library/QemuFwCfgLib/X64/IoLibExAsm.nasm | 52 ---------------------
> 5 files changed, 6 insertions(+), 172 deletions(-)
> delete mode 100644 OvmfPkg/Library/QemuFwCfgLib/Ia32/IoLibExAsm.nasm
> delete mode 100644 OvmfPkg/Library/QemuFwCfgLib/X64/IoLibExAsm.nasm
I should have suggested an improvement to the subject line earlier:
OvmfPkg/QemuFwCfgLib: use new BaseIoFifoLib library
There's no need to repost the series just because of this; we can fix up
the subject at commit / push.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks
Laszlo
> diff --git a/OvmfPkg/Library/QemuFwCfgLib/Ia32/IoLibExAsm.nasm b/OvmfPkg/Library/QemuFwCfgLib/Ia32/IoLibExAsm.nasm
> deleted file mode 100644
> index faa22e9..0000000
> --- a/OvmfPkg/Library/QemuFwCfgLib/Ia32/IoLibExAsm.nasm
> +++ /dev/null
> @@ -1,55 +0,0 @@
> -;------------------------------------------------------------------------------
> -;
> -; Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.<BR>
> -; This program and the accompanying materials
> -; are licensed and made available under the terms and conditions of the BSD License
> -; which accompanies this distribution. The full text of the license may be found at
> -; http://opensource.org/licenses/bsd-license.php.
> -;
> -; THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -; WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> -;
> -;------------------------------------------------------------------------------
> -
> - SECTION .text
> -
> -;------------------------------------------------------------------------------
> -; VOID
> -; EFIAPI
> -; IoReadFifo8 (
> -; IN UINTN Port,
> -; IN UINTN Size,
> -; IN VOID *Buffer
> -; );
> -;------------------------------------------------------------------------------
> -global ASM_PFX(IoReadFifo8)
> -ASM_PFX(IoReadFifo8):
> -
> - mov dx, [esp + 4]
> - mov ecx, [esp + 8]
> - push edi
> - mov edi, [esp + 16]
> -rep insb
> - pop edi
> - ret
> -
> -;------------------------------------------------------------------------------
> -; VOID
> -; EFIAPI
> -; IoWriteFifo8 (
> -; IN UINTN Port,
> -; IN UINTN Size,
> -; IN VOID *Buffer
> -; );
> -;------------------------------------------------------------------------------
> -global ASM_PFX(IoWriteFifo8)
> -ASM_PFX(IoWriteFifo8):
> -
> - mov dx, [esp + 4]
> - mov ecx, [esp + 8]
> - push esi
> - mov esi, [esp + 16]
> -rep outsb
> - pop esi
> - ret
> -
> diff --git a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c
> index 0bbf121..d2f7fc6 100644
> --- a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c
> +++ b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c
> @@ -2,6 +2,7 @@
>
> Copyright (c) 2011 - 2013, Intel Corporation. All rights reserved.<BR>
> Copyright (C) 2013, Red Hat, Inc.
> + Copyright (c) 2017, AMD Inc. All rights reserved.<BR>
>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD License
> @@ -18,6 +19,7 @@
> #include <Library/BaseMemoryLib.h>
> #include <Library/DebugLib.h>
> #include <Library/IoLib.h>
> +#include <Library/IoFifoLib.h>
> #include <Library/QemuFwCfgLib.h>
> #include <Library/MemoryAllocationLib.h>
> #include <Library/UefiBootServicesTableLib.h>
> @@ -26,59 +28,6 @@
>
>
> /**
> - Reads an 8-bit I/O port fifo into a block of memory.
> -
> - Reads the 8-bit I/O fifo port specified by Port.
> -
> - The port is read Count times, and the read data is
> - stored in the provided Buffer.
> -
> - This function must guarantee that all I/O read and write operations are
> - serialized.
> -
> - If 8-bit I/O port operations are not supported, then ASSERT().
> -
> - @param Port The I/O port to read.
> - @param Count The number of times to read I/O port.
> - @param Buffer The buffer to store the read data into.
> -
> -**/
> -VOID
> -EFIAPI
> -IoReadFifo8 (
> - IN UINTN Port,
> - IN UINTN Count,
> - OUT VOID *Buffer
> - );
> -
> -/**
> - Writes an 8-bit I/O port fifo from a block of memory.
> -
> - Writes the 8-bit I/O fifo port specified by Port.
> -
> - The port is written Count times, and the data are obtained
> - from the provided Buffer.
> -
> - This function must guarantee that all I/O read and write operations are
> - serialized.
> -
> - If 8-bit I/O port operations are not supported, then ASSERT().
> -
> - @param Port The I/O port to read.
> - @param Count The number of times to read I/O port.
> - @param Buffer The buffer to store the read data into.
> -
> -**/
> -VOID
> -EFIAPI
> -IoWriteFifo8 (
> - IN UINTN Port,
> - IN UINTN Count,
> - OUT VOID *Buffer
> - );
> -
> -
> -/**
> Selects a firmware configuration item for reading.
>
> Following this call, any data read from this item will start from
> diff --git a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf
> index 66ac778..e48c639 100644
> --- a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf
> +++ b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf
> @@ -4,6 +4,7 @@
> #
> # Copyright (C) 2013, Red Hat, Inc.
> # Copyright (c) 2008 - 2012, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2017, AMD Inc. All rights reserved.<BR>
> #
> # This program and the accompanying materials
> # are licensed and made available under the terms and conditions of the BSD License
> @@ -36,12 +37,6 @@ [Sources]
> QemuFwCfgLib.c
> QemuFwCfgPeiDxe.c
>
> -[Sources.IA32]
> - Ia32/IoLibExAsm.nasm
> -
> -[Sources.X64]
> - X64/IoLibExAsm.nasm
> -
> [Packages]
> MdePkg/MdePkg.dec
> OvmfPkg/OvmfPkg.dec
> @@ -51,5 +46,6 @@ [LibraryClasses]
> BaseMemoryLib
> DebugLib
> IoLib
> + IoFifoLib
> MemoryAllocationLib
>
> diff --git a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSecLib.inf b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSecLib.inf
> index c1d6a54..6275ba9 100644
> --- a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSecLib.inf
> +++ b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSecLib.inf
> @@ -4,6 +4,7 @@
> #
> # Copyright (C) 2013, Red Hat, Inc.
> # Copyright (c) 2008 - 2012, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2017, AMD Inc. All rights reserved.<BR>
> #
> # This program and the accompanying materials
> # are licensed and made available under the terms and conditions of the BSD License
> @@ -34,12 +35,6 @@ [Sources]
> QemuFwCfgLib.c
> QemuFwCfgSec.c
>
> -[Sources.IA32]
> - Ia32/IoLibExAsm.nasm
> -
> -[Sources.X64]
> - X64/IoLibExAsm.nasm
> -
> [Packages]
> MdePkg/MdePkg.dec
> OvmfPkg/OvmfPkg.dec
> @@ -49,5 +44,6 @@ [LibraryClasses]
> BaseMemoryLib
> DebugLib
> IoLib
> + IoFifoLib
> MemoryAllocationLib
>
> diff --git a/OvmfPkg/Library/QemuFwCfgLib/X64/IoLibExAsm.nasm b/OvmfPkg/Library/QemuFwCfgLib/X64/IoLibExAsm.nasm
> deleted file mode 100644
> index f1078f2..0000000
> --- a/OvmfPkg/Library/QemuFwCfgLib/X64/IoLibExAsm.nasm
> +++ /dev/null
> @@ -1,52 +0,0 @@
> -;------------------------------------------------------------------------------
> -;
> -; Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.<BR>
> -; This program and the accompanying materials
> -; are licensed and made available under the terms and conditions of the BSD License
> -; which accompanies this distribution. The full text of the license may be found at
> -; http://opensource.org/licenses/bsd-license.php.
> -;
> -; THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -; WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> -;
> -;------------------------------------------------------------------------------
> -
> - DEFAULT REL
> - SECTION .text
> -
> -;------------------------------------------------------------------------------
> -; VOID
> -; EFIAPI
> -; IoReadFifo8 (
> -; IN UINTN Port, // rcx
> -; IN UINTN Size, // rdx
> -; IN VOID *Buffer // r8
> -; );
> -;------------------------------------------------------------------------------
> -global ASM_PFX(IoReadFifo8)
> -ASM_PFX(IoReadFifo8):
> -
> - xchg rcx, rdx
> - xchg rdi, r8 ; rdi: buffer address; r8: save rdi
> -rep insb
> - mov rdi, r8 ; restore rdi
> - ret
> -
> -;------------------------------------------------------------------------------
> -; VOID
> -; EFIAPI
> -; IoWriteFifo8 (
> -; IN UINTN Port, // rcx
> -; IN UINTN Size, // rdx
> -; IN VOID *Buffer // r8
> -; );
> -;------------------------------------------------------------------------------
> -global ASM_PFX(IoWriteFifo8)
> -ASM_PFX(IoWriteFifo8):
> -
> - xchg rcx, rdx
> - xchg rsi, r8 ; rdi: buffer address; r8: save rdi
> -rep outsb
> - mov rsi, r8 ; restore rdi
> - ret
> -
>
next prev parent reply other threads:[~2017-01-06 16:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 16:24 [PATCH v4 0/9] BaseIoFifoLib Leo Duran
2017-01-06 16:24 ` [PATCH v4 1/9] MdePkg: Add BaseIoFifoLib library Leo Duran
2017-01-06 16:24 ` [PATCH v4 2/9] CorebootPayloadPkg: Modify .DSC files that include UefiCpuPkg/CpuIo2Dxe Leo Duran
2017-01-10 3:59 ` Ma, Maurice
2017-01-06 16:24 ` [PATCH v4 3/9] DuetPkg: " Leo Duran
2017-01-06 16:24 ` [PATCH v4 4/9] OvmfPkg: " Leo Duran
2017-01-06 16:35 ` Laszlo Ersek
2017-01-06 16:24 ` [PATCH v4 5/9] QuarkPlatformPkg: " Leo Duran
2017-01-06 16:24 ` [PATCH v4 6/9] UefiCpuPkg: " Leo Duran
2017-01-06 16:24 ` [PATCH v4 7/9] Vlv2TbltDevicePkg: " Leo Duran
2017-01-09 2:16 ` Wei, David
2017-01-06 16:24 ` [PATCH v4 8/9] Modify UefiCpuPkg/CpuIo2Dxe to use new BaseIoFifoLib library Leo Duran
2017-01-06 16:24 ` [PATCH v4 9/9] Modify QemuFwCfgLib " Leo Duran
2017-01-06 16:40 ` Laszlo Ersek [this message]
2017-01-06 16:30 ` [PATCH v4 0/9] BaseIoFifoLib Duran, Leo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b2dff56-8916-1b52-2a4b-bf8cba9345e0@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox