From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.221.66; helo=mail-wr1-f66.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 95F662117B54F for ; Tue, 6 Nov 2018 12:35:19 -0800 (PST) Received: by mail-wr1-f66.google.com with SMTP id z16-v6so15068089wrv.2 for ; Tue, 06 Nov 2018 12:35:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sIaaxR9nOC3RS3f95xP7Y501qPuGT5EHKuNtoe3l0TY=; b=jFoiI/QJmr4jQ8mSAO2BBFy0zka/3d2hKWm+DYv97XlOoK2vY2zQEGgsSm/8a/YjtD GWjiX/Q3fQs7ExndMTX7oR/enphKgmwVPDskmTYBeiYQpNJ+utgCYm4R1MhiSf8BErFw ehyua/ql8t/LnPJwAP6064ekqtev9U4xcfWHxQ9j1XccoRGXY9tKMimYmoUe+Uc9r7yt GJ8CybrhiSAFoM95DL6Zj91oOmC5VNhuMn6ZaYgRhkAngnY1C0KubvULH29fEVJIbp7M DXYfoIOzfUj8AE13hkOx6At/ROI1fh77+iTbDZOKrNF6+YwpqbfQVHYDBnpVQ48X5HJs LMJw== X-Gm-Message-State: AGRZ1gITZYNISaNx9+rK4JpzGTvWILWkZg3KDWhRflUJ4/s9cIg96HSt luHA5WqHBS+aF8mLPROZ3UWGorZArnU= X-Google-Smtp-Source: AJdET5chJZ4PAkyaRm5TXSx3+PJE4VEe/Gt93xJvlC0Vch6K9TbJe0lg/Y9LGA4t7rCL8/Mi+Ljqyg== X-Received: by 2002:adf:ea12:: with SMTP id q18-v6mr4291505wrm.224.1541536518236; Tue, 06 Nov 2018 12:35:18 -0800 (PST) Received: from [192.168.1.74] (67.23.27.109.rev.sfr.net. [109.27.23.67]) by smtp.gmail.com with ESMTPSA id c19-v6sm2267280wmb.34.2018.11.06.12.35.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 12:35:17 -0800 (PST) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: michael.d.kinney@intel.com, eric.jin@intel.com References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> <20181106175833.26964-13-ard.biesheuvel@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <6b2e47df-92d0-4364-3a37-e97dcf82e295@redhat.com> Date: Tue, 6 Nov 2018 21:35:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181106175833.26964-13-ard.biesheuvel@linaro.org> Subject: Re: [PATCH edk2-staging 12/19] IntelUndiPkg/GigUndiDxe: cast E1000MemCopy () args to correct pointer type X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 20:35:20 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 6/11/18 18:58, Ard Biesheuvel wrote: > E1000MemCopy () takes UINT8 pointers not INT8 pointers, so cast the > arguments to the correct type. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Philippe Mathieu-Daudé > --- > IntelUndiPkg/GigUndiDxe/e1000.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/IntelUndiPkg/GigUndiDxe/e1000.c b/IntelUndiPkg/GigUndiDxe/e1000.c > index 1f08a5d67b2d..4c9a06b8cf73 100644 > --- a/IntelUndiPkg/GigUndiDxe/e1000.c > +++ b/IntelUndiPkg/GigUndiDxe/e1000.c > @@ -674,8 +674,8 @@ E1000Receive ( > > // Copy the packet from our list to the EFI buffer. > E1000MemCopy ( > - (INT8 *) (UINTN) CpbReceive->BufferAddr, > - (INT8 *) (UINTN) ReceiveDescriptor->buffer_addr, > + (UINT8 *) (UINTN) CpbReceive->BufferAddr, > + (UINT8 *) (UINTN) ReceiveDescriptor->buffer_addr, > TempLen > ); > >