From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web11.1827.1605172373587357212
 for <devel@edk2.groups.io>;
 Thu, 12 Nov 2020 01:12:54 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E37F9139F;
	Thu, 12 Nov 2020 01:12:51 -0800 (PST)
Received: from [192.168.1.81] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 74E223F73C;
	Thu, 12 Nov 2020 01:12:50 -0800 (PST)
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v3-resend] SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount
To: Vijayenthiran Subramanian <vijayenthiran.subramaniam@arm.com>,
 devel@edk2.groups.io, leif@nuviainc.com
Cc: michael.d.kinney@intel.com, thomas.abraham@arm.com, Sami.Mujawar@arm.com,
 Aditya.Angadi@arm.com
References: <1601991736-32039-1-git-send-email-vijayenthiran.subramaniam@arm.com>
 <CAC0BY-fOyYV1be52TSuyB=d0MLNCw6L0Q=k0BBWiPq_NiBC_yw@mail.gmail.com>
 <CAC0BY-czWk9UJNSN+E4+tcWiUUBNHWCD1UGHHPB04bMM9EGavw@mail.gmail.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <6b63ff3c-99b5-f330-079e-34d87122465f@arm.com>
Date: Thu, 12 Nov 2020 10:12:39 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <CAC0BY-czWk9UJNSN+E4+tcWiUUBNHWCD1UGHHPB04bMM9EGavw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

On 11/12/20 9:09 AM, Vijayenthiran Subramanian wrote:
> Hi all,
>=20
> On Wed, Oct 14, 2020 at 7:33 AM Vijayenthiran Subramanian
> <vijayenthiran.subramaniam@arm.com> wrote:
>>
>> Hi all,
>>
>> On Tue, Oct 6, 2020 at 1:42 PM Vijayenthiran Subramaniam
>> <vijayenthiran.subramaniam@arm.com> wrote:
>>>
>>> Commit e8fe2026dd79 (=E2=80=9CPlatform/ARM/SgiPkg: Use chip count con=
stant on
>>> rdn1edgex2 platform=E2=80=9D) used the PcdChipCount constant but did =
not declare
>>> its use in the ACPI table module. Fix this by listing it in the list =
of
>>> PCDs to be looked up.
>>>
>>> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@a=
rm.com>
>>> Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>
>>> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>>> ---
>>>
>>> Resending PATCH-v3 [1] with Reviewed-bys added.
>>>
>>> [1]: https://edk2.groups.io/g/devel/topic/77339902
>>>
>>> Changes since v2:
>>>    - Rebased to latest master and repost.
>>>
>>> Changes since v1:
>>>    - Add commit id in commit message for which this patch fixes the b=
uild
>>>      failure.
>>>
>>>   Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf =
b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
>>> index 974d9db543..d44f02ab0c 100644
>>> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
>>> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
>>> @@ -45,6 +45,8 @@
>>>     gArmSgiTokenSpaceGuid.PcdDramBlock2Base
>>>     gArmSgiTokenSpaceGuid.PcdDramBlock2Size
>>>
>>> +  gArmSgiTokenSpaceGuid.PcdChipCount
>>> +
>>>     gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
>>>     gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
>>>     gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
>>> --
>>> 2.17.1
>>
>> A kindly reminder for this patch.
>>
>> Regards,
>> Vijayenthiran
>=20
> A gentle reminder to take a look at this patch.
>=20

My apologies

Pushed as 1a9cbd7fe9cc..867efd012b2f