* [edk2-platforms] [PATCH v3-resend] SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount
@ 2020-10-06 13:42 Vijayenthiran Subramaniam
2020-10-14 7:33 ` [edk2-devel] " Vijayenthiran Subramaniam
0 siblings, 1 reply; 5+ messages in thread
From: Vijayenthiran Subramaniam @ 2020-10-06 13:42 UTC (permalink / raw)
To: devel, leif, Ard.Biesheuvel, thomas.abraham; +Cc: Sami.Mujawar, Aditya.Angadi
Commit e8fe2026dd79 (“Platform/ARM/SgiPkg: Use chip count constant on
rdn1edgex2 platform”) used the PcdChipCount constant but did not declare
its use in the ACPI table module. Fix this by listing it in the list of
PCDs to be looked up.
Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
---
Resending PATCH-v3 [1] with Reviewed-bys added.
[1]: https://edk2.groups.io/g/devel/topic/77339902
Changes since v2:
- Rebased to latest master and repost.
Changes since v1:
- Add commit id in commit message for which this patch fixes the build
failure.
Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
index 974d9db543..d44f02ab0c 100644
--- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
+++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
@@ -45,6 +45,8 @@
gArmSgiTokenSpaceGuid.PcdDramBlock2Base
gArmSgiTokenSpaceGuid.PcdDramBlock2Size
+ gArmSgiTokenSpaceGuid.PcdChipCount
+
gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [edk2-devel] [edk2-platforms] [PATCH v3-resend] SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount
2020-10-06 13:42 [edk2-platforms] [PATCH v3-resend] SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount Vijayenthiran Subramaniam
@ 2020-10-14 7:33 ` Vijayenthiran Subramaniam
2020-11-12 8:09 ` Vijayenthiran Subramaniam
0 siblings, 1 reply; 5+ messages in thread
From: Vijayenthiran Subramaniam @ 2020-10-14 7:33 UTC (permalink / raw)
To: devel; +Cc: leif, Ard.Biesheuvel, thomas.abraham, Sami.Mujawar, Aditya.Angadi
Hi all,
On Tue, Oct 6, 2020 at 1:42 PM Vijayenthiran Subramaniam
<vijayenthiran.subramaniam@arm.com> wrote:
>
> Commit e8fe2026dd79 (“Platform/ARM/SgiPkg: Use chip count constant on
> rdn1edgex2 platform”) used the PcdChipCount constant but did not declare
> its use in the ACPI table module. Fix this by listing it in the list of
> PCDs to be looked up.
>
> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
>
> Resending PATCH-v3 [1] with Reviewed-bys added.
>
> [1]: https://edk2.groups.io/g/devel/topic/77339902
>
> Changes since v2:
> - Rebased to latest master and repost.
>
> Changes since v1:
> - Add commit id in commit message for which this patch fixes the build
> failure.
>
> Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> index 974d9db543..d44f02ab0c 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> @@ -45,6 +45,8 @@
> gArmSgiTokenSpaceGuid.PcdDramBlock2Base
> gArmSgiTokenSpaceGuid.PcdDramBlock2Size
>
> + gArmSgiTokenSpaceGuid.PcdChipCount
> +
> gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
> gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
> gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
> --
> 2.17.1
A kindly reminder for this patch.
Regards,
Vijayenthiran
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [edk2-platforms] [PATCH v3-resend] SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount
2020-10-14 7:33 ` [edk2-devel] " Vijayenthiran Subramaniam
@ 2020-11-12 8:09 ` Vijayenthiran Subramaniam
2020-11-12 9:12 ` Ard Biesheuvel
0 siblings, 1 reply; 5+ messages in thread
From: Vijayenthiran Subramaniam @ 2020-11-12 8:09 UTC (permalink / raw)
To: devel, leif, Ard.Biesheuvel
Cc: michael.d.kinney, thomas.abraham, Sami.Mujawar, Aditya.Angadi
Hi all,
On Wed, Oct 14, 2020 at 7:33 AM Vijayenthiran Subramanian
<vijayenthiran.subramaniam@arm.com> wrote:
>
> Hi all,
>
> On Tue, Oct 6, 2020 at 1:42 PM Vijayenthiran Subramaniam
> <vijayenthiran.subramaniam@arm.com> wrote:
> >
> > Commit e8fe2026dd79 (“Platform/ARM/SgiPkg: Use chip count constant on
> > rdn1edgex2 platform”) used the PcdChipCount constant but did not declare
> > its use in the ACPI table module. Fix this by listing it in the list of
> > PCDs to be looked up.
> >
> > Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> > Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>
> > Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
> > ---
> >
> > Resending PATCH-v3 [1] with Reviewed-bys added.
> >
> > [1]: https://edk2.groups.io/g/devel/topic/77339902
> >
> > Changes since v2:
> > - Rebased to latest master and repost.
> >
> > Changes since v1:
> > - Add commit id in commit message for which this patch fixes the build
> > failure.
> >
> > Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> > index 974d9db543..d44f02ab0c 100644
> > --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> > @@ -45,6 +45,8 @@
> > gArmSgiTokenSpaceGuid.PcdDramBlock2Base
> > gArmSgiTokenSpaceGuid.PcdDramBlock2Size
> >
> > + gArmSgiTokenSpaceGuid.PcdChipCount
> > +
> > gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
> > gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
> > gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
> > --
> > 2.17.1
>
> A kindly reminder for this patch.
>
> Regards,
> Vijayenthiran
A gentle reminder to take a look at this patch.
Regards,
Vijayenthiran
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [edk2-platforms] [PATCH v3-resend] SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount
2020-11-12 8:09 ` Vijayenthiran Subramaniam
@ 2020-11-12 9:12 ` Ard Biesheuvel
2020-11-12 16:03 ` Vijayenthiran Subramaniam
0 siblings, 1 reply; 5+ messages in thread
From: Ard Biesheuvel @ 2020-11-12 9:12 UTC (permalink / raw)
To: Vijayenthiran Subramanian, devel, leif
Cc: michael.d.kinney, thomas.abraham, Sami.Mujawar, Aditya.Angadi
On 11/12/20 9:09 AM, Vijayenthiran Subramanian wrote:
> Hi all,
>
> On Wed, Oct 14, 2020 at 7:33 AM Vijayenthiran Subramanian
> <vijayenthiran.subramaniam@arm.com> wrote:
>>
>> Hi all,
>>
>> On Tue, Oct 6, 2020 at 1:42 PM Vijayenthiran Subramaniam
>> <vijayenthiran.subramaniam@arm.com> wrote:
>>>
>>> Commit e8fe2026dd79 (“Platform/ARM/SgiPkg: Use chip count constant on
>>> rdn1edgex2 platform”) used the PcdChipCount constant but did not declare
>>> its use in the ACPI table module. Fix this by listing it in the list of
>>> PCDs to be looked up.
>>>
>>> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
>>> Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>
>>> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>>> ---
>>>
>>> Resending PATCH-v3 [1] with Reviewed-bys added.
>>>
>>> [1]: https://edk2.groups.io/g/devel/topic/77339902
>>>
>>> Changes since v2:
>>> - Rebased to latest master and repost.
>>>
>>> Changes since v1:
>>> - Add commit id in commit message for which this patch fixes the build
>>> failure.
>>>
>>> Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
>>> index 974d9db543..d44f02ab0c 100644
>>> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
>>> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
>>> @@ -45,6 +45,8 @@
>>> gArmSgiTokenSpaceGuid.PcdDramBlock2Base
>>> gArmSgiTokenSpaceGuid.PcdDramBlock2Size
>>>
>>> + gArmSgiTokenSpaceGuid.PcdChipCount
>>> +
>>> gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
>>> gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
>>> gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
>>> --
>>> 2.17.1
>>
>> A kindly reminder for this patch.
>>
>> Regards,
>> Vijayenthiran
>
> A gentle reminder to take a look at this patch.
>
My apologies
Pushed as 1a9cbd7fe9cc..867efd012b2f
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [edk2-platforms] [PATCH v3-resend] SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount
2020-11-12 9:12 ` Ard Biesheuvel
@ 2020-11-12 16:03 ` Vijayenthiran Subramaniam
0 siblings, 0 replies; 5+ messages in thread
From: Vijayenthiran Subramaniam @ 2020-11-12 16:03 UTC (permalink / raw)
To: devel, ard.biesheuvel
Cc: leif, michael.d.kinney, thomas.abraham, Sami.Mujawar,
Aditya.Angadi
On Thu, Nov 12, 2020 at 9:12 AM Ard Biesheuvel <ard.biesheuvel@arm.com> wrote:
>
> On 11/12/20 9:09 AM, Vijayenthiran Subramanian wrote:
> > Hi all,
> >
> > On Wed, Oct 14, 2020 at 7:33 AM Vijayenthiran Subramanian
> > <vijayenthiran.subramaniam@arm.com> wrote:
> >>
> >> Hi all,
> >>
> >> On Tue, Oct 6, 2020 at 1:42 PM Vijayenthiran Subramaniam
> >> <vijayenthiran.subramaniam@arm.com> wrote:
> >>>
> >>> Commit e8fe2026dd79 (“Platform/ARM/SgiPkg: Use chip count constant on
> >>> rdn1edgex2 platform”) used the PcdChipCount constant but did not declare
> >>> its use in the ACPI table module. Fix this by listing it in the list of
> >>> PCDs to be looked up.
> >>>
> >>> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> >>> Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>
> >>> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
> >>> ---
> >>>
> >>> Resending PATCH-v3 [1] with Reviewed-bys added.
> >>>
> >>> [1]: https://edk2.groups.io/g/devel/topic/77339902
> >>>
> >>> Changes since v2:
> >>> - Rebased to latest master and repost.
> >>>
> >>> Changes since v1:
> >>> - Add commit id in commit message for which this patch fixes the build
> >>> failure.
> >>>
> >>> Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
> >>> 1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> >>> index 974d9db543..d44f02ab0c 100644
> >>> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> >>> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> >>> @@ -45,6 +45,8 @@
> >>> gArmSgiTokenSpaceGuid.PcdDramBlock2Base
> >>> gArmSgiTokenSpaceGuid.PcdDramBlock2Size
> >>>
> >>> + gArmSgiTokenSpaceGuid.PcdChipCount
> >>> +
> >>> gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
> >>> gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
> >>> gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
> >>> --
> >>> 2.17.1
> >>
> >> A kindly reminder for this patch.
> >>
> >> Regards,
> >> Vijayenthiran
> >
> > A gentle reminder to take a look at this patch.
> >
>
> My apologies
>
> Pushed as 1a9cbd7fe9cc..867efd012b2f
Thanks Ard.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-12 16:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-06 13:42 [edk2-platforms] [PATCH v3-resend] SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount Vijayenthiran Subramaniam
2020-10-14 7:33 ` [edk2-devel] " Vijayenthiran Subramaniam
2020-11-12 8:09 ` Vijayenthiran Subramaniam
2020-11-12 9:12 ` Ard Biesheuvel
2020-11-12 16:03 ` Vijayenthiran Subramaniam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox