From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4231A941905 for ; Fri, 8 Sep 2023 13:58:52 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=8fB4n5mltBBkyoQErAxL67wPX529o6owL/1DJENi8AI=; c=relaxed/simple; d=groups.io; h=Feedback-ID:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694181531; v=1; b=AvRta7pdCNvSNhIDkCtpYbIUoZ7eRAaY0THTXMucnBEvgguNwvQJQ7s0h4Ic6I5sGpuWGQ8q 4cbkv/Kg9ufiC9rXyw/xqGIxAfqTFKGo1BTT+C3Gu8BFz4YnbC+D5wxtuCCmE9OdU2G5R83YhXs 0qHTuZcZAEVnYN7HVBl8T8zM= X-Received: by 127.0.0.2 with SMTP id QvTmYY7687511x34ab2Ymtmf; Fri, 08 Sep 2023 06:58:51 -0700 X-Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mx.groups.io with SMTP id smtpd.web11.39769.1694181530010997545 for ; Fri, 08 Sep 2023 06:58:50 -0700 X-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 52A745C0220; Fri, 8 Sep 2023 09:58:49 -0400 (EDT) X-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 08 Sep 2023 09:58:49 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudehjedgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeegfeegveduheejgfduffefhfehleehiefghfetvdejvdelhfeukefhhfdv geehveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail X-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Sep 2023 09:58:48 -0400 (EDT) Message-ID: <6b76efe3-6376-f7b9-1638-eb148ba8fa2a@bsdio.com> Date: Fri, 8 Sep 2023 07:58:37 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: don't exit early if RSDP is not found in memory To: devel@edk2.groups.io, corvink@FreeBSD.org Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Peter Grehan References: <20230907083429.82300-1-corvink@FreeBSD.org> <20230907083429.82300-2-corvink@FreeBSD.org> From: "Rebecca Cran" In-Reply-To: <20230907083429.82300-2-corvink@FreeBSD.org> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@bsdio.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: H5JctVGzCMq0hJ9RVbY2fWp5x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=AvRta7pd; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Rebecca Cran On 9/7/23 02:34, Corvin Köhne wrote: > If OVMF fails to find the RSDP in memory, it should fall back installing > the statically provided ACPI tables. > > Signed-off-by: Corvin Köhne > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Cc: Rebecca Cran > Cc: Peter Grehan > --- > OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 19 ++++++++----------- > 1 file changed, 8 insertions(+), 11 deletions(-) > > diff --git a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c b/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c > index fb926a8bd803..57b1e7a99666 100644 > --- a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c > +++ b/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c > @@ -259,19 +259,17 @@ InstallAcpiTables ( > BHYVE_BIOS_PHYSICAL_END, > &Rsdp > ); > - if (EFI_ERROR (Status)) { > - return Status; > - } > - > - Status = InstallAcpiTablesFromRsdp ( > - AcpiTable, > - Rsdp > - ); > if (!EFI_ERROR (Status)) { > - return EFI_SUCCESS; > + Status = InstallAcpiTablesFromRsdp ( > + AcpiTable, > + Rsdp > + ); > + if (!EFI_ERROR (Status)) { > + return EFI_SUCCESS; > + } > } > > - if (Status != EFI_NOT_FOUND) { > + if (EFI_ERROR (Status)) { > DEBUG ( > ( > DEBUG_WARN, > @@ -280,7 +278,6 @@ InstallAcpiTables ( > Status > ) > ); > - return Status; > } > > Status = InstallOvmfFvTables (AcpiTable); -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108448): https://edk2.groups.io/g/devel/message/108448 Mute This Topic: https://groups.io/mt/101210702/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-